Summary:
When mirror mode is toggled, the position of spacer parts in preview is not changed.
So I added the code to update spacer parts.
@T3367
Test Plan:
1. laucnch enventor
2. added the spacer to preview
3. toggle mirror mode more than two times.
4. see the spacer parts whether it is updated or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3835
Summary:
when mirror mode is applied, the live edit item is added to wrong position.
so I added mirror mode checking to show correctly.
@T3368
Test Plan:
1. launcher enventor
2. enable mirror mode
3. add a live edit item to preview
4. check that the position of the item is right
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3834
Summary: Added new toolbar item to support mirror mode
Test Plan:
1. luanch enventor
2. toggle mirror mode item of toolbar at the left-top or press ctrl + M
3. see the mirror mode working well
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3813
Summary:
If we input the quotation mark("), the code under the mark are changed to gray.
so I changed the limitation from the start of quotation mark to the end of the line.
Test Plan:
1. launch enventor
2. input the quotation mark(") in the middle of the code
3. see the syntax color change range about string syntax color
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3825
Summary:
It is better the image resource block is in the group.
so I moved the block into the group in basic.edc
Test Plan:
1. launch enventor
2. create new file as basic
3. see the image resource block in group
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3816
Check if edj file set is finished and do not call edje_edit functions if
edj file set is not finished.
Test Plan:
1. Open edc
2. Modify edc incorrectly (e.g. Remove semicolon)
3. Save edc
4. Open the saved edc
5. Mouse double click "target" in program.
Summary:
In my opinion, the solution can move the position of update_edj_file_internal(vd) in update_edj_file.
However, I added dummy_obj_update only above failure case of edj load.
Test Plan:
1. Run Enventor and Load basic edc file
2. Select all source code with Ctrl+A and remove them with del or backspace.
3. Check the dummy part
Reviewers: Jaehyun_Cho, Hermet
Subscribers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3808
Summary:
improve the image's template code.
when inserting image's template code,
images block has redundant annotation.
Test Plan:
1. insert image's part using ctrl + t
2. see the images part and check the difference with before
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3814
Summary:
- When calculating the position of cursor, the code cannot get group information.
So, if we cannot get group information including position, add blocking code.
Test Plan:
1. Open Enventor
2. Remove all code after selecting with Ctrl+a
3. Click any part in edj editor
Reviewers: Hermet, Jaehyun_Cho
Subscribers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3804
On Windows, new line is represented as "\r\n".
Therefore, '\r' is checked when indented code line is created.
Otherwise, unnecessary newlines are inserted after indentation on
Windows.
Summary:
Current generated part name from the live edit is too unfamiliar with users.
We need to improve for more formal naming rule like,
ex) rect_xxxx
image_xxxx
swallow_xxxx
Test Plan:
1. Open Enventor
2. Add rect, image, swllow, text, textblock, spacer
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3793
previously, the button was available even if the inverting animation was going
on. This caused the corruption view size because of context loss.
We could avoid this issue by freezing button when transition is going on.
Skip a group selection callback because it leads the editor cursor jump on to
the group area. But this group updation could be triggered in a various
scenario. The cursor should be jumped only when user clicked a group item
in the genlist.
Do not apply indentation when pasted string does not contain keywords
which cause a new line. (e.g. string not containing ';')
Test Plan:
1. Open basic.edc
2. Copy "default"
3. Paste at the same position.
Taehyub Kim
Hermet Park
Mykyta Biliavskyi
Jaehyun Cho
Yongheon, Shin
Tom Hacohen