Summary: disable focus for resize slider bar
Test Plan:
1. launch enventor
2. show resize ctxpopup using status bar
3. check the focus is disable
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4232
Summary: add the new feature to jump to the part define
Test Plan:
1. launch enventor
2. click mouse right button on "relative to" part name in text view
3. check selection is on the part define
Reviewers: Hermet, NikaWhite, bowonryu, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Tags: #enventor
Differential Revision: https://phab.enlightenment.org/D4167
change the geometry of highlight to its common geometry,
not actual text area.
This change is for consistency for wireframes,
and I expect user want it.
Summary: restore resize and move callabck for layout
Test Plan:
1. launch enventor
2. open a basic edc
3. add spacer part
4. turn on wireframe
5. resize the view
6. see the result of wireframe
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4216
Conflicts:
src/lib/wireframes_obj.c
When list item's close button is clicked, this selection is triggered
prior to the close button clicked callback.
It's useless to perform this selected callback anyway this file tab
item is gonna removed soon. But, due to the list's behavior,
it's unavoidable so we need this tricky animator.
Previously, indentation logic produced a duplicated string if the copied
string ends with spaces.
Test Plan:
1. Open basic template.
2. Cut string right before "}" in the text view.
(e.g. Copy from 5th line to 7th line right before "}" in basic edc.)
3. Paste the cut string.
4. See that 6th line's string is pasted redundantly.
Previously, they are disabled if the workspace is not specified.
We don't need this anymore.
Because we gonna support runtime changing for the workspace directory.
If usr's system is shutdown unexpectedly,
the lock file wont' be removed properly.
Store the lock file in the OS temporary folder
so it can be removed defintely when OS is turned off.
Now, Enventor allows only one enventor instance.
This is sort of a limited way, but it would be better while enventor supports
multiple file editing.
Unless it perfectly covers scenarios that overwrite editor code from other
process, Enventor will limit its process count.
Summary:
when animation is working, wire frame is not updated.
so I fixed it.
Test Plan:
1. launch enventor.
2. run animation template
3. see the result about update of wireframe
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D4214
there is a quite complex case that non-thread safe code
that may occur crash or wrong behavior of enventor.
just improve the thread safe code to avoid the situation.
This patch is temporary patch to remove focus highlight on template
selection button of new file open. (enventor -t)
Without this patch, en_edit cannot get focus because its visibility is
set with false.
just realized that ecore_thread_cancel() wont call the thread cancel function instantly.
and this broke parser sequences that memory corruption.
Fix that situation to not write invalid memory.
Terminate redoundo instance after edc editor private resources are removed.
Redoundo has a entry delete callback, and it frees the redoundo private memory there.
But, if a redoundo instance is removed before entry delete callback is called,
invalid memory access will be happened.
Acutally this's broken memory.
So prevent this scenario by correcting function call order.
@fix
Test Plan:
1. enventor
2. press F1
3. select list item (shortcut keys)
4. scroll down
5. back
6. select list item (shortcut keys)
7. observe scroller's position
Reviewers: Hermet, Jaehyun_Cho, herb
Differential Revision: https://phab.enlightenment.org/D4213
While adding new live objects, some of wireframes is disappeared.
Actually, they were blocked by new live object content.
Fix by re-adding them as smart members.
when user close a non selected file tab item,
Enventor occasionaly has a crash.
As investested, it seemed like an EFL issue.
But we can easily fix this by moving the function call.
Summary: fix the view resize callback
Test Plan:
1. launch enventor
2. run group template
3. change the view size
4. change the group
5. change the view size
6. change the group to firxt
7. see the result
Reviewers: Hermet, NikaWhite, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4208
Summary: when group is changed, view information should be updated
Test Plan:
1. launch enventor
2. run group template
3. change the view size
4. change the group
5. change the view size
6. change the group to firxt
7. see the result
Reviewers: Hermet, NikaWhite, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4207
Summary: GUI composed of the edc layout.
Test Plan:
1. enventor
2. press F1 Key
Reviewers: Hermet, Jaehyun_Cho, herb
Differential Revision: https://phab.enlightenment.org/D4187
This reverts commit 335575eb84
Although using macro as a group name is not a common usage, but it takes
a lot of efforts to maintain and implement new features based on this.
Summary:
In case of the live edit item has min size without relative to part,
the size of the item should not be changed.
To cover this case, I added more condition
Test Plan:
1. launch envnetor
2. click a live edit item on tools
3. check the fixed option without "relative to" setting
4. insert the item with mouse double click
5. see the min size of the item while the view size is changing
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4173
When go to window is unfocused, window is closed.
Though this behavior was intended, the functionality was not quite nice.
Even this caused a weired behavior(bug) on windows that,
go to window was closed when it's minimized.
So get rid of this policy!
@fix T3922
If user don't specify the workspace path,
Enventor set the workspace path to current directory path
while turning off file browser and file tab function in default.
Previously each live edit components are messed up in stacking.
Restacked by putting wireframe, dummy objects
below live edit object, control points, align lines and texts.
This required a totally hackishy method but there are no other solution so far.
@fix T4026
fix a side effect of localizing floats.
_posix_fp() uses static stringbuffer.
If this function is called multiple times in printf(),
previous buffer data will be invalid.
we are calling this for x, y twice in one func.
Summary:
Enventor live edit would generate invalid code with
the french locale.
Indeed, french uses a comma (",") as the decimal point,
instead of the dot. With localization enabled, printf()
would automatically localized the floating point,
introducing a comma in the edje code where a dot is
expected...
To avoid this, we now enclose the floats we don't want
to be localized (use the implicit POSIX local: with a dot)
in a function that looks the current locale and replace
the decimal point with a dot.
Test Plan:
(1) Without the patch, call LC_ALL=C enventor and see live
edit if correct.
(2) Without the patch, call LC_ALL=fr_FR.UTF-8 envetor and
see live edit generate invalid edje code.
(3) Apply the patch, and repeat steps (1) and (2) and observe
that both cases now success.
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D4146
Summary:
current error message is hard to read.
if the message has a syntax color, then it will be better.
Reviewers: Hermet, herb, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4124
Previously, searching files in file browser causes crash.
Now, each file browser data contains genlist item and the genlist item
is also deleted when the file browser data is deallocated.
Changed item concept that only one item can represent the enventor object.
I'd thought multiple editors of Enventor could be active at the same time,
but it brought Enventor Lib has over-concept feature,
because Enventor App doesn't support it so far.
I didn't dig further, but that corrupted enventor menu/setting.
probably, eina_stringshare ocurred memory corrution...?
anyhow, its useless to apply same font again.
@fix T4013
This properly switchs a current focused item view on realtime.
That means, when user switch files, it will display the first group
view in a new selected file.
Summary: change the description
Test Plan:
1. open new file
2. see the template name
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4091
Conflicts:
data/templates/Makefile.am
Hermet Park
Taehyub Kim
Jaehyun Cho
Bowon Ryu
Jean-Philippe Andre
Thiep Ha
Jean Guyomarc'h