editor: cleanup methods a little

This commit is contained in:
Andy Williams 2016-12-22 10:59:36 +00:00
parent 04d86d3250
commit 0bc9f3dc1d
1 changed files with 13 additions and 17 deletions

View File

@ -116,14 +116,12 @@ _suggest_item_return_get(Suggest_Item *item)
char *ret_str; char *ret_str;
int retlen; int retlen;
if (item->ret) if (!item->ret)
{ return strdup("");
retlen = strlen(item->ret) + 6;
ret_str = malloc(sizeof(char) * retlen); retlen = strlen(item->ret) + 6;
snprintf(ret_str, retlen, " %s<br>", item->ret); ret_str = malloc(sizeof(char) * retlen);
} snprintf(ret_str, retlen, " %s<br>", item->ret);
else
ret_str = strdup("");
return ret_str; return ret_str;
} }
@ -134,14 +132,12 @@ _suggest_item_parameter_get(Suggest_Item *item)
char *param_str; char *param_str;
int paramlen; int paramlen;
if (item->param) if (!item->param)
{ return strdup("");
paramlen = strlen(item->param) + 6;
param_str = malloc(sizeof(char) * paramlen); paramlen = strlen(item->param) + 6;
snprintf(param_str, paramlen, "<br>%s", item->param); param_str = malloc(sizeof(char) * paramlen);
} snprintf(param_str, paramlen, "<br>%s", item->param);
else
param_str = strdup("");
return param_str; return param_str;
} }
@ -1156,7 +1152,7 @@ _edi_editor_config_changed(void *data, int type EINA_UNUSED, void *event EINA_UN
} }
static void static void
_editor_del_cb(void *data, Evas *e EINA_UNUSED, Evas_Object *o EINA_UNUSED, void *event_info EINA_UNUSED) _editor_del_cb(void *data, Evas *e EINA_UNUSED, Evas_Object *o, void *event_info EINA_UNUSED)
{ {
Ecore_Event_Handler *ev_handler = data; Ecore_Event_Handler *ev_handler = data;