NorwayFun
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elm config tool - fix string mis-use of stale string ptrs from efreet 

if efreet updates its in memory db of themes/icons etc. the ptrs you
get from it will be invalid. always dup them out if you keep them
around after going back to main loop control. in this case a tiny
possible leak in stringshare won't ever matter... sot his fixes it

@fix
This commit is contained in:
Carsten Haitzler 2022-12-24 18:40:00 +00:00
parent 3267070da9
commit 21ad5e011f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/elementary/config.c
View File

@ -2455,7 +2455,8 @@ _status_config_icons(Evas_Object *win,
ic = elm_icon_add(li);
elm_image_file_set(ic, efreet_icon_path_find(th->name.internal, "folder", 48), NULL);
list_it = elm_list_item_append(li, th->name.name, ic, NULL,
_icon_theme_sel, th->name.internal);
_icon_theme_sel,
eina_stringshare_add(th->name.internal));
if (!strcmp(th->name.internal, "hicolor"))
def_it = list_it;