From 24c56e5a0a58b60699e924cf719fb01cdcac956d Mon Sep 17 00:00:00 2001 From: ChunEon Park Date: Wed, 14 Jan 2015 23:30:43 +0900 Subject: [PATCH] genlist: fix a crash when deleting a item in selected callback. if user deletes the item in the callback, current function(_item_select) would be corrupted. just leave the callback call in the last of the function. --- legacy/elementary/src/lib/elm_genlist.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/legacy/elementary/src/lib/elm_genlist.c b/legacy/elementary/src/lib/elm_genlist.c index a4ebbf89b2..81d6246abb 100644 --- a/legacy/elementary/src/lib/elm_genlist.c +++ b/legacy/elementary/src/lib/elm_genlist.c @@ -5669,9 +5669,6 @@ _item_select(Elm_Gen_Item *it) eina_list_append(sd->selected, eo_it); } - evas_object_ref(obj); - if (it->func.func) it->func.func((void *)it->func.data, WIDGET(it), eo_it); - evas_object_smart_callback_call(WIDGET(it), SIG_SELECTED, eo_it); elm_object_item_focus_set(eo_it, EINA_TRUE); _elm_genlist_item_content_focus_set(it, ELM_FOCUS_PREVIOUS); @@ -5692,6 +5689,12 @@ _item_select(Elm_Gen_Item *it) } } + evas_object_ref(obj); + + if (it->func.func) it->func.func((void *)it->func.data, WIDGET(it), eo_it); + if (EINA_MAGIC_CHECK((Elm_Widget_Item_Data *)it, ELM_WIDGET_ITEM_MAGIC)) + evas_object_smart_callback_call(WIDGET(it), SIG_SELECTED, eo_it); + evas_object_unref(obj); }