From 483abf1e07df63e158d6422501745b9958d47b9e Mon Sep 17 00:00:00 2001 From: Bluezery Date: Sun, 6 Nov 2011 06:14:31 +0000 Subject: [PATCH] From: Bluezery Subject: [E-devel] [ecore_file] Check a return value of ecore_con_url_get() _ecore_file_download_curl() does not check return value of even if ecore_con_url_get(), it can be failed. I add a simple error checking. Please review this patch. SVN revision: 64795 --- legacy/ecore/src/lib/ecore_file/ecore_file_download.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/legacy/ecore/src/lib/ecore_file/ecore_file_download.c b/legacy/ecore/src/lib/ecore_file/ecore_file_download.c index 88115323fb..bed6f8d84c 100644 --- a/legacy/ecore/src/lib/ecore_file/ecore_file_download.c +++ b/legacy/ecore/src/lib/ecore_file/ecore_file_download.c @@ -369,7 +369,15 @@ _ecore_file_download_curl(const char *url, const char *dst, job->progress_cb = progress_cb; _job_list = eina_list_append(_job_list, job); - ecore_con_url_get(job->url_con); + if (!ecore_con_url_get(job->url_con)) + { + ecore_con_url_free(job->url_con); + _job_list = eina_list_remove(_job_list, job); + fclose(job->file); + free(job->dst); + free(job); + return NULL; + } return job; }