NorwayFun
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eio/fallback: do not modify the children hash while iterating it 

this is invalid use of the hash api and will cause a crash

@fix

Differential Revision: https://phab.enlightenment.org/D6444
This commit is contained in:
Mike Blumenkrantz 2018-06-26 18:15:10 -04:00 committed by Marcel Hollerbach
parent f41b9ea204
commit 65afddf2ae
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/eio/eio_monitor_poll.c
View File

@ -194,8 +194,10 @@ _eio_monitor_fallback_heavy_cb(void *data, Ecore_Thread *thread)
if (backend->initialised && !ecore_thread_check(thread))
{
Eina_Hash_Tuple *tuple;
Eina_Array *arr;
it = eina_hash_iterator_tuple_new(backend->children);
arr = eina_array_new(1);
ecore_thread_main_loop_begin();
EINA_ITERATOR_FOREACH(it, tuple)
@ -206,11 +208,14 @@ _eio_monitor_fallback_heavy_cb(void *data, Ecore_Thread *thread)
{
_eio_monitor_send(backend->parent, tuple->key,
eio_file_is_dir(&cmp->buffer) ? EIO_MONITOR_DIRECTORY_DELETED : EIO_MONITOR_FILE_DELETED);
eina_hash_del(backend->children, tuple->key, tuple->data);
eina_array_push(arr, tuple->key);
}
}
ecore_thread_main_loop_end();
while (eina_array_count(arr))
eina_hash_del_by_key(backend->children, eina_array_pop);
eina_array_free(arr);
eina_iterator_free(it);
}