From 6949d1193eb7f3f7d9218157e78cdf1de5ba8c23 Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Thu, 25 Jun 2015 14:55:44 -0400 Subject: [PATCH] edje_cc: Fix dereference null return value Summary: Fix Coverity CID1308232 which reports that we may be passing NULL to strcmp here as the function _parse_param_get May return NULL. @fix Signed-off-by: Chris Michael --- src/bin/edje/edje_cc_parse.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bin/edje/edje_cc_parse.c b/src/bin/edje/edje_cc_parse.c index 9c4e6bcc08..5f405dfc7f 100644 --- a/src/bin/edje/edje_cc_parse.c +++ b/src/bin/edje/edje_cc_parse.c @@ -1843,10 +1843,14 @@ int get_param_index(char *str) { int index; + char *p; for(index = 0; index < get_arg_count(); index++) { - if(!strcmp(str,_parse_param_get(index))) + p = _parse_param_get(index); + if (!p) continue; + + if (!strcmp(str, p)) return index; }