NorwayFun
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

evas examples: Fix invalid assumption about proxy 

In the map examples, the map image UV size was based on the image
source geometry, rather than the image geometry itself.

In the example, this affects how the glass is mirrored. Before this
patch, the reflection is a single line stretched. EFL 1.18 and 1.19
seem to have the same issue, while 1.17 simply fails to show any
reflection. 1.16 fails miserably and the entire window is black.

If the original code was correct, then I believe that map and/or
proxy rendering have been modified in a way that affects the meaning
of those image UV parameters. But this seems like the regression (if
it is one) is in fact quite old.

@fix
This commit is contained in:
Jean-Philippe Andre 2017-04-25 17:54:44 +09:00
parent a8ba44b708
commit 70821182ff
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/examples/evas/evas-map-utils-eo.c
View File

@ -142,8 +142,8 @@ _anim_cb(void *data)
efl_gfx_map_enable_set(o, EINA_TRUE);
o = evas_object_name_find(ad->canvas, "obj4");
evas_object_geometry_get(o, &x, &y, &w, &h);
evas_object_image_size_get(evas_object_image_source_get(o), &img_w, &img_h);
efl_gfx_geometry_get(o, &x, &y, &w, &h);
efl_gfx_view_size_get(o, &img_w, &img_h);
efl_gfx_map_dup(o, ref);
efl_gfx_map_point_coord_set(o, 0, x, y + h, 0);

2
src/examples/evas/evas-map-utils.c
View File

@ -141,7 +141,7 @@ _anim_cb(void *data)
o = evas_object_name_find(ad->canvas, "obj4");
evas_object_geometry_get(o, &x, &y, &w, &h);
evas_object_image_size_get(evas_object_image_source_get(o), &img_w, &img_h);
evas_object_image_size_get(o, &img_w, &img_h);
m = evas_map_new(4);
evas_map_point_coord_set(m, 0, x, y + h, 0);