NorwayFun
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Scroll manager: remove unnecessary callback_del 

Child objects are already destoryed during destruction of the parent
object.

This fixes ERR messages when doing operations on the `event_rect`
object, which is already destroyed at that point.
This commit is contained in:
Daniel Hirt 2018-11-15 10:52:16 +02:00
parent c87d23f942
commit a7b1329b0e
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/lib/elementary/efl_ui_scroll_manager.c
View File

@ -1947,25 +1947,6 @@ _scroll_event_object_attach(Evas_Object *obj)
_efl_ui_scroll_manager_mouse_move_event_cb, sd);
}
static void
_scroll_event_object_detach(Evas_Object *obj)
{
EFL_UI_SCROLL_MANAGER_DATA_GET_OR_RETURN(obj, sd);
evas_object_event_callback_del_full
(sd->event_rect, EVAS_CALLBACK_MOUSE_WHEEL, _efl_ui_scroll_manager_wheel_event_cb,
sd);
evas_object_event_callback_del_full
(sd->event_rect, EVAS_CALLBACK_MOUSE_DOWN,
_efl_ui_scroll_manager_mouse_down_event_cb, sd);
evas_object_event_callback_del_full
(sd->event_rect, EVAS_CALLBACK_MOUSE_UP,
_efl_ui_scroll_manager_mouse_up_event_cb, sd);
evas_object_event_callback_del_full
(sd->event_rect, EVAS_CALLBACK_MOUSE_MOVE,
_efl_ui_scroll_manager_mouse_move_event_cb, sd);
}
static void
_efl_ui_scroll_manager_pan_content_changed_cb(void *data, const Efl_Event *event EINA_UNUSED)
{
@ -2463,8 +2444,6 @@ _efl_ui_scroll_manager_efl_object_destructor(Eo *obj, Efl_Ui_Scroll_Manager_Data
efl_event_callback_del
(sd->pan_obj, EFL_UI_PAN_EVENT_POSITION_CHANGED, _efl_ui_scroll_manager_pan_position_changed_cb, sd);
_scroll_event_object_detach(obj);
efl_destructor(efl_super(obj, MY_CLASS));
}