From aed0272e8c4f02965fafe6f5aca0451f289de70e Mon Sep 17 00:00:00 2001 From: Amitesh Singh Date: Thu, 23 Jan 2014 14:12:46 +0900 Subject: [PATCH] focus: Fixed focus issue that the highlight was not visible on first click. Summary: Focus highlight was not visible on first click on a widget with focus_highlight enabled on the window. This happens because on first click, the "elm,action,focus,show" signal was emitted before setting focus highlight edje object as theme object of elm window. In this patch, moved the _elm_win_focus_highlight_visible_set() call after focus highlight edje object set as theme object of window. This fixes T774. Test Plan: elementary_test->focus then click any widget. Focus won't appear for the first time. Reviewers: seoz, raster, woohyun Maniphest Tasks: T774 Differential Revision: https://phab.enlightenment.org/D462 --- legacy/elementary/src/lib/elm_win.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/legacy/elementary/src/lib/elm_win.c b/legacy/elementary/src/lib/elm_win.c index 3ef1daca58..7e111c93b5 100644 --- a/legacy/elementary/src/lib/elm_win.c +++ b/legacy/elementary/src/lib/elm_win.c @@ -763,7 +763,6 @@ _elm_win_focus_highlight_reconfigure(Elm_Win_Smart_Data *sd) else common_visible = sd->focus_highlight.cur.visible; - _elm_win_focus_highlight_visible_set(sd, common_visible); if (sig) elm_widget_signal_emit(target, sig, "elm"); @@ -798,6 +797,7 @@ _elm_win_focus_highlight_reconfigure(Elm_Win_Smart_Data *sd) evas_object_raise(fobj); the_end: + _elm_win_focus_highlight_visible_set(sd, common_visible); sd->focus_highlight.geometry_changed = EINA_FALSE; sd->focus_highlight.prev = sd->focus_highlight.cur; }