NorwayFun
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elementary: fix memory leaks when using elm_prefs 

"regex" is heap-allocated and is not handled by regfree().
We must explicitely call free() after a regfree() to remove
the regex_t from memory.
This commit is contained in:
Jean Guyomarc'h 2016-08-12 16:36:12 +02:00
parent b6b8289636
commit be67c1553a
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/modules/elementary/prefs/elm_entry.c
View File

@ -113,10 +113,18 @@ _entry_del_cb(void *data EINA_UNUSED,
Ecore_Timer *timer;
regex = evas_object_data_del(obj, "accept_regex");
if (regex) regfree(regex);
if (regex)
{
regfree(regex);
free(regex);
}
regex = evas_object_data_del(obj, "deny_regex");
if (regex) regfree(regex);
if (regex)
{
regfree(regex);
free(regex);
}
timer = evas_object_data_del(obj, "timer");
if (timer) ecore_timer_del(timer);
@ -163,6 +171,7 @@ elm_prefs_entry_add(const Elm_Prefs_Item_Iface *iface EINA_UNUSED,
{
regerror(ret, regex, buf, sizeof(buf));
regfree(regex);
free(regex);
ERR("bad regular expression (%s) on item's 'accept' tag (%s)."
" Because of that, the 'accept' tag will be dropped for the "
"item.", spec.s.accept, buf);
@ -182,6 +191,7 @@ elm_prefs_entry_add(const Elm_Prefs_Item_Iface *iface EINA_UNUSED,
{
regerror(ret, regex, buf, sizeof(buf));
regfree(regex);
free(regex);
ERR("bad regular expression (%s) on item's 'deny' tag (%s)."
" Because of that, the 'deny' tag will be dropped for the "
"item.", spec.s.deny, buf);