This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.
It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.
For fix it, using eo_isa() to check object types instead of string comparison.
@fix
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2148
Summary: If _elm_image_object_size_get fails, w and h have garbage value.
Test Plan: no
Reviewers: seoz, Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D2163
The problem occurs when no drop target below the mouse can receive the
data type provided and the mouse button is released. The mouse pointer
stays grabbed and this leads to issues for the next drags.
To solve this, on a bad drop, the destination window has to request
from the source window the end of the dnd.
Summary:
When evas gl/elm glview runs with direct rendering, it can not set these bits to window surface.
Because of no interface and method.This patch can do that.
This patch just uses current interface as a elm_config_accel_preference_set instead of new API.
Also, it is related D2144 patch.
Test Plan: ElmGL View test menu in elementary_test app JP's test app.
Reviewers: spacegrapher, cedric, raster, jpeg
Reviewed By: jpeg
Subscribers: mer.kim
Differential Revision: https://phab.enlightenment.org/D2145
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Summary:
Fix incorrect scroller content region calculation of panel.
It is fixed that the parent of panel content becomes scr_ly if panel is scrollable.
Test Plan:
Test Panel Scrollable in elementary_test.
1. Change panel orient as ELM_PANEL_ORIENT_RIGHT in test_panel.c.
2. Run elementary_test and test Panel Scrollable.
3. You can see the right panel drawer is hidden right after it is shown.
(After applying this patch, this problem will be resolved.)
Reviewers: seoz, woohyun, eunue, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2125
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix
Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2136
Summary:
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
@fix
Test Plan: change edc for supporting focus highlight in edc, and set focus on unrealized items.
Reviewers: raster, seoz, jaehwan
Differential Revision: https://phab.enlightenment.org/D2128
Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.
Reviewers: seoz, woohyun, Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2102
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2116
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.
T2082
Test Plan: You can check the effect of this patch in "elementary_test popup".
Reviewers: seoz, Hermet
Subscribers: stefan_schmidt, J5lx, seoz
Differential Revision: https://phab.enlightenment.org/D2121
Summary:
This restack callback added for support previous tree [parent - notify - popup].
The popup has been redesigned to have correct tree [parent -popup - notify].
So the restack callback does not need anymore.
Test Plan:
1. Run elementary_test
2. Execute popup sample.
3. Activate popup which has restack feature.
4. Check the result.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2127
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.
Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)
Reviewers: raster, seoz, Hermet
Subscribers: m.jagiello
Projects: #elementary
Maniphest Tasks: T2042
Differential Revision: https://phab.enlightenment.org/D2045
the original code for handling label positioning was not robust enough to handle
cases such as ibar scrolling or gadget moving. this greatly simplifies the code
as well as handling all cases and providing small animations for moving the label
when necessary
This fixes partly T1828
Summary: Use the feature provided by ibar.
Reviewers: raster, zmike
Subscribers: zmike
Differential Revision: https://phab.enlightenment.org/D1797
Summary:
Add extra check to prevent crashing when user clicks configuration
test from elementary_test window
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D2086
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Item width max size set as 130 in edc before, i thinks that value doen't have any meaning,
so i changed the item max width size to follow container width size.
For modification, item size calc, box resize logic changed.
Test Plan:
1. Run elementary_test
2. Execute multibuttonentry sample.
3. Input some text for make item.
Reviewers: Hermet, seoz, woohyun, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1970
Restacking not selected item should be selected after it is done.
@fix
Test Plan:
1. run in console
> elementary_test "Genlist Reorder Mode"
2. Switch to reorder mode
3. Select Item #6
4. Try to restack Item #4
(not selecting it, but holding mouse on it and moving down)
5. See that Item #4 and Item #6 is not selected
Reviewers: cedric, Hermet, raster, seoz
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1931