Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
The sub-ecore_evas is automatically deleted by ecore_evas_object_image
object when it is deleted, so we were double-freeing it.
By: Brian Wang <brian.wang.0721@gmail.com>
SVN revision: 50265
This bug of including Ecore, Evas and Ecore_Evas from Ethumb.h was
actually expoed from recent evas-0/Evas.h change, as these were not
required in the public file, I'm removing them and just letting eina
as it is used to typedef Eina_Bool and function attributes.
SVN revision: 50160
* those write to stderr were legacy from development, some of them
were even wrongly accessing out-of-buffer memory;
* some platforms cannot access non-aligned memory, like integers that
are not aligned to sizeof(int) and do on. Change the generated
message using memcpy to aligned memory before using them. Add
comment to explain that;
SVN revision: 50135
as we are on the modules context not the array.
All the referenced projects are changed too. Remember that the list_free()
already calls the unload() on each module so no need to call list_unload()
SVN revision: 44978
* paths based on $prefix are not set at configure time. The correct
way is to use them in Makefile.am.
* $themesdir and $sysconfdir does not seem to be used
SVN revision: 43567
Ethumb wasn't matching files to plugins if the extension were not
composed of all lowercase chars. This patch makes the ethumb match
case-insensitive.
Patch by: João Paulo Rechi Vita
SVN revision: 43502
parameter but an int32 is sent instead.
Patch by: João Paulo Rechi Vita <jprvita@profusion.mobi>
--This lina, and those below, will be ignored--
M ethumb/src/bin/ethumbd.c
SVN revision: 43160
people were not noticing it as they were using 64 bits machines... but
with 32 bits just 4 bytes were copied and 3 were missing :-P
SVN revision: 42549
Have all source to include config.h conditionally (HAVE_CONFIG_H),
define EINA_LOG_LEVEL_MAXIMUM, minor changes to configure.ac to make
it conform with the rest of efl.
SVN revision: 42544
Some methods are missing and the in-process thumbnail needs to be
done, the documentation is almost the same as the client, so I really
appreciate someone else do it :-)
SVN revision: 42541
* Callbacks were named to help Vala bindings.
* All callbacks get 'void *data' as first argument, always.
* All async methods get free_data parameters and call them also on disconnect()
* queue_remove() renamed to generate_cancel() to be more clear.
* queue_clear() renamed tp generate_cancel_call() to be more clear.
SVN revision: 42445
remove debug_level options as it is better handled by EINA_LOG_LEVELS
and EINA_LOG_LEVEL variables, for example:
EINA_LOG_LEVEL=3 EINA_LOG_LEVELS=ethumb:4,ethumb_client=1
will show debug for ethumb (lib), just errors (no warnings) for
ethumb_client library and everything else shows "info".
SVN revision: 42261
-Q, -V, -D: change debug levels, always forget about EINA_ERROR_LEVEL :-P
print message with status, if it failed, was generated or already exists.
SVN revision: 41374
These thumbnails are generated using an edje template. Each thumbnail is
an edje file, that has a group called "movie/thumb"
The thumbnail can be animated by receiving a signal "animate" or "animate_loop"
(the last one being a loop animation that calls itself when finished), and
the animate_loop program can be stopped by receiving a signal "animate_stop".
The transition time is set based on the time of the animation (that is set
by the call ethumb_video_time_set()).
SVN revision: 41322
- Now it's possible to access the ecore_evas used to generate the
thumbnails (and use functions like ecore_evas_buffer_pixels_get() ont it);
- Functions to calculate aspect and fill area using the aspect ratio as
argument are also provided.
SVN revision: 41288
The dbus api has a "flags" parameter that is now unused but may be in
future, it was missing and dbus was giving method mismatch.
I forgot to commit this but changed Ethumb_Client, then Viktor "fixed"
it by reverting such change. Now going back to my code and adding "0"
as flag.
SVN revision: 40968
we still guess it was up and try to get its name, if not possible then
try to start it and then get is name.
another way to do it would be to always request start and just then
get its name and just then start to listen to NameOwnerChanged. But
the current way is good enough and should save some roundtrips for
good cases (server is up).
SVN revision: 40955
ethumbd is a server waiting for requests of thumbnails via dbus. A client
library is also provided, avoiding dbus burocracy (and with an API similar
to ethumb).
SVN revision: 40899