and removed unnecessary local variable.
- Do not need to call the same function with same parameter many times.
Use local variable for them.
- Remove unnecessary local variable if it is not needed.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.
Reviewers: Hermet, seoz
CC: Jaehyun_Cho, seoz, raster
Differential Revision: https://phab.enlightenment.org/D265
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
1. Idle enterer is deleted when ECORE_CALLBACK_CANCEL is returned.
So calling the idle enterer callback directly from the code needs more considerations.
2. Used better variable names and added more comment.
3. Diskselector needs much more love.
SVN revision: 83298
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
Subject: [E-devel] [patch][elementary] diskselector - blank item
should be added on round disabled mode
blank item should be added on the round disabled mode.
current diskselector adds blank item even though the round mode is enabled.
so please check the patch and give feedback. thanks.
SVN revision: 77990
Subject: [E-devel] [patch][elementary] diskselector - bug fix
diskselector has two bugs.
1. on round enable mode
elm_diskselector_item_append(); does not call elm_box_pack_*() for
over_items and under_items which are added when the display item is
bigger
than 3.
because over_items and under_items is not added, the diskselector shows
just 4 items + half item(NOT 5 items), in case of display item number
is 5
- elm_diskselector_display_item_num(obj, 5); -.
this bug could be found only if u use as following sequence.
a. elm_diskselector_round_enabled_set(obj, EINA_TRUE);
b. elm_diskselector_item_append();
2. on the round disable mode + bigger than 3 display item
even though display item is bigger than 3 on the round disable
mode, only
two blank items are added - left_blank, right_blank.
because of this, the first item could not be selected. means.. the first
item cannot be located in the middle of diskselector.
if u scroll the diskselector to the left-most, then the second item is
selected as below.
[blank] [ 1st ] [ 2nd ] [ 3rd ] [ 4th ]
so if the display item is bigger than 3, more blank items would be
necessary.
include lines to resolve above 1st bug, the patch would resolve
this issue
also.
SVN revision: 77740
Subject: [E-devel] [patch][elementary] diskselector - checking middle
item
the diskselector object x-coordinate would not be 0.
but the _scroll_animate_stop_cb() calculates selected item with assumption
that the diskselector object x-coordinate is 0.
so different item which is not in middle of diskselector is selected.
SVN revision: 77182
Subject: [E-devel] [Patch] [Elementary] Support for circular effect in
elm_diskselector, in case scroller's bounce effect is disabled.
Can someone please review the attached patch created by Sumanth.
[Issue Details] :
elm_diskselector_round_enable_set() API is not working, if
elm_scroller's bounce effect is disabled.
[Root cause] :
For diskselector circular effect, the boundary checking is done based
on scroller's geometry.
If bouncing effect is disabled in elm_scroller, its geometry can lie
between 0 on left and CHILD_SIZE on right but it can never go beyond
that point.
Unless the scroller's geometry goes beyond its child (here, elm_box)
size, diskselector cann't trigger the circular effect.
[Change Description] :
For diskselector items circular effect, the boundary checking is
performed at the left/right edges of its child, elm_box.
Once the scroller reaches to the left/right edge of box or goes beyond
that point, circular effect will be triggered.
SVN revision: 76606
Subject: [E-devel] [patch][elementary] diskselector - text align issue
by default diskselector item has space for icon even though the item does
not have icon.
so in some cases, the text is not located in the center of item and
diskselector.
the attachment would resolve this issue. please look into it and give
feedback. thanks.
SVN revision: 76507
That needs to be done in other way.
Revert "From: Kim Shinwoo <kimcinoo.efl@gmail.com>"
This reverts commit 9d6e461366a0eb208d75b0a1fb5c0c822b761c71.
SVN revision: 75836
Daniel Juyung Seo
Jihoon Kim
Daniel Juyung Seo
Carsten Haitzler
Tom Hacohen
Jaehyun Cho
Cedric Bail
ChunEon Park
Shinwoo Kim
Daniel Juyung Seo
Daniel Zaoui
Shinwoo Kim
Yakov Goldberg
PRINCE KUMAR DUBEY