From d6effc20435aea3b481149b4821b86843bef03f6 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 14 Jun 2012 12:21:58 +0000 Subject: [PATCH] maybe I'm wrong, but this looks like a guaranteed null deref SVN revision: 72126 --- src/bin/e_border.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/bin/e_border.c b/src/bin/e_border.c index 7599eea4c..7314a9690 100644 --- a/src/bin/e_border.c +++ b/src/bin/e_border.c @@ -5194,21 +5194,10 @@ _e_border_cb_window_stack_request(void *data __UNUSED__, if (e_stolen_win_get(e->win)) return ECORE_CALLBACK_PASS_ON; if (!e_util_container_window_find(e->win)) { - Eina_List *l; - E_Border *tmp; - if (e->detail == ECORE_X_WINDOW_STACK_ABOVE) - { - EINA_LIST_FOREACH(bd->client.e.state.video_child, l, tmp) - if (tmp) ecore_x_window_raise(tmp->win); - ecore_x_window_raise(e->win); - } + ecore_x_window_raise(e->win); else if (e->detail == ECORE_X_WINDOW_STACK_BELOW) - { - EINA_LIST_FOREACH(bd->client.e.state.video_child, l, tmp) - if (tmp) ecore_x_window_lower(tmp->win); - ecore_x_window_lower(e->win); - } + ecore_x_window_lower(e->win); } return ECORE_CALLBACK_PASS_ON; }