Boris Faure
0eb223f1b8
termptyesc: approximate true color. Ref T746
2018-03-11 19:51:11 +01:00
Carsten Haitzler
0fcd99cda5
do a thaw eval after thaw to ensure we dont miss any events
...
freeze stops events (in/out/down/up and so on, not del etc.) and thaw
does the oppostie. the thing is thawing to 0 freeze level never
re-evaluated everything. it was an optimization and simpler. so to
re-evaluate state and not lose thngs like in and out evets you do have
to do a thaw eval after thaw that will evaluate that state and produce
in and out events if you thaw back to 0. i don't know if this
fixes T4194 or not, but it does dot an i and cross a t.
2018-03-11 18:30:06 +09:00
Boris Faure
6bf2116206
shift-selection: reduce timeout to 15s. Closes T2254
2018-03-10 21:10:34 +01:00
Boris Faure
2d5bc93780
win: handle title popup like the options popups. Closes T6727
2018-03-10 19:40:13 +01:00
Boris Faure
71d9bc2f68
win: do not force focus when on options. Closes T4769
2018-03-10 17:22:52 +01:00
Boris Faure
1a5384b19e
options: default is the behaviour tab. Closes T2130
2018-03-10 17:13:10 +01:00
Boris Faure
9aeae783b5
options_behavior: expect EFL > 1.8
2018-03-10 16:14:40 +01:00
Carsten Haitzler
1ea0818f2b
close terminal button - pass ctx ptr to callback so it doesnt seg
2018-02-26 15:42:16 +09:00
Boris Faure
67fb28a67c
solarized: set faint/dim colors for black
...
It was previously invisible
2018-02-14 22:32:50 +01:00
Carsten Haitzler
a1d9dba1d0
terminology efl version bump 1.8 to 1.20
...
efl 1.8 is ancient by now (december 2013 ... like over 4 years ago).
time to bump to 1.20, so any future releases of terminology will need
a bump in efl version too whicn IMHO is sensible.
2018-02-13 15:12:18 +09:00
Boris Faure
ce11630457
win: do not show win too early
2018-02-12 22:40:50 +01:00
Boris Faure
d52afe1a73
win: shot in the dark about the positioning issue
...
If it fixes the issue, I'm clueless!
2018-02-12 22:23:05 +01:00
Boris Faure
802ed4b2eb
win: removes that blue focus animation
2018-02-12 22:09:34 +01:00
Boris Faure
3aac7976b7
termio: fix key bindings for scrolling
2018-02-12 22:03:02 +01:00
Boris Faure
efb6df10b7
win: fix focus after editing title
2018-02-11 12:14:39 +01:00
Boris Faure
653173bd85
Merge branch 'grouped-input'
2018-02-11 11:56:13 +01:00
Boris Faure
19cca3e2f2
group input: handle only_visible or all terms
2018-02-11 11:48:06 +01:00
Boris Faure
26b19dc31d
win: remove useless comments
2018-02-10 17:28:58 +01:00
Boris Faure
4f261e922e
imf: handle cursor move
2018-02-09 23:18:03 +01:00
Boris Faure
c31c1cbd9b
termio: focus_in to show blinking cursor
2018-02-09 22:02:19 +01:00
Boris Faure
55b4eeb3a2
win: focus the termio objects, at least to have mouse work
2018-02-08 22:38:55 +01:00
Boris Faure
ddb8e8160d
termio: really constify preedit_str
2018-02-08 22:38:02 +01:00
Boris Faure
7cb67a2bce
win: get out of grouped-input
2018-02-08 18:40:27 +01:00
Boris Faure
34f19bf4dd
win: constify term_preedit_str_get()
2018-02-08 18:40:06 +01:00
Boris Faure
d7432a52d6
move input handling to win.c
2018-02-05 00:07:47 +01:00
Boris Faure
e5c580aa26
win: getting events through conform is more reliable
2018-01-30 23:37:00 +01:00
Boris Faure
b75d5b7e9c
win: do not focus termio
2018-01-30 23:36:16 +01:00
Boris Faure
93106d1148
win: set flag on_options when settings/about/controls are up
2018-01-30 23:31:26 +01:00
Boris Faure
4f87249016
we're in 2018
2018-01-17 20:34:35 +01:00
Boris Faure
527859f4c4
options_colors: fix selected item showing on multiple rows
...
makes the selector barely more usable…
2018-01-15 23:49:03 +01:00
Boris Faure
8c09ee5c88
options_colors: compute pre-multiplied colors
2018-01-15 23:28:18 +01:00
Boris Faure
f33e898e29
options_colors: clean up a bit and have a global reset button
2018-01-15 22:51:16 +01:00
Boris Faure
820a5440fe
controls: use both "bg" and "base" evas objects
2018-01-15 22:45:32 +01:00
Boris Faure
a66225dc87
options_colors: be able to have multiple instances
2018-01-14 12:52:46 +01:00
Boris Faure
64502fa8f3
options_theme: be able to have multiple instances
2018-01-13 19:25:31 +01:00
Boris Faure
8b26cd4149
options_background: go to image grid when selecting user/system in hoversel
2018-01-13 18:52:40 +01:00
Boris Faure
85ba744771
options_font: be able to have multiple instances
2018-01-12 23:27:19 +01:00
Boris Faure
32209a6dfd
options_video: be able to have multiple instances
2018-01-10 23:28:50 +01:00
Boris Faure
22e3731c96
options_behavior: be able to have multiple instances
2018-01-10 23:26:40 +01:00
Boris Faure
1745e77c93
options_background: fix segfault due to flip destroying hoversel
2018-01-09 23:39:02 +01:00
Boris Faure
c7fe3ca964
fix coding style wrt _Ctx types
2018-01-09 23:21:48 +01:00
Boris Faure
69e3176f4e
options_background: rewrite to have multiple widgets
2018-01-08 23:17:02 +01:00
Boris Faure
29db075729
options_keys: rewrite it to have multiple widgets at the same time
2018-01-07 23:11:18 +01:00
Boris Faure
08b5c20a27
controls: keep ctx when on about/options
2018-01-05 23:42:14 +01:00
Boris Faure
fd150de222
options: simplify code and no more globals
2018-01-05 00:27:25 +01:00
Boris Faure
983dadeba4
about: simplify code and no more globals
2018-01-05 00:27:25 +01:00
Boris Faure
eaaae01745
controls: less globals, controls per window
2018-01-05 00:27:25 +01:00
Boris Faure
080ff8e261
controls: simplify code
2018-01-05 00:27:25 +01:00
Boris Faure
d20e32c26f
options: rename options_active_get() to options_is_active()
2018-01-05 00:27:25 +01:00
Boris Faure
d7bc232806
win: remove useless callbacks
2018-01-05 00:27:25 +01:00
Boris Faure
561e1b0941
splits: fix focus issue when splitting a split
2018-01-05 00:27:25 +01:00
Boris Faure
39fb41024b
early work on multi-input support
2018-01-05 00:27:25 +01:00
Carsten Haitzler
878def120e
move private.h down after system headers... to avoid conflict
2017-12-19 11:01:09 +09:00
Carsten Haitzler
3a14751b34
tytools - remove eina.h include from ty tools where really not needed
2017-12-19 11:01:09 +09:00
Carsten Haitzler
700beb9bd6
tysend - dont check if in terminology as it should also work remotely
...
well it's not a brilliant check... user beware. tysend will only work
if there is no screen/tmux in the way and your end point terminal is
terminology (end point being the GUI terminal emulator you are using).
2017-12-18 19:54:05 +09:00
Carsten Haitzler
8cfa269b54
tysend - optimize sending - pretty much double the speed
...
yes. it's still inefficient because we transfer in ascii-ized nibbles
(4 bits) within a utf8 stream that becoems a 32bit per char unicode
buffer then back to utf8 before being "parsed" as a command etc. etc.
... it's not brilliant for transferring binary data. it's horrible
actually. but at least i've dropped overhead for some of the large
escape handling code.
this increases buffer size to 32k per block sent, and have the
terminal escape/buffer handling track if a zero byte exists in the
buffer at all to avoid hunting for one if none is there, making
terminology escape handling much more efficient for large escapes and
buffers.
2017-12-18 15:32:02 +09:00
Carsten Haitzler
8bb7a473ae
tysend status - fix focus after close/cancel
2017-12-18 15:31:45 +09:00
Carsten Haitzler
15e3c87390
tysend - i was only testing ascii files. binary doesnt trasnfer well...
...
so move to 4 bit nibbles encoded as ascii. inefficient but works
reliably.
2017-12-18 00:51:52 +09:00
Carsten Haitzler
125d475068
add tysend cmdline and support in escapes for sending single files
...
this allows you to send a file via escapes to terminology which will
pop up a file save dialog and ask what to save it as and where (based
on the original name). terminology will show a progress bar too. this
is not useful locally but remotely (e.g. you ssh'd into another
machine) it's a VERY handy way of fetching a file from the remote
machine to the local machine with a display just with tysend FILE. you
can send multiple in a sequence with tysend FILE1 FILE2 FILE3 ... ...
and terminology will ask for a location and filename per file you send
(just hit cancel if you don't want to do it).
note - it needs new theme features to work. it'll fail without them.
@feature
2017-12-17 23:41:26 +09:00
Amitesh Singh
31285fb5dc
title: set focus to title entry
...
Focus was not coming to entry on 'set title' popup.
Set focus to a popup subobject after showing popup.
@fix
2017-12-05 13:44:00 +09:00
Boris Faure
35cb66aa2b
handle -Wimplicit-fallthrough=
2017-11-12 00:30:25 +01:00
Boris Faure
59feab991b
use 'ninja install' instead of 'make install' in error message
2017-11-12 00:14:00 +01:00
Boris Faure
c51d0095f9
get rid of automake
2017-11-12 00:09:06 +01:00
Boris Faure
d2d03992eb
theme previews: set shine according to config
2017-11-11 23:16:15 +01:00
Boris Faure
7d94ebaa1e
options: have Colors before Video
2017-11-11 23:12:17 +01:00
Boris Faure
c1850f73b0
options: move shine slider to Background
2017-11-11 23:10:55 +01:00
Boris Faure
adb818b697
s/wallpaper/background/
2017-11-11 22:24:35 +01:00
Boris Faure
7f8396d55b
settings: move translucent to wallpaper
2017-11-11 22:19:08 +01:00
Boris Faure
bb968b968e
be able to configure shine level on the default theme
...
Was asked about it too many times, so here it is :)
2017-11-11 20:12:56 +01:00
Boris Faure
c388bbf7bb
Merge branch 'terminology-1.1'
2017-10-10 21:15:05 +02:00
Boris Faure
57fea056c1
fix -e option. Closes T6175
2017-10-10 21:14:07 +02:00
Boris Faure
b22a64043f
Merge remote-tracking branch 'origin/devs/iscaro/meson'
2017-10-03 22:01:39 +02:00
Boris Faure
83e60e807f
Merge branch 'terminology-1.1'
2017-09-20 20:11:35 +02:00
Boris Faure
82c163a3c9
gravatar: get images through https
2017-09-20 20:10:52 +02:00
Boris Faure
854f0a67f2
Merge branch 'terminology-1.1'
2017-09-18 22:02:56 +02:00
Boris Faure
180799d2c5
support the REP escape code. Closes T6042
2017-09-18 22:01:42 +02:00
Boris Faure
1c0710ac51
Merge branch 'terminology-1.1'
2017-09-09 00:08:47 +02:00
Boris Faure
6100f8f4e3
harden the code around manipulation of cursor_state
2017-09-08 23:06:19 +02:00
Boris Faure
13da2313d2
Merge branch 'terminology-1.1'
2017-08-28 21:42:17 +02:00
Boris Faure
496a5f178e
have only one concept of title. Ref T5704
2017-08-28 21:41:21 +02:00
Boris Faure
38da9b2ded
correctly handle -T option. Ref T5704
2017-08-28 21:41:10 +02:00
Boris Faure
ceede027f1
Merge branch 'terminology-1.1'
2017-08-26 19:29:26 +02:00
Boris Faure
61ce65c700
force user title one window when set through -T option. Closes T5704
2017-08-26 19:27:39 +02:00
Boris Faure
6bb1552c84
empty string resets tab title
2017-08-26 19:27:14 +02:00
Boris Faure
669533fef5
do not add spurious whitespace when running a command (-e option)
2017-08-26 19:26:29 +02:00
Boris Faure
acbf3387fa
fix selections in the backlog. Closes T5743
...
In the backlog, every cell but the last one has the autowrapped flag set.
_termpty_cellrow_from_beacon_get() now returns a length in the
"screen space".
2017-08-26 18:51:22 +02:00
Boris Faure
9abf652003
Merge branch 'terminology-1.1'
2017-08-22 22:11:09 +02:00
Boris Faure
0478a36799
termptyops.c: fix scrolling wrt bottom margin
...
Thanks to @ncim for the report
2017-08-22 22:08:11 +02:00
Boris Faure
7c358c3592
termptyesc: correctly handle going to start of line when there is a left margin
2017-08-22 20:51:20 +02:00
Boris Faure
6315ed2949
termpty: remove termstate.had_cr since it's unused
2017-08-21 23:46:28 +02:00
Boris Faure
461848813b
Merge branch 'terminology-1.1'
2017-08-21 23:33:40 +02:00
Boris Faure
2343efd6a1
termptyesc: clearing the screen (from ED2) should not reset bottom margin
...
Thanks to @ncim for the report.
2017-08-21 23:19:41 +02:00
Boris Faure
50c14419e0
we're in 2017!
2017-08-20 19:45:21 +02:00
Boris Faure
69fc67aa8b
fix compilation on old efl
2017-08-16 21:42:23 +02:00
Carsten Haitzler
18c870d130
add fallthrough tags to have fewer warnings
2017-08-04 10:27:24 +09:00
Carsten Haitzler
d80e60f25c
fix buffer size - was 1 byte too short on stack
...
7 not 6 bytes. include nul byte.
2017-08-02 18:21:08 +09:00
Boris Faure
3a28d99649
termpty: fix inserting blank chars. Closes T5802
2017-07-27 23:27:23 +02:00
Boris Faure
bbb7272910
teamwork: remove the feature since it's no longer supported in elm
2017-07-23 17:41:20 +02:00
Boris Faure
0844d86892
sizing: use 1px step when having visible tabs.
...
Closes T5421
2017-07-23 17:33:24 +02:00
Guilherme Iscaro
1b4ab6036c
Add support for the Meson build system.
2017-07-20 14:17:33 -03:00
Boris Faure
e7b3265662
font: update all terms to this window when changing font (size)
...
Closes T5012
Closes T5445
2017-07-14 22:10:54 +02:00
Boris Faure
70c4ba6fdb
tycommon: add "directly" to "not running in terminology"
2017-07-14 11:53:33 +02:00
Boris Faure
b35c7cd539
termptyesc: add missing break. CID1377552
2017-07-11 22:01:31 +02:00
Boris Faure
fd4ef6ec1f
win: add binding (Alt+Up/Down/Left/Right) to move around panes
2017-07-11 00:04:31 +02:00
Boris Faure
6f1a2dd452
constify
2017-07-06 21:37:56 +02:00
Boris Faure
3cafc4272d
feature: click-alt tries to handle wrapped CLI. Closes T5537
2017-07-06 20:17:47 +02:00
Boris Faure
de3890dad3
feature: move cursor to position on click+alt. Closes T5537
2017-06-29 23:45:05 +02:00
Boris Faure
b0226726f8
termpty: correctly handle DECFRA wrt SGR 0
2017-06-26 23:36:23 +02:00
Boris Faure
7ac685b68c
termpty: DECERA only changes codepoints
2017-06-26 21:58:59 +02:00
Boris Faure
956f1eaa13
termptyesc: restrict right/bottom rectangle coordinates
2017-06-07 20:40:17 +02:00
Boris Faure
e314dd2f29
termptyops: fix clearing cells on scroll
...
cells has already the offset taken into account
2017-06-06 23:49:24 +02:00
Boris Faure
400b675fc9
termptyesc: restrict CUP/HVP to right/bottom margins
2017-06-06 23:00:22 +02:00
Boris Faure
64d7150252
fix stupid segfault
2017-06-06 00:19:48 +02:00
Boris Faure
cc5fcac03d
termptyesc: fix handling of DECSLRM. Ref T5533
2017-06-05 23:53:07 +02:00
Boris Faure
bbfa60120e
termpty: handle DECERA
2017-06-05 21:04:29 +02:00
Boris Faure
9f72ea3a9d
termptyesc: handle DECFRA
2017-06-05 20:47:41 +02:00
Boris Faure
7ea4b65c8d
termptyops: handle right/left margins. Ref T5533
2017-06-05 17:43:23 +02:00
Boris Faure
e117ff9153
termptyesc: correctly handle cursor wrt right/left margins
2017-06-05 16:49:36 +02:00
Boris Faure
7d497c08c6
termptyesc: extract handling CUP/HVP to one function
2017-06-05 01:04:24 +02:00
Boris Faure
a168dc6645
termio: ev was unused
2017-06-05 01:02:41 +02:00
Jean Guyomarc'h
97469490fb
termio: fix mouse button event tracking in vim
...
Commit 9e0b63403f
caused mouse events not
to be processed correctly by vim. Resizing subwindows with the mouse was
fully broken.
Without the mouse button information, the button event tracking could
not be forwarded to the terminal.
2017-06-04 23:56:38 +02:00
Jean Guyomarc'h
ede4196eae
termptyesc: fix invalid clamping on CSI X
...
Fixes a regression introduced by commit bd6c81e
, which broke the ncurses
rendering of the Kernel menuconfig, making it impossible to be used.
2017-06-04 18:35:46 +02:00
Jean Guyomarc'h
20cbab21fc
termptyesc: improve const-correctness of data
2017-06-04 18:35:22 +02:00
Boris Faure
10cdcdb41c
private.h: include libintl.h to have gettext defined
...
Patch by Vincent Torri
2017-06-04 11:29:59 +02:00
Boris Faure
c2d731aced
termptyesc: cleanup handling of DECSTBM
2017-06-04 00:33:32 +02:00
Boris Faure
7ab925dc76
termpty: very early support of Right/Left margins
2017-06-03 23:17:33 +02:00
Boris Faure
91ce6e8960
termptyesc: correctly handle missing arguments in CUP/HVP
2017-06-01 23:33:58 +02:00
Boris Faure
e0f6867a88
termptyesc: _csi_arg_get() now correctly handles missing arguments
...
Only affects when multiple ones were expected
2017-06-01 23:29:55 +02:00
Boris Faure
dbc75a0cc0
termptyesc: only do IL/DL when inside margins
2017-06-01 22:52:16 +02:00
Boris Faure
339b72174c
termptyesc: CUP/HVP are impacted by DECOM
2017-06-01 22:51:34 +02:00
Boris Faure
6c750c660c
termpty: on reset, no longer restrict cursor
2017-06-01 21:34:01 +02:00
Boris Faure
8168b019c9
termptyesc: improve debug
2017-06-01 21:29:07 +02:00
Boris Faure
816f60369f
termptyesc: correctly handle DECOM
...
also fix regions with only one argument
2017-05-31 00:39:02 +02:00
Boris Faure
6ce96da8c4
s/scroll_y1/top_margin/, s/scroll_y2/bottom_margin/
2017-05-29 23:26:32 +02:00
Boris Faure
fd05f3cab5
tyfuzz: read escape sequence from file given as argument in available
2017-05-29 23:12:19 +02:00
Boris Faure
a4a26de7c3
termptyesc: fix parsing size on xterm 50 command
2017-05-28 23:32:37 +02:00
Boris Faure
72eaf53e26
options: use ecore_exe_pipe_run() instead of fork+exec
...
Patch provided by Vincent Torri
2017-05-28 23:30:05 +02:00
Boris Faure
7b5a9b74bc
termptyesc: use macro to restrict field value
2017-05-17 23:40:19 +02:00
Boris Faure
490a065fb1
termptyesc: _csi_arg_get() could be called with nothing to read
...
Could be the case when an error was already found while decoding the
stream
2017-05-17 23:38:28 +02:00
Boris Faure
0517be32f4
termptyesc: no logging when fuzzing
2017-05-17 23:33:06 +02:00
Boris Faure
387cafa463
tyfuzz needs termpty_resize_tabs()
2017-05-17 22:35:01 +02:00
Boris Faure
6821c94a1c
fuzz: disable logs when fuzzing
2017-05-17 22:34:51 +02:00
Boris Faure
ce490ededc
termptyesc: fix issue with tmux introduced by previous commit
2017-05-17 21:49:52 +02:00
Boris Faure
63d65ed4bb
termptyesc: restrict values on scrolling regions
2017-05-16 22:48:18 +02:00
Boris Faure
17e5e1be55
termpyesc: only compute logging content if it's going to be printed
2017-05-15 23:54:25 +02:00
Boris Faure
bd6c81ed39
termptyesc: restrict CSI values to avoid denial of service
2017-05-15 22:34:01 +02:00
Boris Faure
2b47545fac
termptyesc: ensure colors are valid
2017-05-15 21:56:54 +02:00
Boris Faure
c3767594d1
fix compilation with fuzzing enabled
2017-05-11 23:46:01 +02:00
Sanjeev BA
8f9b49a110
Add option to set current window size as default.
...
Summary: Without this the user needs to "find out" the current width and height by pointing and clicking at the edge of the window and then manually set the spinner values.
Test Plan:
Run terminology.
Get to options->behaviour menu. Resize the window.
Reviewers: jpeg, cedric, raster
Differential Revision: https://phab.enlightenment.org/D4823
2017-04-26 16:15:33 +09:00
Boris Faure
1fa0fd7148
config: change Disable focus-out visuals to be more positive :)
2017-03-13 20:44:53 +01:00
Mike Blumenkrantz
9309941875
add behavior option to disable focus-in/out animations and visuals
...
this is useful for CI
2017-03-13 19:34:54 +01:00
Boris Faure
566dc187d6
termio: reset size when size looks boggus.
...
Patch by netstar
2017-03-05 16:40:10 +01:00
Boris Faure
f4813a229d
termio: remove dead code. CID1371738
2017-03-05 16:36:35 +01:00
Boris Faure
9e0b63403f
may fix mouse motion reporting. T4874
2017-03-04 17:37:03 +01:00
Boris Faure
e188244c72
pty: fallback to ~ or / when creating new term if current dir is not available
...
Closes T5186
2017-02-17 21:57:57 +01:00
Boris Faure
74c1ceffd8
win: double click on tab title to change it. Closes T3143
2017-02-17 21:47:57 +01:00
Boris Faure
6c5c7d486c
controls: clean up code
2017-02-08 21:34:46 +01:00
Carsten Haitzler
71f1fdc66c
terminology tabs resize - fix access of invalid memory beyond bounds
...
we memcpy'd the currenty size over, so if prev size was smaller - this
was wrong and valgrind threw a complaint. also the rounding seems
utterly bizarre. it looks like it was meant to round up to the nearest
"lot of 8 tabs" so actually do that... which makes is easy to pass in
old width nicely now to fix the problem.
@fix
2017-01-31 13:03:36 +09:00
Boris Faure
afe4b928bc
improve link detection when stored in xml
...
example:
<url>https://terminolo.gy/ </url>
2016-12-25 18:18:16 +01:00
Boris Faure
41c4479dc5
termpty: verify that $SHELL is valid before using it. CID1366816
2016-12-24 18:40:18 +01:00
Boris Faure
99f55b7bbc
termptyesc: support DECSED3 to erase the backlog. Closes T3713
2016-12-20 22:43:37 +01:00
Boris Faure
e5f3676e32
termio: fix getting selection of known link. CID1367486
2016-12-20 20:20:34 +01:00
Boris Faure
240a4a02d3
termpty: fix potential NULL dereference. CID1367485
2016-12-19 23:38:32 +01:00
Boris Faure
b9d5a55aa4
termptyesc: correctly handle tab forward. Closes T4992
2016-12-18 19:17:42 +01:00
Boris Faure
f3dd6f62fb
termpty: Tab markers are the same for each line. Ref 4992
2016-12-18 18:48:03 +01:00
Boris Faure
836baf5d63
private: add macros ROUND_UP and DIV_ROUND_UP
2016-12-18 18:46:41 +01:00
Boris Faure
82d9ead6f2
termptyesc: handle correctly Character Tabulation Set (HTS). Ref T4992
2016-12-15 23:11:22 +01:00
Boris Faure
5af5ec084e
termio: do nothing special when extracting text and .tab is set
2016-12-15 23:11:22 +01:00
Boris Faure
7c720058a1
termptyesc: add some debug
2016-12-15 23:11:22 +01:00
Boris Faure
fae0d7ccee
termptyesc: handle correctly Cursor Back Tab. Ref T4992
2016-12-15 23:11:22 +01:00
Carsten Haitzler
60d1c6d05c
term pty fd - properly shut down without a 100% cpu hang
...
i've noticed that the exe cb tries to drain the pty fd but reads
return -1 with EAGAIN so terminology just spins forever in cpu trying
to drain a buffer that does not drain, so make a special case on exe
exit - drain until there just is nothing else to read then give up.
@fix
2016-12-13 11:53:50 +09:00
Boris Faure
45539d433c
termio: small cleanup
2016-12-06 23:49:03 +01:00
Al Poole
8dd7aefcb4
Fix bogus hack and restore cursor position to its right place. On OpenBSD and DragonFly the cursor is being incorrectly placed. Seems there was a Linux workaround too. My guess is this will fix that also.
...
Summary: Should help anyway.
Reviewers: billiob, raster
Differential Revision: https://phab.enlightenment.org/D4465
2016-12-06 23:42:10 +01:00
Boris Faure
273a85af00
termpty: handle BSD special case when the other side of the tty pair has quit
2016-12-06 21:49:15 +01:00
Boris Faure
5770c51d86
termpty: handle read() from tty pair when the other end has died, on some BSD
...
In such a case, read() returns 0 and sets errno to ECHILD…
2016-12-05 23:39:29 +01:00
Boris Faure
7508c8658b
termpty: ensure we're not reading from invalid fd
2016-12-05 22:45:44 +01:00
Boris Faure
9b6bed8033
termpty: fix dead code and remove debugging code. CID1366815
2016-12-05 22:13:54 +01:00
Boris Faure
4b3225bfa9
termpty: make verify_beacon silent by default
2016-12-05 22:13:30 +01:00
Boris Faure
390e4193d0
termpty: fix possible issue when reading and the shell exited
2016-12-05 21:53:15 +01:00
Boris Faure
1f62588e97
termpty: avoid race between exit of the program and reading from it
...
Also ensure we read what was already in the pipe before we ever polled it.
Closes T4925
2016-12-04 23:24:28 +01:00
Boris Faure
32dbc65c6d
env: unset COLUMNS, LINES, TERMCAP
2016-12-04 23:21:58 +01:00
Boris Faure
86f27f0474
termpty: remove useless code
2016-12-04 23:17:56 +01:00
Boris Faure
d5f4811b2d
improve error message
2016-12-04 18:05:43 +01:00
Boris Faure
51fe6b3428
fix getting lines with the beacon
...
add quite some testing that is disabled by default, used to ensure that
the beacon is always valid
2016-11-30 23:25:33 +01:00
Boris Faure
6cc0abd787
termpty: skip combining chars unless it can be used as strikethrough
2016-11-26 18:42:26 +01:00
Marcel Hollerbach
786dd890cc
termio: dont show full/relative for emails or protocols
...
if there is a link like bu5hm4n@efl.so or http://enlightenment.org/ , then
there is no need to show relative or absolut coping in the ctxpopup,
just copy is enought.
2016-11-20 20:51:21 +01:00
Boris Faure
c47b0c39d5
scrolling: fix issues with the beacon
...
Add a few comments on how it works
2016-11-20 18:23:56 +01:00
Boris Faure
5b34e2ba67
mouse wheel on tab counter: fix navigation
...
Do not register the same callback twice.
Invert action on mouse-wheel. During my test, it felt more logical like
that.
Closes T4316
2016-11-19 12:37:41 +01:00
Boris Faure
8658ea9d57
termio: fix leak. CID1365971
2016-11-19 11:02:57 +01:00
Boris Faure
6957ecb642
link detection: rewrite moving around the grid
...
There are difference between the grid and the backlog.
In the backlog, full lines are stored (and thus can be larger than the
width of the terminal).
2016-11-17 23:30:57 +01:00
Marcel Hollerbach
ddbdd96349
add copy link item in rightclick menu
...
Summary:
this will just copy the link content instead of the resolved link.
Makes the link detection feature also useable for ssh/tmux/screen
session.
Test Plan: Hover over a link and rightclick
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D4217
2016-11-17 20:04:50 +01:00
Boris Faure
cea49794a0
termiolink: hopefully fixes segfault. Closes T4896
2016-11-15 22:28:27 +01:00
Boris Faure
55db8930b2
termio: elm_layout_add() expects and elm widget
...
This should remove the noisy message:
ERR<21781>:elementary lib/elementary/elm_widget.c:1130
elm_widget_sub_object_parent_add() You passed a wrong parent parameter
(0x400000089000008a termio). Elementary widget's parent should be an
elementary widget.
2016-11-15 20:29:17 +01:00
Boris Faure
234fe507f4
termiolink: add missing break
2016-11-11 12:38:54 +01:00
Boris Faure
ed406c4579
termiolink: safety on ty being not NULL. CID1365660
2016-11-08 21:17:48 +01:00
Boris Faure
93eb6e6663
termiolink: check return of ty_sb_prepend(). CID1365659
2016-11-08 21:15:42 +01:00
Boris Faure
57c811ce9b
termiolink: handle OOM. Fix CID1365658
2016-11-08 21:13:21 +01:00
Boris Faure
f4263d5098
termptyesc: add missing break (CID1365404)
2016-11-07 11:35:50 +01:00
Boris Faure
a977c2d32e
rewrite link_is_protocol() to handle almost any URI
2016-11-06 20:04:02 +01:00
Boris Faure
0cbaaeec9d
link: rewrite link detection to be more efficient
2016-11-06 20:04:02 +01:00
Boris Faure
c41fc2a56e
sb: add some utilities like prepend, free, steal…
2016-11-06 19:45:05 +01:00
Boris Faure
dab654c278
termio_link_find() is not static, remove its '_' prefix
2016-11-06 13:03:19 +01:00
Boris Faure
d47b350e8c
ty: add sb.{c,h} (was in termio.c)
2016-11-06 11:42:17 +01:00
Boris Faure
fbe747fbfd
include private.h everywhere
...
that way, terminology_config.h is included if present
2016-10-18 20:21:50 +02:00
Boris Faure
566c6d3680
termpty: correctly handle saving cursor + switching to/from altbuf
...
Closes T4718
2016-10-18 00:15:06 +02:00
Boris Faure
65cdb5437e
win: fix comment
2016-10-17 22:19:23 +02:00
Marcel Hollerbach
bdc77fdaee
media: fix previous commit
...
I am sorry for the noice, i added a wrong "!" there
2016-10-09 17:46:32 +02:00
Marcel Hollerbach
b2fe5145d9
media: try to search for a icon theme which provides the given icon
...
This fixes cases where a icon theme is found but, but the given icon
name is not found in the theme. So we are also testing for the
availablility of the icon name.
2016-10-09 17:17:57 +02:00
Jerome Pinot
02ebbba1f5
autotools: add missing tycommon.h in tybg_SOURCES, fix build.
2016-10-08 19:18:58 +09:00
Boris Faure
76f1bf4342
prefix EINA_UNUSED parameters with an underscore
...
and fix related issues
2016-10-05 22:00:22 +02:00
Boris Faure
a2bedb6281
fix shadow variable 'i'
2016-10-05 22:00:02 +02:00
Andy Williams
89d264272d
Update standard icon naming to use standards
...
These are not exact icons but they seem close enough for elm 1.18+
2016-09-27 22:06:40 +01:00
Marcel Hollerbach
b038ed7ff6
ty*: add unified --help / -h options to see a help page
...
This also adds documentation about the -h / --help options in the usages
2016-09-16 13:33:59 +02:00
Boris Faure
36a7166b7a
config: change default to only scroll down on keypress
...
(and not on new change)
2016-08-29 20:31:42 +02:00
Boris Faure
e24196eb24
fix typo in config. Ref T4323
2016-08-10 23:05:04 +02:00
Marcel Hollerbach
dfe08f0ce0
win: free tab_region_base and tab_region_bg
...
otherwise this objects are leaking and taking the events for underlaying
objects.
This fixes T4266
2016-08-08 12:53:51 +02:00
Boris Faure
dfe57a25a7
win: when closing solo container, dissociate it from its parent
...
Ref T3509.
2016-07-31 16:50:13 +02:00
Boris Faure
13c91324fa
win: hide tabcount when no longer tabs
2016-07-31 15:21:42 +02:00
Boris Faure
0e0105e559
make ty* fail nicely when in tmux/screen
2016-07-30 16:31:56 +02:00
Chris Michael
e549612ab2
terminology: Fix issue of icon not showing under wayland
...
Essentially, set the proper icon_name. The icon_name should match the
name of the .desktop file so that elementary can find the fdo icon to
use. This fixes the issue of the window icon not showing up when
running under Weston. With the proper .desktop file name now set, we
no longer need to create and set an elm_win_icon_object.
Fixes T3460
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-07-19 12:56:54 -04:00
Carsten Haitzler
d477e1be7a
open keys - fix compiler warnings
2016-07-11 17:28:51 +09:00
Boris Faure
37e9206330
options_keys: use an edje layout
2016-06-10 03:31:10 +02:00
Boris Faure
8b6036a8f7
miniview: add checks on termio_pty_get(). Closes CID1356203 and CID1356204
2016-06-04 15:44:17 +02:00
Boris Faure
9e80988f5a
keys: add Shift+End to reset scroll. Closes T3582
2016-06-01 19:56:45 +02:00
Boris Faure
7d09373c56
skip 0-width spaces. Closes T3734
2016-05-31 22:03:58 +02:00
Boris Faure
b7817a88b3
keys: add Shift+Home to get to the top of the backlog. Closes T3582
2016-05-31 21:34:44 +02:00
Arnout Engelen
4e5a07e795
Check if the font size really needs to be changed
...
Changing the font size also causes the current selection to be lost, so it's
nice to avoid it when not needed.
2016-05-26 17:57:46 +02:00
Boris Faure
cd0f61dd26
keybindings: fix binding to close focused term
2016-05-22 20:45:13 +02:00
Boris Faure
0c466d767c
Merge remote-tracking branch 'raboof/comment'
2016-05-21 22:39:14 +02:00
Boris Faure
f33aa07b81
termptyesc: fix signedness comparison
2016-05-21 22:38:39 +02:00
Boris Faure
021fbdb055
Merge remote-tracking branch 'raboof/font_size_change'
2016-05-21 22:35:15 +02:00
Boris Faure
bd769a926b
configure.ac: actually look for elm_win_teamwork_show() to know if available
2016-05-21 22:29:38 +02:00
Arnout Engelen
9a501470aa
Fix comment for 't' escape sequence
2016-05-21 15:15:19 +02:00
Arnout Engelen
ef8ee3fbda
Allow font size to be updated via escape sequence
2016-05-21 14:53:17 +02:00
Mike Blumenkrantz
f1e1a6edd8
upgrade to teamwork v2, remove dbus (v1) usage
2016-05-20 15:37:55 -04:00
Boris Faure
15fa7afaa5
key bindings: add shift+left/right to switch tabs
2016-04-12 22:47:49 +02:00
Boris Faure
ce8eda85e1
make terminology still compile with efl-1.8
2016-03-19 16:11:15 +01:00
Boris Faure
d9276909a4
add option to enable bold/italic (on by default)
2016-03-18 20:04:10 +01:00
Boris Faure
a0b7fae2dd
add a reset button to reset the key bindings
2016-03-18 19:08:58 +01:00
Boris Faure
bf4a1f4aba
remove buggy keybinding dedup
2016-03-15 19:42:04 +01:00
Boris Faure
629e604704
termpty_cellrow_get() might return NULL. CID1352819
2016-03-12 17:23:37 +01:00
Boris Faure
8d0e13eff9
ensure CWD is NULL-terminated. CID1352820
2016-03-12 17:11:01 +01:00
Boris Faure
4d8c5dd200
only launch terminology with -d CWD if CWD. CID1352818
2016-03-12 17:04:06 +01:00
Boris Faure
175e474983
add safe guards around term_set_title
...
Should avoid issues when popup is up while term is being destroyed.
2016-03-12 16:46:31 +01:00
Boris Faure
1d138fba36
remove duplicate config keys. Closes T3296
2016-03-12 16:45:52 +01:00
Boris Faure
b8b016875e
use ctrl+alt+t to set terminal title
2016-03-12 16:37:56 +01:00
Carsten Haitzler
dec441790c
Revert "set default font size to 14. Closes T3117"
...
This reverts commit d00a7363b3
.
see https://phab.enlightenment.org/T3117
no - this is not a solution. not in the slightest.
2016-03-08 09:43:06 +09:00
Boris Faure
d00a7363b3
set default font size to 14. Closes T3117
2016-03-07 19:37:10 +01:00
Boris Faure
07dc1fee17
win: set split->last_focus when swallowing in a split
2016-03-06 15:34:36 +01:00
Boris Faure
f850e35ea8
add ctrl-t to default configuration
2016-03-06 14:08:36 +01:00
Toan Pham
ad7409fdfc
Add shortcut to change tab's title
...
Signed off: Toan Pham <tpham3783@gmail.com>
2016-03-06 13:37:49 +01:00
Andy Williams
d293b2531a
shortcuts: Open new terminals with ctrl+shift+n
...
Summary: Add a new configurable key binding to open a new terminal window
Test Plan:
Either wipe your terminology configuration or bind the new
"Open a new terminal window" option to ctrl+shift+n.
Tapping that key combination will then open a new window.
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D3746
2016-03-06 13:22:54 +01:00
Boris Faure
22a3237960
win: be sure we have a child to unfocus. Closes T3260
2016-03-06 13:21:02 +01:00
José Roberto de Souza
ae7e96633a
Allow user to set the title of the each tab
2016-03-04 11:34:24 -03:00
Boris Faure
f05a9187b0
Revert "wip"
...
This reverts commit 487c54b4e1
.
2016-03-03 13:30:14 +01:00
Boris Faure
2c5568c933
Revert "wip"
...
This reverts commit 02db084b27
.
2016-03-03 13:30:00 +01:00
Boris Faure
815dddd880
refocus other split when closing one. Closes T3239
2016-03-03 13:01:19 +01:00
Boris Faure
02db084b27
wip
2016-02-10 23:56:59 +01:00
Boris Faure
487c54b4e1
wip
2016-02-10 00:34:39 +01:00
Boris Faure
e1be15fa89
tiny cleanup
2016-02-09 20:59:32 +01:00
Boris Faure
b74cfc752a
do not append \n at end of box selection
2016-02-07 18:15:00 +01:00
Boris Faure
91842fee8a
we're in 2016!
2016-02-07 16:29:43 +01:00
Boris Faure
bed1532e19
remove callbacks early when pty exists
2016-02-02 23:34:54 +01:00
Boris Faure
1100f4d964
do not use edje cb when term quits. Closes T3105
...
Also reorganize the code a bit
2016-02-02 23:15:50 +01:00
Boris Faure
e8c4f080ed
fix tabbar not working after tab is closed. Closes T3105
2016-01-31 16:25:39 +01:00
Andy Williams
fbf61bf815
[zoom] fix crash fix.
...
Sorry to anyone who lost character selection this morning...
2016-01-31 15:01:00 +00:00
Andy Williams
459cf7383d
[zoom] Fix some potential crashes when zooming.
...
Generally just being a little more defensive against
potential errors.
2016-01-31 09:01:44 +00:00
Andy Williams
ca96a35da7
[zoom] Smooth the scaling of fonts when zooming
...
Capture font size when gesture begins and correctly
update scale based off that until gesture ends.
Test plan:
1) hold Ctrl and scroll the mouse wheel in then out
in a single motion
2) notice zooming continues in initial direction
and accelerates towards the min or max
With patch it will adjust more smoothly and also
match the current zoom of the gesture.
@fix
2016-01-29 14:27:26 +00:00
Andy Williams
55ac83465b
[options] size options list according to scale
2016-01-29 11:23:08 +00:00
Boris Faure
4367b4ceb6
fix selections (again and again) of single-char words
2016-01-27 21:08:45 +01:00
Boris Faure
84c1c77757
oops. Always use curly braces…
2016-01-27 20:17:15 +01:00
Boris Faure
98671b2493
fix one-char selections
2016-01-27 12:49:24 +01:00
Boris Faure
157eff8d6a
fix CID1347402 Pointer to local outside scope
2016-01-07 22:56:53 +01:00
Boris Faure
8fbd1242fb
fix CID1347401 Pointer to local outside scope
2016-01-07 22:55:42 +01:00
Boris Faure
2163bbb775
fix CID1347400 Pointer to local outside scope
2016-01-07 22:54:54 +01:00
Stanislav Baiduzhyi
33d20a1f98
Option to disable cd to current tab dir.
...
Summary: Adding option to disable cd to current tab dir.
Test Plan:
1. Start unpatched version of Terminology.
2. Change some Behaviour options.
3. Close unpatched version of Terminology.
4. Start patched version of Terminology.
5. cd /usr/bin
6. Open new tab and verify that previous behaviour persists, new tab working directory is /usr/bin
7. Go to Settings Behaviour and uncheck "Start in the same directory..." checkbox.
8. Optn new tab and verify that new tab working directory is ~ (or any other directory from which the Terminology was launched).
9. Restart Terminology.
10. Go to Settings Behaviour and verify that options persisted.
Reviewers: #terminology, billiob
Subscribers: godfath3r, #terminology
Projects: #terminology
Differential Revision: https://phab.enlightenment.org/D3495
2015-12-26 12:07:55 +01:00
Stanislav Baiduzhyi
2f3d2a9447
Passing KP_ keys to pty
...
Summary:
KP_Home and KP_End were ignored, skipped because _handle_key_to_pty only checked for Kk keys.
It does not look like that was a typo, so handling for both Kk and KP now in place.
Test Plan:
1. start terminology
2. type 'echo "the quick brown fox jumps over the lazy dog"'
3. press keypad Home key
4. on unpatched terminology nothing happens
5. on patched terminology the behaviour is identical to normal Home
Reviewers: billiob, #terminology, godfath3r
Reviewed By: #terminology, godfath3r
Subscribers: #terminology, godfath3r, billiob
Differential Revision: https://phab.enlightenment.org/D3496
2015-12-26 11:53:32 +01:00
Boris Faure
904f49ccc4
remove statement with no effect
2015-12-26 11:52:31 +01:00
Mike Blumenkrantz
7f53f4daf7
do not force full textgrid width update if preedit_str is ""
...
in many cases this will be the value which has been set, so ignoring it
will yield moderate performance improvements
Reviewed-by: Boris Faure <billiob@gmail.com>
2015-12-15 17:30:02 -05:00
Boris Faure
f731ff6ada
tybg: fix indentation
2015-12-12 15:58:10 +01:00
Boris Faure
3091a4e479
Closes T2911. fix reflow
...
- correctly set `autowrapped`
- reflow the top line when part of its content is in backlog
2015-12-10 21:15:17 +01:00
Boris Faure
66d05abb11
fix text reflow. Closes T2911
...
I should write unit tests on that someday
2015-12-07 22:05:49 +01:00
Boris Faure
3799c924dc
fix wrong assert. Closes T2858
2015-11-21 14:57:05 +01:00
Boris Faure
f8831d9c6a
config: fix CID 1339831: Null pointer dereference
2015-11-19 21:08:16 +01:00
Boris Faure
93d7c8cb29
options_theme: fix CID 1339832: Null pointer dereference
2015-11-19 21:07:18 +01:00
Boris Faure
8190ddd605
options_font: fix CID 1339833
2015-11-19 21:06:14 +01:00
Boris Faure
a29dbe45a7
options_wallpaper: fix CID 1339834: Null pointer dereference
2015-11-19 21:04:17 +01:00
Boris Faure
bb2d7c4250
options_wallpaper: fix CID 1339835: Null pointer dereference
2015-11-19 21:02:21 +01:00
Boris Faure
224173f88d
win: fix CID 1339836: Null pointer dereference
2015-11-19 21:00:22 +01:00
Boris Faure
04089d1e11
lz4: fix CID 1339837: Null pointer dereference
2015-11-19 20:58:17 +01:00
Boris Faure
d558930d01
lz4: fix CID 1339838: Null pointer dereference
2015-11-19 20:55:10 +01:00
Boris Faure
eae5306942
lz4: fix CID 1339839: Null pointer dereference
2015-11-19 20:53:52 +01:00
Boris Faure
ac3dd67109
fix startup split and commands
2015-11-19 20:24:36 +01:00
Boris Faure
a0c249e6ca
fix crash when running tyfuzz. not in terminology
2015-11-14 21:26:37 +01:00
Carsten Haitzler
5a5b80ebec
fix fuzzing so terminology works at all again
...
if (len <= 0)
in _cb_fd_read() is ALWAYS coming up with len < 0 for me and that'd
be LOGICAL... eg if read() returns an error (something ok to allow us
to continue) and so my terminal content NEVER appears - because
terminology is returning false from the fb handler asking it to be
deleted. this is wrong so put it inside #ifdef of fuzzing so it
doesn't affect "normal people". i still think it is broken tho... but
at least i have my terminal back now.
2015-11-12 09:53:32 +09:00
Boris Faure
4913364a22
fix int overflow
2015-11-08 13:06:13 +01:00
Boris Faure
a925de13dc
tyfuzz: read from stdin but write to /dev/null
2015-11-08 13:06:13 +01:00
Boris Faure
bbb60799f4
ugly code to log to syslog
2015-11-08 13:06:13 +01:00
Boris Faure
28965e6601
fix typo/bug spotted by afl-fuzz
2015-11-08 13:06:09 +01:00
Boris Faure
4b4a5e84d4
config: add config_new() to create a new default config
2015-11-08 13:05:43 +01:00
Boris Faure
7d46ee5062
add tyfuzz utility used for fuzzing the escape code parsing routines
2015-11-08 13:05:43 +01:00
Boris Faure
e81097ccf7
comment unused code to remove dependency
2015-11-08 13:05:43 +01:00
Boris Faure
01421754ec
make termpty_handle_buf() public to ease fuzzing
2015-11-08 13:05:43 +01:00
Boris Faure
755a4c3f2f
enable fuzzing with --enable-fuzzing
...
Only enable it if you know what you're doing
2015-11-08 13:05:43 +01:00
Boris Faure
d11ebd1247
add code to fuzz terminology (wip)
2015-11-08 13:05:43 +01:00
Boris Faure
88c4ce46b0
add (ugly) cross to close tabs
2015-11-07 15:59:55 +01:00
Boris Faure
86a596d946
fix --split option
2015-09-26 12:01:42 +02:00
Boris Faure
81a8118c03
fix focus issue when creating a new tab in a split
2015-09-20 15:51:57 +02:00
Boris Faure
4c53f10bf0
do not right trim "." on word selection
...
this makes double click on "../foobar"
2015-09-20 15:42:28 +02:00
Boris Faure
9c4167f74f
always support double-width
2015-09-19 16:23:41 +02:00
Boris Faure
2b3eda694f
always support italic
2015-09-19 16:18:17 +02:00
Boris Faure
e6b924a215
correctly set working dir on split
2015-09-19 14:49:40 +02:00
Boris Faure
e8bd673f20
send ctrl[1-0] to term if "going to tab#" is not possible. Closes T2723
2015-09-14 23:01:32 +02:00
Boris Faure
d844278723
ctrl-[2-8] are now handled by terminology. Ref T2723
2015-09-14 00:01:01 +02:00
Boris Faure
a334bf6554
termpty: fix resizing
...
do not add a useless newline
do not copy the same content few times
2015-09-13 23:17:17 +02:00
Boris Faure
386cf11b19
fix backlog locking
2015-09-13 23:17:03 +02:00
Boris Faure
78cb50c7a3
fix line length computation
2015-09-13 23:16:30 +02:00
Boris Faure
3a7238978e
turn error messages about unhandled escape codes into warnings
2015-09-08 21:59:11 +02:00
Boris Faure
cb531b5d9b
correctly set bold, even if textgrid do not support it (yet)
2015-09-06 23:52:43 +02:00
Boris Faure
02a7a4e4d5
update contributors
2015-09-05 14:06:30 +02:00
Boris Faure
6f898d5ebe
fix typop no longer working for still images. Add some error messages
...
Thanks to dassify for noticing
2015-09-04 20:30:29 +02:00
Boris Faure
4c00bec4d6
cleanup window callbacks
2015-09-02 21:40:03 +02:00
Boris Faure
22ae02127b
fix copy/paste bug. CID1316546
2015-09-01 23:45:18 +02:00
Boris Faure
ede0abb245
fix tab selector segfault
...
Thanks to Yomi for the help in finding this
2015-08-29 15:23:50 +02:00
Boris Faure
45b7d20425
trim selection before trying to open it as url
2015-08-24 23:45:14 +02:00
Boris Faure
cf58c1ee76
add context menu to open a selection as an url. Closes T584
2015-08-24 23:09:24 +02:00
Boris Faure
144e0b5068
add option to disable terminology escape codes that could be considered
...
security issues by some
They are enabled by default.
2015-08-23 20:57:49 +02:00
Boris Faure
5c9d98cf22
add error handlers on textblocks. Should fix T2672
2015-08-23 16:41:15 +02:00
Boris Faure
1400b122ec
bad copy/paste. CID1316546
2015-08-18 22:37:10 +02:00
Boris Faure
7fd86d8968
warn about window operations' escape codes being not supported
2015-08-17 23:18:50 +02:00
Boris Faure
b80bedc7c2
do not report unsanitized input. See CVE-2003-0063
2015-08-17 23:18:49 +02:00
Boris Faure
a33a937ab7
add powerlines to word separators
2015-08-16 21:48:22 +02:00
Boris Faure
716cb03b5b
fix small issue on word selection and simplify code
2015-08-16 21:40:58 +02:00
godfath3r
8e8207dae1
Dont use : as a separator but trim it from selected word. Fixes T2602
...
Reviewers: billiob
Maniphest Tasks: T2602
Differential Revision: https://phab.enlightenment.org/D2931
2015-08-16 20:36:38 +02:00
Mike Blumenkrantz
8d4b06617f
use event length instead of strlen() when dropping something into a terminal
...
the data member of Elm_Selection_Data may not be nul terminated, so
any string operation on this is liable to crash
2015-08-13 14:46:02 -04:00
Carsten Haitzler
4b25721a1d
terminology themes - use theme in home dir over system one always
...
checking modified time between user and system themes is just not a
good idea - we never do this anywhere in e. user installed theme
alwasy overrides system one. modified time is not relevant.
2015-08-11 13:15:16 +09:00
Boris Faure
fe58cd058b
only use beacon when it seems efficient
2015-08-10 21:44:05 +02:00
Boris Faure
d0bedb9a8a
backlog: update beacon while browsing
2015-08-10 21:31:24 +02:00
Boris Faure
69cffca8b0
fix splitting when no term focused. oops
2015-08-10 21:02:27 +02:00
Boris Faure
db471aec09
correctly fix coverity issue found in termiolink.c
2015-08-10 00:28:33 +02:00
Boris Faure
3738402a9d
fix wrong condition. CID1315743
2015-08-09 14:19:50 +02:00
Boris Faure
7af60a58c8
BACKLOG_ROW_GET() should not be called with a "screen" value
...
the backlog is independent of the screen size. Thus a single line in the
backlog can span many lines on the screen.
2015-08-09 14:10:12 +02:00
Boris Faure
b4c91eee47
fix scroll after resize
2015-08-08 16:40:05 +02:00
godfath3r
93c7deeb3e
Correct rewrite of splittable container
...
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D2933
2015-08-08 12:05:04 +02:00
Boris Faure
49be05a02f
do not expand window on zoom, resize the content. Closes T886
2015-08-06 22:40:19 +02:00
Boris Faure
3716c7ec51
apply zoom level/font size to all terms in a window
2015-08-06 21:53:14 +02:00
Boris Faure
fc79e38575
rewrite whether a term container is splittable. CID1315267 and CID1315268
2015-08-06 21:50:58 +02:00
Boris Faure
41579e92e8
remove logically dead code. CID1315103 and CID1315104
2015-08-06 21:39:20 +02:00
Boris Faure
5c37589e39
fix resize when cursor alone on last line
2015-08-05 22:57:01 +02:00
godfath3r
c2e1c2c3fa
Fix crash when split is too small and miniview is shown.
...
Summary: Fixes T2450
Reviewers: billiob
Maniphest Tasks: T2450
Differential Revision: https://phab.enlightenment.org/D2919
2015-08-05 22:02:09 +02:00
godfath3r
eea13ce939
Don't split terminal endlessly.
...
Summary: Previously terminology would split the terminal as many times as user hit split button/shortcut. Now splitting is limited to only when there are at least 2 cells left. (horizontally or vertically) Also Fixes T2638
Reviewers: billiob
Maniphest Tasks: T2638
Differential Revision: https://phab.enlightenment.org/D2915
2015-08-05 21:55:56 +02:00
Boris Faure
423d06fed3
allow different backgrounds via tybg. Closes T2444
2015-08-03 21:45:05 +02:00
Boris Faure
21764bbf85
remove wrong assert when no backlog ever generated
2015-08-03 21:23:38 +02:00
Boris Faure
f40c63bbb6
typo
2015-08-03 20:52:54 +02:00
Boris Faure
8fbffdd869
renames to make the code more consistant
2015-08-03 20:44:55 +02:00
Boris Faure
35c8fd79c0
speed up browsing backlog
...
have a "beacon": single point where the link between an offset in the
backlog and one in screen coordinates
2015-08-03 20:44:55 +02:00
Boris Faure
34592ab5b3
new resize/backlog implementation. Closes T2461
...
idea: store full lines in the backlog. No need to change them on resize
2015-08-03 20:43:17 +02:00
Boris Faure
e2853ab0a5
rename main_term_evas_object_get() to term_termio_get()
2015-08-02 22:53:01 +02:00
godfath3r
10b7b19bc9
Add 'Show miniview by default' in options.
...
Summary: Fixes T1876
Reviewers: billiob, raster
Maniphest Tasks: T1876
Differential Revision: https://phab.enlightenment.org/D2869
2015-08-02 22:44:32 +02:00
Boris Faure
0265c9bd88
cleanup --font handling. Closes T2433
2015-08-02 22:27:54 +02:00
Mike Blumenkrantz
eb25dabf09
fix compile warning
...
tycat.c: In function ‘handle_edje’:
tycat.c:180:40: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
(o, rp, "e/desktop/background") == EINA_TRUE)
2015-07-28 16:07:03 -04:00
Boris Faure
ee6a319f17
add some documentation
2015-07-22 23:16:23 +02:00
Chris Michael
25ec6d06cb
terminology: Fix formatting
...
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-07-22 12:24:33 -04:00
Chris Michael
23045a08a7
terminology: Fix formatting
...
NB: No functional changes, just formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-07-22 11:42:46 -04:00
Boris Faure
5db007e579
fix segv when spliting from controls. Closes T2568
2015-07-15 23:20:02 +02:00
Jean-Philippe Andre
09b4fddf84
escapes: pretty-print some escapse and avoid ESC in debug logs
...
ERR("Hello '%c'", ESC) would result in "Hello '\033'" which means
the parent terminal (another terminology, maybe) would then try to
interpret ' as an escape char (ESC is \033 or 0x1b), and so it would
then forward more escapes to the parent.
Also, avoid printing BEL (and, well, beeping) when we are just
printing an error log.
I believe all those "Unhandled escape" logs should go to WRN or higher
log levels. Any thoughts, @billiob ?
See T2506 (for the test file)
2015-06-24 13:46:48 +09:00
Boris Faure
0fa0a5d9c8
force focus even if win is not yet focused. Closes T2416
2015-06-21 17:50:30 +02:00
Carsten Haitzler
03d1edddaf
terminology config - fix whitespace + indenting
2015-06-16 14:17:25 +09:00
Boris Faure
a07a63048c
fix crash from object being swallowed twice. Closes T2463
2015-06-11 23:55:35 +02:00
Boris Faure
1ad8055d28
remove useless termio_theme_get()
2015-06-11 22:29:53 +02:00
Boris Faure
5d6544ed76
do not update an url if Location is local
2015-06-03 23:04:03 +02:00
Boris Faure
566033f78d
do not remove links when there is a popup due to such link
2015-06-03 23:03:07 +02:00
Boris Faure
681bb029c2
ensure cursor coordinates are always valid, 2nd version
2015-06-03 23:02:31 +02:00
Carsten Haitzler
074eece5f7
Revert "ensure cursor coordinates are always valid"
...
This reverts commit 1f3f779258
.
this breaks terminal scrolling entirely! can't scroll anymore at all
in standard shell. just try a simple: find / -print
2015-06-03 15:00:13 +09:00
Boris Faure
7b72052773
remove callbacks when deleting termio
2015-06-02 23:23:56 +02:00
Boris Faure
bac8e078c7
add some debug to fix focus issues
2015-06-02 23:11:16 +02:00
Boris Faure
1f3f779258
ensure cursor coordinates are always valid
2015-06-02 22:48:50 +02:00
Boris Faure
c86b35309c
rename a bunch of _termpty_*() to termpty_*()
2015-06-02 21:47:06 +02:00
Boris Faure
9ecda225b8
fix focus wrt settings. Closes T2460
2015-06-01 21:19:14 +02:00
Boris Faure
231ff2514a
fix focus issue with ctxpopup. Closes T2455
2015-05-31 17:38:02 +02:00
kidanger
bd9f8591e1
sel: fix incorrect event struct use
2015-05-31 15:59:42 +02:00
Boris Faure
16c184a9d2
fix link detection on links starting at first char of the screen.
...
Closes T2438
2015-05-27 23:20:08 +02:00
Boris Faure
f2239735ab
fix bell. we want it even if the term is focused
2015-05-13 20:53:50 +02:00
Boris Faure
948c1399cd
fix focus issue wrt tabs
...
elm_object_focus_set() triggers a focus_out on the window even though an
object inside it is getting the focus…
2015-05-06 21:31:52 +02:00
Boris Faure
27179b6525
restore animation when moving between tabs. Closes T2380
2015-04-30 21:06:06 +02:00
Boris Faure
f64356baac
fix focus issue. Closes T2376
2015-04-30 20:18:29 +02:00
Boris Faure
9e043c0425
display background on new tab. Closes T2378
2015-04-30 19:33:00 +02:00
Boris Faure
563b592b81
new tab inherits wdir. Closes T2379
2015-04-30 19:11:31 +02:00
Boris Faure
6234a290eb
config: copy "not in eet" info in config_fork(). Fixes "font reset" binding
...
Ref: #18
2015-04-26 18:04:50 +02:00
Boris Faure
da0a6284cd
keys: add underscore as special key. Should close T2369
2015-04-26 13:14:56 +02:00
Boris Faure
d2e39f818e
avoid possible division by 0. Closes CID1295447
2015-04-25 14:56:53 +02:00
Stefan Schmidt
79761712c6
build: Add term_container.h to source files to make sure it gets distributed
...
Would not end up in the tarball if not listed here.
2015-04-24 08:42:11 +02:00
Boris Faure
2228945f2c
refactor win.c to use the Term_Container abstraction
2015-04-23 20:07:59 +02:00
Boris Faure
be62d87f89
separate "termstate" from cursor state and screens. Closes T725
2015-04-23 20:02:53 +02:00
Carsten Haitzler
caf4e92302
terminology config - allow gst1 as vid mod config - adjust limit range
2015-04-19 21:34:22 +09:00
Boris Faure
c2b26e0999
fix selecting tabs
2015-04-18 23:12:39 +02:00
Boris Faure
0e18a185fe
correctly handle empty lines when doing selections
2015-04-18 22:44:42 +02:00
Boris Faure
688f417814
config: do not add F11 as default binding to Fullscreen
2015-04-16 21:33:03 +02:00
Boris Faure
d1416cc735
colors ui: "improved" color namming
2015-04-14 22:18:52 +02:00
Boris Faure
52ceae82b1
add meta/hyper to key bindings. Closes T1985
2015-04-13 21:37:09 +02:00
Boris Faure
981f76c6e3
add ugly timeout to http head when trying to preview links
2015-04-08 23:40:11 +02:00
Jean-Philippe Andre
674c680052
Add .dds to list of image extensions, for tycat
2015-04-07 14:49:44 +09:00
Boris Faure
7e4276c033
right click on a selection shows popup to copy it
...
Closes T2246
2015-04-05 12:14:46 +02:00
Carsten Haitzler
16402da20a
fix terminology popup handling to work again
...
popup handling was broken when adding url head checking. it ALWAYS
used the external helpder path regardless of config requesting to
handle internally if possible. this fixes that.
@fix
2015-04-03 19:50:16 +09:00
Boris Faure
80bb25baaa
fix terminology not starting with newer config
2015-04-01 20:40:17 +02:00
Chris Michael
c328ba006e
terminology: Use proper event structure for mouse up callback
...
Summary: When catching evas mouse up callbacks, we should be using the
Evas_Event_Mouse_Up structure for the event
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-03-30 15:22:20 -04:00
Boris Faure
709a55889f
Revert "fix colors and show darkgray. Closes T2245"
...
This reverts commit 834ee01532
.
2015-03-30 20:47:35 +02:00
Boris Faure
834ee01532
fix colors and show darkgray. Closes T2245
2015-03-29 20:37:17 +02:00
Boris Faure
29cf913951
termio: make code more readable. Closes CID1291865
2015-03-29 18:45:00 +02:00
Boris Faure
e6c45c593d
win: cleanup: rename Term.term to Term.termio
2015-03-22 15:11:10 +01:00
Daniel Zaoui
6aee349409
Revert "have the "xterm" cursor on the textgrid"
...
This reverts commit 144053f882
.
It totally breaks the terminal splitting.
2015-03-22 08:22:14 +02:00
Boris Faure
0895a1e608
should set "hand2" cursor on links but doesn't work
2015-03-18 18:21:23 +01:00
Boris Faure
144053f882
have the "xterm" cursor on the textgrid
2015-03-18 18:03:16 +01:00
Boris Faure
4abdf4b327
code cleanup: s/if (X) free(X);/free(X);/
2015-03-18 15:23:39 +01:00
Jean Guyomarc'h
73c9e82777
config: typo in config upgrade names
...
Summary: If CONF_VER was 4, config should be upgraded to 5.
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D2179
2015-03-17 20:21:07 +01:00
Boris Faure
ed178f5a13
typo
2015-03-17 18:47:26 +01:00
Boris Faure
33322d04af
toggle fullscreen by pressing F11
2015-03-17 18:46:39 +01:00
Boris Faure
7edeea3503
correctly swap term states. Ref T725
2015-03-17 17:15:50 +01:00
Boris Faure
688bf414e4
right trim selections
...
Also add a (near-dumb) string buffer abstraction because working with
Eina_Strbuf, an opaque structure is a PITA.
2015-03-08 20:22:44 +01:00
Boris Faure
b4ba773e17
fix CSI DECSET 1049. Should fix T725
2015-03-01 17:20:18 +01:00
Boris Faure
65d729ce32
font selector: use bg/fg for the preview from config/theme
2015-03-01 17:20:18 +01:00
Boris Faure
4d7708a0f1
tyls: rewrite size_print to avoid arithmetic exception
2015-02-26 23:47:28 +01:00
Boris Faure
6c2e2dfbf5
tyls: fix warnings
...
size comparison
unused variable
2015-02-26 23:47:28 +01:00
Thibaut Broggi
85edd0407c
tyls: remove leaks and fix write() checking
...
leaks were due to a "return 0" in main()
removing it, so that the exit functions from ecore can run properly
changing the way write() was checked, now we check if all chars are printed
2015-02-26 23:47:28 +01:00
Thibaut Broggi
03b88bafc7
tyls: change options management and refactor
...
adding an option "-a" that display hidden files
changing the way options are managed: arguments can no be passed in any order
refactoring size_print function to support ZB and YB
2015-02-26 23:47:22 +01:00
Boris Faure
27304c456f
make terminology start on solaris
2015-02-23 23:33:06 +01:00
Boris Faure
cf1a9a3a01
verify that tcgetattr() does not fail
2015-02-23 23:33:01 +01:00
Boris Faure
ac12f8eec8
handle failure to termio_add()
2015-02-23 23:29:15 +01:00
Boris Faure
12ef99bcf2
fix segfault when Term widget can not be created
2015-02-23 22:52:33 +01:00
Boris Faure
122fa9da0c
add some error messages
...
Also change level of critical error messages
2015-02-23 22:51:33 +01:00
Boris Faure
f13d9ad111
fix compilation on solaris
2015-02-23 22:20:18 +01:00
Boris Faure
2de1cd87b6
pid_t can be long (on solaris)
2015-02-23 21:51:28 +01:00
Aurélien Larcher
2d710e5705
define MIN/MAX in case they're not defined
...
Used for OpenIndiana
2015-02-23 21:25:10 +01:00
Boris Faure
141cfd959d
url head: handle links that are notimages/movies
2015-02-23 20:17:48 +01:00
Boris Faure
be30c069f3
close media popup on escape
2015-02-21 12:24:28 +01:00
Boris Faure
5d169ebd71
correctly check if ecore_con_url_head() is available
2015-02-21 11:40:10 +01:00
Boris Faure
76e9ae6481
do an HTTP HEAD to get media type when poping media
2015-02-21 11:40:10 +01:00
Boris Faure
6762578ace
do only once ecore_con_(url_)init/shutdown()
2015-02-21 11:40:10 +01:00
Boris Faure
ca2d7846a9
fix normal selection after box selection
2015-02-19 23:30:28 +01:00
Boris Faure
e4d357ace2
make terminology work on solaris
...
tcsetattr() should only be called on the slave fd. On linux, both master
or slave are accepted, not on solaris.
2015-02-17 22:08:47 +01:00
Boris Faure
f80d9634e3
fix selection when backscrolling and new content arrives
...
Thanks to Davide Andreoli for the bug report
2015-02-16 22:15:00 +01:00
Boris Faure
feccb7bcab
fix single line selection with ctrl down
2015-02-16 20:50:13 +01:00
Boris Faure
5b4e6de54a
tybg: make tybg without argument display the default wallpaper
...
The ty* tools need some love…
2015-02-15 20:41:31 +01:00
Conrad Meyer
4ea6bdb04e
make terminology compile on efl < 1.8. Patch by Conrad Meyer
2015-02-15 20:29:47 +01:00
Boris Faure
896d28afc3
update contributors
2015-02-15 14:11:37 +01:00
Boris Faure
9a75587d34
bring --split option back to life
2015-02-15 13:45:38 +01:00
Boris Faure
296cdcd102
usual round of fixes to make it compile with efl 1.7
2015-02-14 12:08:50 +01:00
Boris Faure
cf1c8f7c02
move selection when content underneath scrolls
2015-02-13 22:59:56 +01:00
Boris Faure
168395c3e6
revalidate links when scrolling due to mouse wheel. Closes T2111
2015-02-13 22:58:41 +01:00
Boris Faure
4cad406233
remove dead assignment
2015-02-11 21:42:19 +01:00
Boris Faure
337fd3bdb1
minor selection fixes
...
do not consider "click + shift click" if there was a focus out in the
meantime.
disable selection on click when app steals the mouse
2015-02-10 23:55:25 +01:00
Boris Faure
a3a8e370ee
fix signedness comparison issue
2015-02-07 12:03:44 +01:00
broggi_t
4b4deb3ad3
tyls : make the code prettier and more flexible
2015-02-07 12:02:19 +01:00
broggi_t
2a397f35cd
fix some possible bug in tyalpha, tybg, typop, tyq commands
...
make the code prettier in tyls
remove useless exit(0) at the end of the main (just before some return 0)
2015-02-07 12:02:19 +01:00
Boris Faure
9814b10ad2
correctly handle Alt-Enter
2015-02-06 23:12:32 +01:00
Boris Faure
cc6b11a6f5
make selection scroll when at the edge of the terminal. Closes T1944
2015-02-06 22:31:51 +01:00
Boris Faure
f0151cecf2
consider "blocks" as word separators
2015-02-06 22:10:10 +01:00
Boris Faure
26f2607095
select links as words. Closes T2038
2015-02-06 22:10:10 +01:00
Boris Faure
5a9dcf1ed3
do not apply extend fix when selection is box
2015-02-06 22:10:10 +01:00
Boris Faure
788f3e7eb7
rewrite selection system. Closes T1893
2015-02-06 22:09:52 +01:00
Boris Faure
6a2b3ae871
selection: add click then shift-click
2015-02-06 20:48:03 +01:00
Boris Faure
d18a47c5c6
selection: be able to "continue" a selection to a line with shift+triple-click
2015-02-06 20:48:03 +01:00
Boris Faure
da474a4c68
cleanup _sel_set() api
2015-02-06 20:48:03 +01:00
Boris Faure
bae16a33b9
we're in 2015
2015-02-03 20:44:46 +01:00
Boris Faure
c6b5093af5
fix compilation when gettext is not found. Closes T2083
2015-02-03 20:26:25 +01:00
Carsten Haitzler
6268dc32e4
terminology - fix double click selection and jed display
...
this fixes breaks introduced by
e94051dd86
(the previous commit).
latest commit: e94051dd86
breaks 2 things.
1. double-click to select a "word" is broken. the right end of the selection is
stuck at the point where the cursor is, not the right end of the word. try it.
at least that is what i see. either way double-click to select a word is now
broken. ;(
2. what used to be black whitespace bg is now "empty" chars (so i see
terminology bg). this breaks jed output pretty badly.
see...
working:
http://www.enlightenment.org/ss/e-54d05f357a3391.24747752.png
not working:
http://www.enlightenment.org/ss/e-54d05f672a4df7.83729511.png
2015-02-03 14:45:23 +09:00
Boris Faure
e94051dd86
make selection consistent when selecting space with no text. Closes T2013
2015-01-30 00:24:55 +01:00
Boris Faure
87d653ea4d
add xterm 777 notification support. Closes T1765
2015-01-12 23:13:43 +01:00
Boris Faure
bfa9cd30e7
fix shadowed variable
2015-01-11 13:48:05 +01:00
Boris Faure
cd04b71611
check tcsetattr()
2015-01-10 21:02:05 +01:00
Boris Faure
36e5ca2165
"handle" HTS
2015-01-10 21:02:04 +01:00
Boris Faure
da809eb023
"handle" TBC
2015-01-10 21:02:04 +01:00
Carsten Haitzler
0104ce64a9
input methods - display preedit text inside grid - makes it work on wayland
...
@fix - this makes preedit text while composiing display within
terminology like elm entry and edje entry do. no overlayed preedit
window/box. this means that the pre-display has to be done by
terminology, which this does, but it means wayland now can display
preedit strings in terminology like in elm/edje entries too.
2015-01-07 22:35:49 +09:00
Boris Faure
6c398abf3a
cleanup
2014-12-21 18:20:57 +01:00
Boris Faure
7f98dba714
set a title to the term based on the shell started
2014-12-16 22:11:06 +01:00
Boris Faure
b2b1097fd7
fix alt-- to output \033\055. Closes T1921
2014-12-15 20:33:31 +01:00
Boris Faure
de34557170
always prefix with \033 when alt is pressed
2014-12-14 20:32:59 +01:00
Boris Faure
5d2c531756
fix "alt--". Thanks to Flyoc for the bug report
2014-12-14 19:36:36 +01:00
Boris Faure
3ffcbadd6f
remove app server dead code
2014-12-13 12:30:55 +01:00
Carsten Haitzler
5ed68d82b2
terminology - add tab bar at the top that looks like normal tabs
...
this makes the default (and solarized) themes have a tab bar at the
top that look and behave like normal tabs. option to disable these.
other themes might need some updating if they dont follow default by
#including it.
2014-12-11 22:19:55 +09:00
Boris Faure
eb80949921
reset also removes the scrollback. Closes T1891
2014-12-08 20:32:27 +01:00
Boris Faure
cbc92a55fc
Fix screen mangling from prompt redraws on resize. Closes T1193
...
There are still some oddities because the shell doesn't expect us to
reflow.
Let's say we have the following where X is the cursor.
+-------+
|foobar$|
|X |
+-------+
Here, the shell explicitly told us to go to a new line after '$'. We don't
consider '$' is on the same line as 'foobar'.
Decrease the width of that window.
+------+
|foobar|
|$ |
|X |
+------+
Let the shell know the new size. It decides to redraw the prompt. It
remembers it told us to go to a new line, so the first thing it tells us
is to go one line up: to '$' and not 'foobar'. Then it tells us to clear
the screen downward from there and to print "foobar$" (and go to new
line).
Thus we have the following:
+------+
|foobar|
|foobar|
|$ |
|X |
+------+
2014-12-07 23:51:23 +01:00
Carsten Haitzler
5ba415425b
Revert "introduce Term_Container"
...
This reverts commit 50f7468dbc
.
2014-12-03 08:42:55 +09:00
Carsten Haitzler
eafdf2375c
Revert "have a working Solo container"
...
This reverts commit bbbb9f42e4
.
2014-12-03 08:42:53 +09:00
Carsten Haitzler
4df97588b6
Revert "splits are back again"
...
This reverts commit 8d8075ab36
.
2014-12-03 08:42:51 +09:00
Carsten Haitzler
2befa387e7
Revert "make Win a Term_Container"
...
This reverts commit 647c09c45b
.
2014-12-03 08:42:50 +09:00
Carsten Haitzler
73e909641d
Revert "add term_next/prev/first/last"
...
This reverts commit 9e1c97a793
.
2014-12-03 08:42:49 +09:00
Carsten Haitzler
ee09c139df
Revert "win: rename term->term to term->termio"
...
This reverts commit 9aaeed4afc
.
2014-12-03 08:42:47 +09:00
Carsten Haitzler
3ad611a828
Revert "top-level tabs"
...
This reverts commit c6b5d0798f
.
2014-12-03 08:42:46 +09:00
Carsten Haitzler
f2f181cf1b
Revert "toggle tabbar"
...
This reverts commit 973a8d34c6
.
2014-12-03 08:42:45 +09:00
Carsten Haitzler
171b960ed0
Revert "fix focus issue"
...
This reverts commit fd6ce546ed
.
2014-12-03 08:42:43 +09:00
Carsten Haitzler
cb77fe619a
Revert "the tab selector is back!"
...
This reverts commit 4fd9c9d178
.
2014-12-03 08:42:42 +09:00
Carsten Haitzler
913b6d7417
Revert "get add/hide buttons out of the toolbar"
...
This reverts commit 9fa112a98c
.
2014-12-03 08:42:41 +09:00
Carsten Haitzler
d43513e71b
Revert "move split out of Term_Container"
...
This reverts commit 9d3e2d66c1
.
2014-12-03 08:42:39 +09:00
Carsten Haitzler
56c5db34e1
Revert "an arrow_up looks better to hide the tabbar"
...
This reverts commit a4d64fa6f0
.
2014-12-03 08:42:38 +09:00
Carsten Haitzler
480ab8d8d4
Revert "work on bell status"
...
This reverts commit fb6b7e9f75
.
2014-12-03 08:42:36 +09:00
Carsten Haitzler
f408f58316
Revert "add option to hide top tab bar on launch"
...
This reverts commit 9abf95c981
.
2014-12-03 08:42:35 +09:00
Carsten Haitzler
fbb21059e1
Revert "only show tabselector if tabcount > 1"
...
This reverts commit a85dc5be9d
.
2014-12-03 08:42:34 +09:00
Carsten Haitzler
4192a1fc3e
Revert "late focus fix"
...
This reverts commit 8f856a1970
.
2014-12-03 08:42:32 +09:00
Carsten Haitzler
1135027067
Revert "tabs everywhere!"
...
This reverts commit e23136b194
.
2014-12-03 08:42:31 +09:00
Carsten Haitzler
f80fbd90b1
Revert "make tab-related keybindings work again"
...
This reverts commit 6eeceb5ab4
.
2014-12-03 08:42:30 +09:00
Carsten Haitzler
25605153e3
Revert "get rid of application server"
...
This reverts commit 3ffe45d1c6
.
2014-12-03 08:42:29 +09:00
Carsten Haitzler
64be8ed6b3
Revert "clean up"
...
This reverts commit 4ccd2fba63
.
2014-12-03 08:42:27 +09:00
Carsten Haitzler
2145962556
Revert "callback on tab selector is back again"
...
This reverts commit bd4358dd19
.
2014-12-03 08:42:26 +09:00
Carsten Haitzler
62e4e1d9f8
Revert "fix tab count"
...
This reverts commit dfb8889248
.
2014-12-03 08:42:25 +09:00
Carsten Haitzler
a8e886a05f
Revert "fix tab selector"
...
This reverts commit 3b6b4bfe5f
.
2014-12-03 08:42:23 +09:00
Carsten Haitzler
40e2ca168a
terminology - let's stop spewing out a warning all the time in keyin.c
2014-12-03 08:29:02 +09:00
Boris Faure
3b6b4bfe5f
fix tab selector
2014-12-01 00:04:42 +01:00
Boris Faure
dfb8889248
fix tab count
2014-12-01 00:04:28 +01:00
Boris Faure
bd4358dd19
callback on tab selector is back again
2014-11-30 21:28:46 +01:00
Boris Faure
4ccd2fba63
clean up
2014-11-30 21:25:49 +01:00
Boris Faure
3ffe45d1c6
get rid of application server
...
you won't be missed
2014-11-30 20:59:47 +01:00
Boris Faure
6eeceb5ab4
make tab-related keybindings work again
2014-11-30 20:54:23 +01:00
Boris Faure
e23136b194
tabs everywhere!
2014-11-30 16:21:39 +01:00
Boris Faure
8f856a1970
late focus fix
2014-11-30 16:21:39 +01:00
Boris Faure
a85dc5be9d
only show tabselector if tabcount > 1
2014-11-30 16:21:39 +01:00
Boris Faure
9abf95c981
add option to hide top tab bar on launch
2014-11-29 22:28:20 +01:00
Boris Faure
fb6b7e9f75
work on bell status
2014-11-29 22:05:44 +01:00
Boris Faure
a4d64fa6f0
an arrow_up looks better to hide the tabbar
2014-11-29 22:05:41 +01:00
Boris Faure
9d3e2d66c1
move split out of Term_Container
2014-11-29 22:05:41 +01:00
Boris Faure
9fa112a98c
get add/hide buttons out of the toolbar
2014-11-29 22:05:38 +01:00
Boris Faure
4fd9c9d178
the tab selector is back!
2014-11-29 22:05:19 +01:00
Boris Faure
fd6ce546ed
fix focus issue
2014-11-29 22:05:19 +01:00
Boris Faure
973a8d34c6
toggle tabbar
2014-11-29 22:05:19 +01:00
Boris Faure
c6b5d0798f
top-level tabs
2014-11-29 22:05:18 +01:00
Boris Faure
9aaeed4afc
win: rename term->term to term->termio
2014-11-29 22:05:18 +01:00
Boris Faure
9e1c97a793
add term_next/prev/first/last
2014-11-29 22:05:18 +01:00
Boris Faure
647c09c45b
make Win a Term_Container
2014-11-29 22:05:18 +01:00
Boris Faure
8d8075ab36
splits are back again
2014-11-29 22:05:18 +01:00
Boris Faure
bbbb9f42e4
have a working Solo container
2014-11-29 22:05:18 +01:00
Boris Faure
50f7468dbc
introduce Term_Container
2014-11-29 22:05:18 +01:00
Boris Faure
e562bcb7e2
refactor main.c to win.c
2014-11-29 22:05:18 +01:00
Boris Faure
74912ae1e9
remove dead code. Fix CID 1256184
2014-11-29 22:03:38 +01:00
Boris Faure
cc87372941
keep hotfix for efl < 1.13
2014-11-29 21:59:00 +01:00
Wonguk Jeong
709f3172c6
media: remove hotfix for dnd with media with space
...
Previously, path was delivered without uri decoding.
Now, since it is fixed by D1384 in elm_cnp, remove the hotfix.
@fix
2014-11-29 15:39:57 +01:00
Carsten Haitzler
3be6a3b812
terminology - fix warning of uninitialised var and fmtinhg in keybinds
2014-11-27 20:25:54 +09:00
tantSinnister
eea3338a43
Fix for the file URI on FreeBSD.
...
On FreeBSD terminology complains about media_add() can not decode
'folder' and '/usr/home/xyz/1.png'.
This could be fixed by changing the URI from "file:%s" to "file://%s"
2014-11-23 17:17:03 +01:00
Boris Faure
c0f9d25ce1
fix config save wrt gravatar. Thanks to Sachiel for spotting it
2014-11-03 21:02:37 +01:00
Boris Faure
aece218cf3
fix segfault in miniview due to large codepoints
2014-10-28 20:52:35 +01:00
Boris Faure
57cace69d2
fix CID 1249476: Logically dead code
2014-10-25 19:16:19 +02:00
Boris Faure
8204c5c340
options_behavior.c: use macros to reduce code duplication
2014-10-15 21:44:59 +02:00
Boris Faure
d4c2c23394
reorganize config struct
2014-10-15 21:44:59 +02:00
Boris Faure
58de591e58
show gravatar tooltips on emails
2014-10-15 21:44:59 +02:00
Boris Faure
2568c50a40
set media type as an enum
2014-10-15 21:44:58 +02:00
Boris Faure
c7f71d75e8
termio: cleanup some termio_config_get() uses
2014-10-15 21:44:58 +02:00
Boris Faure
e8050e6e28
gravatar: use a tooltip
2014-10-15 21:44:58 +02:00
Boris Faure
c33409048f
add md5.c,h
...
same code used in ethumb…
2014-10-15 21:44:58 +02:00
Boris Faure
f3a0e92e56
very early work on gravatar integration
2014-10-15 21:44:58 +02:00
Boris Faure
32fb73b733
termio: clean up _update_link()
2014-10-15 21:44:58 +02:00
godfath3r
564d78ce93
miniview.c: Remove _do_configure() call from smart_show
...
Summary:
Strangelly enough, _do_configure() call from smart_show() is not necessary.
So, let's clean that up.
Test Plan: Miniview works and resizes as expected without that function call.
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D1539
2014-10-15 20:41:43 +02:00
Boris Faure
4d4575382c
update contributors
2014-10-12 16:04:32 +02:00
Boris Faure
2ae440c9c2
fix segfault. Closes T1716
2014-10-05 23:07:58 +02:00
Boris Faure
fe8b3b9b64
fix issue with keypad keys (bad copy/paste)
2014-10-05 23:07:58 +02:00
Boris Faure
585d4c55ec
forbid AltGr in keybindings
2014-10-03 20:59:38 +02:00
Boris Faure
bf288c8031
restrict modifiers used on key-bindings. Should fix T1695
2014-10-02 21:42:03 +02:00
Boris Faure
8778e1d987
tab can also be called ISO_Left_Tab. Closes T1698
2014-10-02 20:59:38 +02:00
Boris Faure
6f27cdc3ec
key bindings now support the win key
2014-09-30 22:07:28 +02:00
Boris Faure
e69fe704fb
fix ctrl-minus. Closes T1698
2014-09-30 21:24:42 +02:00
Boris Faure
951ed16894
distinguish ctrl-backspace
2014-09-28 23:06:56 +02:00
Boris Faure
dcb978662a
fix alt-backspace
2014-09-28 22:55:56 +02:00
Boris Faure
91f88f21ff
remove some dead code
2014-09-28 22:45:58 +02:00
Boris Faure
a5be0c33c7
some fixes around the key bindings configuration panel
2014-09-28 19:02:21 +02:00
Boris Faure
41ed6abf76
genlist group items are… groups
2014-09-28 17:32:22 +02:00
Boris Faure
978f83dc03
just sighup the shell, don't sigpipe it. Closes T1685
2014-09-28 13:46:04 +02:00
Carsten Haitzler
4fd5c82c63
appserver in terminology -disable right now as eo api is used - bad
2014-09-26 00:53:04 +09:00
Chris Michael
b6b89ba911
terminology: Fix build break caused by 6846978ebd027fff1de57d526071517243354354
...
Summary: Fix build break from a TAsn efl change removing eo_add_custom
function.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-25 10:29:45 -04:00
Cedric BAIL
16fa4ff0c3
termio: add '|' to the list of word separator.
2014-09-24 15:28:21 +02:00
Boris Faure
0fe0007e42
grr, fix previous commit. Thanks again to Godfath3r
2014-09-23 22:10:12 +02:00
Boris Faure
4c6b7c0c61
fix delta position on miniview. Thanks to Godfath3r
2014-09-23 22:03:15 +02:00
Boris Faure
9538380861
make terminology compile with efl 1.7
2014-09-23 21:54:41 +02:00
Wonguk Jeong
fcd67ce7a2
options: chagne step of font size slider from 2 to 1
...
Fixes T1675
2014-09-22 17:25:03 +02:00
Boris Faure
671fe7967b
generate tty_keys.h from xterm itself
...
Script gen_tty_keys.sh is heavily based on the script escapes.sh by Egmont
Koblinger.
Closes T1564
2014-09-21 23:46:49 +02:00
Gwang O Lee
86002b6b12
Add "Miniview" and "Close Terminal" controls
...
Miniview button and icon are added.
Thank you!
Reviewers: seoz, raster, billiob
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1442
2014-09-20 11:11:08 +02:00
Chris Michael
9879be313b
terminology: Fix compile error if gettext & nls are not enabled
...
Summary: If we do not enable gettext & nls support, then LOCALEDIR is
undefined and thus terminology would not compile. Fix that by only
using LOCALEDIR if they are defined.
Break introduced with ad86a427e7
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-19 09:31:55 -04:00
Carsten Haitzler
ad86a427e7
terminology - locale - use prefix found locale dir, not fixed compile
2014-09-18 21:52:21 +09:00
Carsten Haitzler
0284ec1180
prefix relocation - set up libdir and localedir to work best
2014-09-18 21:49:27 +09:00
Boris Faure
b9a994c4bd
fix compilation. I'm tired…
2014-09-15 23:30:48 +02:00
Boris Faure
caed00cc1f
fix segfault due to using isdigit with non unsigned char value. Closes T1625
...
Also rename _termpty_handle_seq() to termpty_handle_seq() since it's not static.
2014-09-15 23:10:55 +02:00
Boris Faure
2eb2b9646f
fix segfault when OOM on the termpty_save module
2014-09-15 22:07:22 +02:00
Boris Faure
90c53f5974
fix CID 1238659: Dereference after null check (FORWARD_NULL)
2014-09-15 21:04:26 +02:00
Wonguk Jeong
640ecd68a8
popmedia: prevent double deleting of media object
...
if stop button in media control had clicked, double deleting error message came out (tyq, typop)
@fix
2014-09-15 12:32:22 +02:00
Wonguk Jeong
6c8af4f82c
media: fix replay on stop bug in tycat
...
even if stop button in media control has been clicked, media is not stopped but is replayed in tycat
Fixes T1560
2014-09-15 12:01:22 +02:00
Boris Faure
f8429209bb
add a Toolkit settings category to launch elementary_config. Closes T1492
2014-09-14 23:18:55 +02:00
Boris Faure
51555f9c35
fork can fail
2014-09-14 22:46:22 +02:00
Boris Faure
c312797e4e
font_set should be copied when forking the config
...
we don't want to change the font whenever the config is forked!
2014-09-14 22:29:25 +02:00
Boris Faure
d53c4c5742
try to guess a scalable default font. Closes T1426
2014-09-14 17:30:30 +02:00
Boris Faure
6d4219137f
try to handle OOM on "termpty_save"
2014-09-14 14:11:14 +02:00
Boris Faure
4617a8b6c3
no more than 128k lines of scrollback
2014-09-13 14:16:41 +02:00
Chris Michael
33c19c0bfb
terminology: Fix formatting
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-11 08:24:45 -04:00
Chris Michael
e4bf56d862
terminology: Remove blank line
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-11 08:23:38 -04:00
Chris Michael
4731d8d826
terminology: Don't declare 'action' variable unless we have gettext
...
and nls
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-11 08:23:12 -04:00
Chris Michael
10542a205f
Revert "terminology: Remove unused variable"
...
This reverts commit e82dea1d27
.
Oopsie, revert this one....my compiler apparently was lying to me :(
2014-09-11 08:20:53 -04:00
Chris Michael
e82dea1d27
terminology: Remove unused variable
...
NB: _actions is not being used in the key_bindings_load function, so
remove the variable.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-11 07:53:34 -04:00
Chris Michael
6ed8e857a1
terminology: Remove unused variable
...
NB: _blocks is not being used anywhere in the termptysave file, so remove
the variable.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-11 07:49:21 -04:00
Carsten Haitzler
15b55d5eb7
Revert "do not crash when the scrollback mempool is OOM"
...
This reverts commit 815a357ad9
.
this patch breaks paging and backscroll completely. just try less or
more - eg
man ls
then resize the window. :)
2014-09-10 16:57:32 +09:00
Boris Faure
815a357ad9
do not crash when the scrollback mempool is OOM
2014-09-08 21:28:26 +02:00
Boris Faure
527bd7358e
scrollback_save: cleanup
2014-09-08 21:28:26 +02:00
Boris Faure
f1cb4c85a9
fix scrollback option
2014-09-08 21:28:26 +02:00
Anisse Astier
adb2d84042
Add debug messages
2014-09-08 21:28:26 +02:00
Boris Faure
fd1e4ffd45
fix segfault when decoding buggy xterm sequence. cf T1625
2014-09-04 20:45:02 +02:00
Gwang O Lee
a14652de13
update po: modify typo and corresponding to the D1404
...
Summary: update pot & po files.
Reviewers: huchi, billiob, seoz
Reviewed By: billiob, seoz
Subscribers: seoz, DarkCircle
Differential Revision: https://phab.enlightenment.org/D1405
2014-09-05 03:32:37 +09:00
Gwang O Lee
1c64e7c7c5
add "Close the current terminal" key binding
...
Summary:
First, you must delete the '~/.config/terminology/config/standard/base.cfg'.
Key : Ctrl + Shift + End
Reviewers: huchi, seoz, billiob
Reviewed By: billiob
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1404
2014-09-04 16:04:40 +02:00
Boris Faure
91a0254dc6
fixed keyboard scrolling
2014-09-03 20:55:00 +02:00
Kai Huuhko
0d754439a5
Fix last commit by moving the closing parenthesis away from line comment
...
I'm redirecting all spankies to billiob for the bad patch
2014-09-03 14:05:04 +03:00
Kai Huuhko
4fc3fd2326
Move a closing tag to correct position in about dialog contents
2014-09-03 13:24:46 +03:00
Boris Faure
ae24098f73
fix dnd with media with spaces. Closes T1586
...
The path is url encoded without the prefix "file:".
2014-09-02 21:18:24 +02:00
Boris Faure
bd31879114
group actions to improve the configuration screen
2014-09-02 20:42:45 +02:00
Boris Faure
772843d568
add ui to configure key bindings
2014-09-02 20:42:45 +02:00
Boris Faure
57b06067a8
load key bindings from config
2014-09-02 20:42:45 +02:00
Boris Faure
c839959a51
have all the default shortcuts in the hash map
2014-09-02 20:42:45 +02:00
Boris Faure
2f9532d28c
store keybindings in a hash map
2014-09-02 20:42:45 +02:00
Gwang O Lee
a6653a9c80
update pot & ko.po file.
...
Summary:
Portable Object Template and ko.po update.
(some fix - options_keys.c)
Reviewers: seoz, huchi, billiob
Reviewed By: billiob
Subscribers: ryuan.choi, billiob, seoz, DarkCircle
Differential Revision: https://phab.enlightenment.org/D1377
2014-08-31 21:17:08 +02:00
Boris Faure
a482eda31a
fix miniview not showing up
2014-08-31 17:02:59 +02:00
Boris Faure
34979f1ce4
get rid of Eina_Bool in bitfields
2014-08-28 21:04:00 +02:00
Wonguk Jeong
f06c9f52a3
Revert "options: color picker added"
...
it makes option color ugly. I will put picker again after figure it out
This reverts commit a25b27e232
.
2014-08-25 21:58:19 +02:00
Wonguk Jeong
a25b27e232
options: color picker added
...
Fixes T1032
2014-08-25 19:51:14 +02:00
Wonguk Jeong
8b2a3aa838
media: audio visualize by default
2014-08-25 18:03:09 +02:00
Boris Faure
bcd3699a9d
fix shift-F1..4. Closes T1564.
2014-08-22 22:19:44 +02:00
Boris Faure
1ef2fbb8a3
refactor keys handling in termio: move to keyin, 2nd round!
2014-08-22 21:54:04 +02:00
Carsten Haitzler
117d9e7840
Revert "refactor keys handling in termio: move to keyin"
...
this breaks emacs and jed totally - ctrl+space to do selection blocks
is gone! :(
This reverts commit 9215f941e9
.
2014-08-22 14:12:04 +09:00
Boris Faure
9215f941e9
refactor keys handling in termio: move to keyin
2014-08-21 23:29:53 +02:00
Wonguk Jeong
31df543ec6
options: remove unused global variable
2014-08-21 21:48:42 +02:00
Wonguk Jeong
bce172cc87
media: audio visualization support (phase 1)
...
support audio visualization for typop, tycat
This is just first phase with hard coded type (EMOTION_VIS_LIBVISUAL_INFINITE)
TODO:
1. configurable visualizing type in option
2. hide visualizing option if it is not supported.
(it's currently supported with "gstreamer" engine)
2014-08-21 20:32:58 +02:00
Boris Faure
1f68d2836b
make terminology compile with efl 1.8
2014-08-20 19:47:24 +02:00
Boris Faure
4b425b9054
constify key_down event in termio
2014-08-19 23:09:50 +02:00
Boris Faure
901807fc09
also remove debugwhite
2014-08-19 22:48:00 +02:00
Boris Faure
ed3bc87316
try to reorganize termio.c
2014-08-19 22:39:32 +02:00
Boris Faure
19734613d1
get rid of mirror stuff, it is not used
2014-08-19 21:45:27 +02:00
Wonguk Jeong
80caa24ab6
utils: clarify error message
2014-08-18 18:53:49 +02:00
Wonguk Jeong
a49265e609
media: fix inaccessible media control problem in typop
...
Fixes T1545
2014-08-18 18:48:58 +02:00
Wonguk Jeong
23ee76e572
media: raise media control above selection event obj
...
Fixes T1454
2014-08-18 17:56:58 +02:00
Carsten Haitzler
4fe0c07254
add : to word separators
2014-08-18 17:18:03 +09:00
Carsten Haitzler
5ddd6dfa63
tycat and tylsd - dont init system modules in ecore. not neeeded
2014-08-18 15:53:54 +09:00
Boris Faure
6c50375f26
Party time! be able to set foreground color
...
Reset is not yet implemented for that…
Idea is from http://www.reddit.com/r/linux/comments/2ds0he/xterm_party/
2014-08-17 22:20:40 +02:00
godfath3r
93e2d73a87
options_keys: update shift+Up/Down for -1/+1 line scroll
...
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D1339
2014-08-17 22:14:33 +02:00
godfath3r
277acdc9b5
miniview: fix a bug when mv is open and you open a new tab.
...
Summary:
Before the fix, the previous tabs miniview stayed faultly
visible for the new tab.
Reviewers: billiob
Reviewed By: billiob
Differential Revision: https://phab.enlightenment.org/D1338
2014-08-17 22:13:54 +02:00
Boris Faure
5dfb63a14a
handle queries on some xterm escape codes
2014-08-17 17:44:19 +02:00
Boris Faure
61050bd7cc
clean up xterm escape codes handling
2014-08-17 17:32:57 +02:00
Boris Faure
fa88d971b1
remvove links when content change underneath
2014-08-17 16:46:16 +02:00
godfath3r
6e82dff4e0
termio: add Shift + Up/Down shortcut for +1/-1 line scroll navigation
...
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D1336
2014-08-16 18:46:26 +02:00
godfath3r
31da027aef
miniview: scroll position indicator when jump on change isn't checked.
...
Summary:
Fix indicators position when your are at some place in scrollback
and terminal outputs some new lines (say from a running command). It
now scrolls to where it should be.
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D1335
2014-08-16 18:45:14 +02:00
Carsten Haitzler
149d23d484
re-fix wrodsep to work again and not segv
2014-08-15 20:20:15 +09:00
Carsten Haitzler
cd0bfa5d0c
fix segv on word set search
2014-08-15 20:00:24 +09:00
Boris Faure
eb347e9585
elm_slider_step_set was only introduced in elm 1.8
2014-08-15 11:03:51 +02:00
Boris Faure
9a16eb57a1
handle some DSR: the cursor position reports
2014-08-14 21:48:26 +02:00
Wonguk Jeong
8ba6a73139
options: theme preview cursor/selection bug fix
...
Default theme is used for fallback when we apply theme.
But, in the preview, current theme has been used for fallback.
Fixes T1535
2014-08-13 19:34:57 +02:00
Boris Faure
572f2301f5
fix out of bounds access. CID 1231069
2014-08-13 03:20:19 +02:00
Boris Faure
c14f6949ae
wordseparators shouldn't be in the config, the ui is unusable
2014-08-12 22:07:03 +02:00
Boris Faure
ae820f3897
extract csi_reset_mode
2014-08-11 22:03:56 +02:00
godfath3r
20c4a7b514
main: follow coding style
...
Reviewers: billiob
Differential Revision: https://phab.enlightenment.org/D1310
2014-08-11 22:03:56 +02:00