summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKai Huuhko <kai.huuhko@gmail.com>2016-02-02 14:11:33 +0200
committerKai Huuhko <kai.huuhko@gmail.com>2016-02-02 14:23:00 +0200
commitcaef23bb34d2183c8d9ee611a086713f084f7ed6 (patch)
treee0a0a5810dc2f56974bea51bf3376d08e0e0bf67
parent684ad779dce9125dc8ca50f6dfb015075fb4338c (diff)
Trivial todo note updates and doc fix
-rw-r--r--TODO1
-rw-r--r--efl/edje/efl.edje_edit_program.pxi2
-rw-r--r--efl/elementary/fileselector.pxi6
-rw-r--r--efl/elementary/gengrid_item.pxi4
-rw-r--r--efl/elementary/gengrid_widget.pxi2
-rw-r--r--efl/elementary/genlist_widget.pxi5
-rw-r--r--efl/elementary/map.pxi1
-rw-r--r--efl/elementary/multibuttonentry.pxi6
-rw-r--r--efl/elementary/notify.pxi2
-rw-r--r--efl/elementary/object.pxi5
-rw-r--r--efl/elementary/transit.pxi11
-rw-r--r--efl/elementary/web.pxi2
-rw-r--r--efl/eo/efl.eo.pyx2
-rw-r--r--efl/evas/efl.evas_object_image.pxi2
-rw-r--r--efl/utils/conversions.pyx2
-rw-r--r--include/efl.evas.pxd12
16 files changed, 33 insertions, 32 deletions
diff --git a/TODO b/TODO
index 4e41a98..3a1396e 100644
--- a/TODO
+++ b/TODO
@@ -11,6 +11,7 @@ BUGS
11 - Multibuttonentry.filter_append() 11 - Multibuttonentry.filter_append()
12 - Multibuttonentry.filterprepend() 12 - Multibuttonentry.filterprepend()
13 ... maybe do like is done in genlist filter_set() ?? 13 ... maybe do like is done in genlist filter_set() ??
14* API break in https://git.enlightenment.org/bindings/python/python-efl.git/commit/efl/elementary/label.pyx?id=9be98bb979917932cc2850a54f6e79281c871401 , find out if it had users anywhere, remove if not
14 15
15Failing unit tests 16Failing unit tests
16------------------ 17------------------
diff --git a/efl/edje/efl.edje_edit_program.pxi b/efl/edje/efl.edje_edit_program.pxi
index 32479de..e6b3161 100644
--- a/efl/edje/efl.edje_edit_program.pxi
+++ b/efl/edje/efl.edje_edit_program.pxi
@@ -50,7 +50,7 @@ cdef class Program(object):
50 def run(self): 50 def run(self):
51 return bool(edje_edit_program_run(self.edje.obj, self.name)) 51 return bool(edje_edit_program_run(self.edje.obj, self.name))
52 52
53 # XXX TODO: add (or better convert) all this to properties 53 # TODO: add (or better convert) all this to properties
54 # like is done in Part() 54 # like is done in Part()
55 def source_get(self): 55 def source_get(self):
56 cdef const char *s 56 cdef const char *s
diff --git a/efl/elementary/fileselector.pxi b/efl/elementary/fileselector.pxi
index 80ea7f6..a861bfb 100644
--- a/efl/elementary/fileselector.pxi
+++ b/efl/elementary/fileselector.pxi
@@ -351,8 +351,8 @@ cdef class Fileselector(LayoutClass):
351 351
352 """ 352 """
353 cb_data = (func, data) 353 cb_data = (func, data)
354 # TODO: This is now a ref leak. It should be stored somewhere and 354 # FIXME: This is now a ref leak. It should be stored somewhere and
355 # deleted in the remove method. 355 # deleted in the remove method.
356 Py_INCREF(cb_data) 356 Py_INCREF(cb_data)
357 357
358 if isinstance(filter_name, unicode): filter_name = PyUnicode_AsUTF8String(filter_name) 358 if isinstance(filter_name, unicode): filter_name = PyUnicode_AsUTF8String(filter_name)
@@ -443,7 +443,7 @@ cdef class Fileselector(LayoutClass):
443 self._callback_del_full("selected", _cb_string_conv, func) 443 self._callback_del_full("selected", _cb_string_conv, func)
444 444
445 # 445 #
446 # FIXME: This seems to be a thing that the application should handle 446 # TODO: This seems to be a thing that the application should handle
447 # 447 #
448 #def callback_selected_invalid_add(self, func, *args, **kwargs): 448 #def callback_selected_invalid_add(self, func, *args, **kwargs):
449 #"""The user has tried to access a path which does not exist.""" 449 #"""The user has tried to access a path which does not exist."""
diff --git a/efl/elementary/gengrid_item.pxi b/efl/elementary/gengrid_item.pxi
index ce4b8f4..4c7cda5 100644
--- a/efl/elementary/gengrid_item.pxi
+++ b/efl/elementary/gengrid_item.pxi
@@ -298,9 +298,9 @@ cdef class GengridItem(ObjectItem):
298 elm_gengrid_item_pos_get(self.item, &x, &y) 298 elm_gengrid_item_pos_get(self.item, &x, &y)
299 return (x, y) 299 return (x, y)
300 300
301 # XXX TODO elm_gengrid_item_item_class_update 301 # TODO: elm_gengrid_item_item_class_update
302 302
303 # XXX TODO elm_gengrid_item_item_class_get 303 # TODO: elm_gengrid_item_item_class_get
304 304
305 property select_mode: 305 property select_mode:
306 """Item's select mode. Possible values are: 306 """Item's select mode. Possible values are:
diff --git a/efl/elementary/gengrid_widget.pxi b/efl/elementary/gengrid_widget.pxi
index 58e7a54..81ad765 100644
--- a/efl/elementary/gengrid_widget.pxi
+++ b/efl/elementary/gengrid_widget.pxi
@@ -210,7 +210,7 @@ cdef class Gengrid(Object):
210 return GengridItem(item_class, item_data, func, item_data)\ 210 return GengridItem(item_class, item_data, func, item_data)\
211 .insert_before(after_item) 211 .insert_before(after_item)
212 212
213 # XXX TODO elm_gengrid_item_sorted_insert() 213 # TODO: elm_gengrid_item_sorted_insert()
214 214
215 property selected_item: 215 property selected_item:
216 """This returns the selected item. If multi selection is enabled 216 """This returns the selected item. If multi selection is enabled
diff --git a/efl/elementary/genlist_widget.pxi b/efl/elementary/genlist_widget.pxi
index b558f4a..98e28b0 100644
--- a/efl/elementary/genlist_widget.pxi
+++ b/efl/elementary/genlist_widget.pxi
@@ -256,7 +256,6 @@ cdef class Genlist(Object):
256 ObjectItem parent_item=None, 256 ObjectItem parent_item=None,
257 int flags=ELM_GENLIST_ITEM_NONE, 257 int flags=ELM_GENLIST_ITEM_NONE,
258 func=None 258 func=None
259 #API XXX: *args, **kwargs
260 ): 259 ):
261 """This inserts a new item in the genlist based on a user defined 260 """This inserts a new item in the genlist based on a user defined
262 comparison function. 261 comparison function.
@@ -356,8 +355,8 @@ cdef class Genlist(Object):
356 """ 355 """
357 def __get__(self): 356 def __get__(self):
358 return _object_item_list_to_python(elm_genlist_realized_items_get(self.obj)) 357 return _object_item_list_to_python(elm_genlist_realized_items_get(self.obj))
359 # XXX: Free the list? We could return a custom list-like object here 358 # FIXME: Free the list! We could return a custom list-like object here
360 # that frees the C list in its __dealloc__ 359 # that frees the C list in its __dealloc__
361 360
362 def realized_items_get(self): 361 def realized_items_get(self):
363 return _object_item_list_to_python(elm_genlist_realized_items_get(self.obj)) 362 return _object_item_list_to_python(elm_genlist_realized_items_get(self.obj))
diff --git a/efl/elementary/map.pxi b/efl/elementary/map.pxi
index 26dadd3..8f0c89f 100644
--- a/efl/elementary/map.pxi
+++ b/efl/elementary/map.pxi
@@ -164,7 +164,6 @@ cdef class MapName(object):
164 <const char *>address if address is not None else NULL, 164 <const char *>address if address is not None else NULL,
165 lon, lat, _map_name_callback, <void *>data) 165 lon, lat, _map_name_callback, <void *>data)
166 Py_INCREF(data) 166 Py_INCREF(data)
167 # XXX: why incref self in __init__?
168 Py_INCREF(self) 167 Py_INCREF(self)
169 168
170 def delete(self): 169 def delete(self):
diff --git a/efl/elementary/multibuttonentry.pxi b/efl/elementary/multibuttonentry.pxi
index e1bfbf3..aa874bc 100644
--- a/efl/elementary/multibuttonentry.pxi
+++ b/efl/elementary/multibuttonentry.pxi
@@ -44,7 +44,7 @@ cdef char * _multibuttonentry_format_cb(int count, void *data) with gil:
44 traceback.print_exc() 44 traceback.print_exc()
45 return NULL 45 return NULL
46 46
47 # TODO leak here 47 # FIXME: leak here
48 return strdup(<char *>s) 48 return strdup(<char *>s)
49 49
50 50
@@ -378,6 +378,7 @@ cdef class MultiButtonEntry(Object):
378 elm_multibuttonentry_item_filter_append(self.obj, 378 elm_multibuttonentry_item_filter_append(self.obj,
379 _multibuttonentry_filter_callback, <void *>cbdata) 379 _multibuttonentry_filter_callback, <void *>cbdata)
380 380
381 # FIXME: leak here
381 Py_INCREF(cbdata) 382 Py_INCREF(cbdata)
382 383
383 def filter_prepend(self, func, *args, **kwargs): 384 def filter_prepend(self, func, *args, **kwargs):
@@ -386,6 +387,7 @@ cdef class MultiButtonEntry(Object):
386 elm_multibuttonentry_item_filter_prepend(self.obj, 387 elm_multibuttonentry_item_filter_prepend(self.obj,
387 _multibuttonentry_filter_callback, <void *>cbdata) 388 _multibuttonentry_filter_callback, <void *>cbdata)
388 389
390 # FIXME: leak here
389 Py_INCREF(cbdata) 391 Py_INCREF(cbdata)
390 392
391 #TODO 393 #TODO
@@ -433,7 +435,7 @@ cdef class MultiButtonEntry(Object):
433 elm_multibuttonentry_format_function_set(self.obj, 435 elm_multibuttonentry_format_function_set(self.obj,
434 _multibuttonentry_format_cb, 436 _multibuttonentry_format_cb,
435 <void *>cbdata) 437 <void *>cbdata)
436 # TODO leak here 438 # FIXME: leak here
437 Py_INCREF(cbdata) 439 Py_INCREF(cbdata)
438 440
439 def callback_item_selected_add(self, func, *args, **kwargs): 441 def callback_item_selected_add(self, func, *args, **kwargs):
diff --git a/efl/elementary/notify.pxi b/efl/elementary/notify.pxi
index 1d9d798..24f9463 100644
--- a/efl/elementary/notify.pxi
+++ b/efl/elementary/notify.pxi
@@ -17,7 +17,7 @@
17 17
18include "notify_cdef.pxi" 18include "notify_cdef.pxi"
19 19
20# FIXME: cdef extern this 20# TODO: move this to cdefs
21ELM_NOTIFY_ALIGN_FILL = -1.0 21ELM_NOTIFY_ALIGN_FILL = -1.0
22 22
23cdef class Notify(Object): 23cdef class Notify(Object):
diff --git a/efl/elementary/object.pxi b/efl/elementary/object.pxi
index fd8cb36..c229e2e 100644
--- a/efl/elementary/object.pxi
+++ b/efl/elementary/object.pxi
@@ -38,7 +38,6 @@ cdef void _tooltip_data_del_cb(void *data, Evas_Object *o, void *event_info) wit
38cdef bint _event_dispatcher(Object obj, Object src, Evas_Callback_Type t, 38cdef bint _event_dispatcher(Object obj, Object src, Evas_Callback_Type t,
39 event_info): 39 event_info):
40 cdef bint ret 40 cdef bint ret
41 # XXX: This is expensive code
42 for func, args, kargs in obj._elm_event_cbs: 41 for func, args, kargs in obj._elm_event_cbs:
43 try: 42 try:
44 ret = func(obj, src, t, event_info, *args, **kargs) 43 ret = func(obj, src, t, event_info, *args, **kargs)
@@ -478,7 +477,7 @@ cdef class Object(SmartObject):
478 signal_callback) 477 signal_callback)
479 478
480 # 479 #
481 # FIXME: Review this 480 # TODO: Review this
482 # 481 #
483 # NOTE: name clash with evas event_callback_* 482 # NOTE: name clash with evas event_callback_*
484 def elm_event_callback_add(self, func, *args, **kargs): 483 def elm_event_callback_add(self, func, *args, **kargs):
@@ -1871,5 +1870,5 @@ cdef class Object(SmartObject):
1871 # """ 1870 # """
1872 # elm_access_highlight_set(self.obj) 1871 # elm_access_highlight_set(self.obj)
1873 1872
1874# TODO: Check if this is used correctly here 1873# FIXME: Check if this is used correctly here
1875_object_mapping_register("Elm_Widget", Object) 1874_object_mapping_register("Elm_Widget", Object)
diff --git a/efl/elementary/transit.pxi b/efl/elementary/transit.pxi
index 4eb40ed..d1d5c6a 100644
--- a/efl/elementary/transit.pxi
+++ b/efl/elementary/transit.pxi
@@ -141,16 +141,17 @@ cdef class Transit(object):
141 """ 141 """
142 elm_transit_del(self.obj) 142 elm_transit_del(self.obj)
143 143
144 # TODO: Fix the documentation
145 def effect_add(self, TransitCustomEffect effect): 144 def effect_add(self, TransitCustomEffect effect):
146 """Add a new effect to the transit. 145 """Add a new effect to the transit.
147 146
148 Example:: 147 Example::
149 148
149 class MyEffect(TransitCustomEffect):
150 # define your methods...
151
150 t = Transit() 152 t = Transit()
151 t.effect_add( elm_transit_effect_blend_op, 153 e = MyEffect()
152 elm_transit_effect_blend_context_new(), 154 t.effect_add(e)
153 elm_transit_effect_blend_context_free)
154 155
155 .. warning:: The transit will free the context data at the and of the 156 .. warning:: The transit will free the context data at the and of the
156 transition with the data_free_cb function. Do not share the 157 transition with the data_free_cb function. Do not share the
@@ -160,7 +161,7 @@ cdef class Transit(object):
160 you try to add an existing effect, nothing is done. 161 you try to add an existing effect, nothing is done.
161 .. note:: After the first addition of an effect to ``transit``, if its 162 .. note:: After the first addition of an effect to ``transit``, if its
162 effect list become empty again, the ``transit`` will be killed by 163 effect list become empty again, the ``transit`` will be killed by
163 elm_transit_del(transit) function. 164 :meth:`delete` function.
164 165
165 :param effect: The context data of the effect. 166 :param effect: The context data of the effect.
166 167
diff --git a/efl/elementary/web.pxi b/efl/elementary/web.pxi
index b9ee90d..f67a5bc 100644
--- a/efl/elementary/web.pxi
+++ b/efl/elementary/web.pxi
@@ -928,7 +928,7 @@ cdef class Web(Object):
928 # """Queries if the menubar is visible. Event info 928 # """Queries if the menubar is visible. Event info
929 # is a bool where the callback should set True if 929 # is a bool where the callback should set True if
930 # the menubar is visible, or False in case it's not.""" 930 # the menubar is visible, or False in case it's not."""
931 # # XXX: the cb for this should use the return value, not the bool passed. 931 # # FIXME: the cb for this should use the return value, not the bool passed.
932 # self._callback_add_full("menubar,visible,get", _cb_bool_conv, func, 932 # self._callback_add_full("menubar,visible,get", _cb_bool_conv, func,
933 # *args, **kwargs) 933 # *args, **kwargs)
934 934
diff --git a/efl/eo/efl.eo.pyx b/efl/eo/efl.eo.pyx
index 13cf9df..391c4a7 100644
--- a/efl/eo/efl.eo.pyx
+++ b/efl/eo/efl.eo.pyx
@@ -175,7 +175,7 @@ cdef void _register_decorated_callbacks(Eo obj):
175 cdef object attr_name, attrib, func_name, func 175 cdef object attr_name, attrib, func_name, func
176 cdef type cls = type(obj) 176 cdef type cls = type(obj)
177 177
178 # XXX: This whole thing is really slow. Can we do it better? 178 # FIXME: This whole thing is really slow. Can we do it better?
179 179
180 for attr_name, attrib in cls.__dict__.items(): 180 for attr_name, attrib in cls.__dict__.items():
181 if "__decorated_callbacks__" in dir(attrib): 181 if "__decorated_callbacks__" in dir(attrib):
diff --git a/efl/evas/efl.evas_object_image.pxi b/efl/evas/efl.evas_object_image.pxi
index 9594747..48e8a3e 100644
--- a/efl/evas/efl.evas_object_image.pxi
+++ b/efl/evas/efl.evas_object_image.pxi
@@ -1384,7 +1384,7 @@ cdef class FilledImage(Image):
1384 raise NotImplementedError("FilledImage doesn't support fill_set()") 1384 raise NotImplementedError("FilledImage doesn't support fill_set()")
1385 1385
1386 1386
1387#TODO: Check if this is right 1387#FIXME: Check if this is right
1388_object_mapping_register("Evas_FilledImage", FilledImage) 1388_object_mapping_register("Evas_FilledImage", FilledImage)
1389 1389
1390def extension_can_load(filename): 1390def extension_can_load(filename):
diff --git a/efl/utils/conversions.pyx b/efl/utils/conversions.pyx
index 3c1cc76..a602bf6 100644
--- a/efl/utils/conversions.pyx
+++ b/efl/utils/conversions.pyx
@@ -72,7 +72,7 @@ cdef const char ** python_list_strings_to_array_of_strings(list strings) except
72 unsigned int str_len, i 72 unsigned int str_len, i
73 unsigned int arr_len = len(strings) 73 unsigned int arr_len = len(strings)
74 74
75 # TODO: Should we just return NULL in this case? 75 # FIXME: Should we just return NULL in this case?
76 if arr_len == 0: 76 if arr_len == 0:
77 array = <const char **>malloc(sizeof(const char*)) 77 array = <const char **>malloc(sizeof(const char*))
78 if not array: 78 if not array:
diff --git a/include/efl.evas.pxd b/include/efl.evas.pxd
index 1d78d72..c2b2ae0 100644
--- a/include/efl.evas.pxd
+++ b/include/efl.evas.pxd
@@ -866,7 +866,7 @@ cdef extern from "Evas.h":
866 Evas_Object *evas_object_image_add(Evas *e) 866 Evas_Object *evas_object_image_add(Evas *e)
867 # TODO: Use this?: Evas_Object *evas_object_image_filled_add(Evas *e) 867 # TODO: Use this?: Evas_Object *evas_object_image_filled_add(Evas *e)
868 # TODO: void evas_object_image_memfile_set(Evas_Object *obj, void *data, int size, char *format, char *key) 868 # TODO: void evas_object_image_memfile_set(Evas_Object *obj, void *data, int size, char *format, char *key)
869 # FIXME: Is this needed?: const Eo_Class *evas_object_image_class_get() 869 # TODO: Is this needed?: const Eo_Class *evas_object_image_class_get()
870 void evas_object_image_file_set(Evas_Object *obj, const char *file, const char *key) 870 void evas_object_image_file_set(Evas_Object *obj, const char *file, const char *key)
871 void evas_object_image_file_get(const Evas_Object *obj, const char **file, const char **key) 871 void evas_object_image_file_get(const Evas_Object *obj, const char **file, const char **key)
872 void evas_object_image_border_set(Evas_Object *obj, int l, int r, int t, int b) 872 void evas_object_image_border_set(Evas_Object *obj, int l, int r, int t, int b)
@@ -1051,7 +1051,7 @@ cdef extern from "Evas.h":
1051 # 1051 #
1052 Evas_Object *evas_object_box_add(Evas *e) 1052 Evas_Object *evas_object_box_add(Evas *e)
1053 Evas_Object *evas_object_box_add_to(Evas_Object *parent) 1053 Evas_Object *evas_object_box_add_to(Evas_Object *parent)
1054 # FIXME: Is this needed?: const Eo_Class *evas_object_box_class_get() 1054 # TODO: Is this needed?: const Eo_Class *evas_object_box_class_get()
1055 1055
1056 void evas_object_box_align_set(Evas_Object *o, double horizontal, double vertical) 1056 void evas_object_box_align_set(Evas_Object *o, double horizontal, double vertical)
1057 void evas_object_box_align_get(const Evas_Object *o, double *horizontal, double *vertical) 1057 void evas_object_box_align_get(const Evas_Object *o, double *horizontal, double *vertical)
@@ -1174,8 +1174,8 @@ cdef extern from "Evas.h":
1174 Eina_Bool evas_object_table_unpack(Evas_Object *o, Evas_Object *child) 1174 Eina_Bool evas_object_table_unpack(Evas_Object *o, Evas_Object *child)
1175 void evas_object_table_clear(Evas_Object *o, Eina_Bool clear) 1175 void evas_object_table_clear(Evas_Object *o, Eina_Bool clear)
1176 void evas_object_table_col_row_size_get(const Evas_Object *o, int *cols, int *rows) 1176 void evas_object_table_col_row_size_get(const Evas_Object *o, int *cols, int *rows)
1177 # FIXME: Not needed?: Eina_Iterator *evas_object_table_iterator_new(const Evas_Object *o) 1177 # TODO: Not needed?: Eina_Iterator *evas_object_table_iterator_new(const Evas_Object *o)
1178 # FIXME: Not needed?: Eina_Accessor *evas_object_table_accessor_new(const Evas_Object *o) 1178 # TODO: Not needed?: Eina_Accessor *evas_object_table_accessor_new(const Evas_Object *o)
1179 Eina_List *evas_object_table_children_get(const Evas_Object *o) 1179 Eina_List *evas_object_table_children_get(const Evas_Object *o)
1180 Evas_Object *evas_object_table_child_get(const Evas_Object *o, unsigned short col, unsigned short row) 1180 Evas_Object *evas_object_table_child_get(const Evas_Object *o, unsigned short col, unsigned short row)
1181 1181
@@ -1192,8 +1192,8 @@ cdef extern from "Evas.h":
1192 Eina_Bool evas_object_grid_unpack(Evas_Object *o, Evas_Object *child) 1192 Eina_Bool evas_object_grid_unpack(Evas_Object *o, Evas_Object *child)
1193 void evas_object_grid_clear(Evas_Object *o, Eina_Bool clear) 1193 void evas_object_grid_clear(Evas_Object *o, Eina_Bool clear)
1194 Eina_Bool evas_object_grid_pack_get(const Evas_Object *o, Evas_Object *child, int *x, int *y, int *w, int *h) 1194 Eina_Bool evas_object_grid_pack_get(const Evas_Object *o, Evas_Object *child, int *x, int *y, int *w, int *h)
1195 # FIXME: Is this needed? Eina_Iterator *evas_object_grid_iterator_new(const Evas_Object *o) 1195 # TODO: Is this needed? Eina_Iterator *evas_object_grid_iterator_new(const Evas_Object *o)
1196 # FIXME: Is this needed? Eina_Accessor *evas_object_grid_accessor_new(const Evas_Object *o) 1196 # TODO: Is this needed? Eina_Accessor *evas_object_grid_accessor_new(const Evas_Object *o)
1197 Eina_List *evas_object_grid_children_get(const Evas_Object *o) 1197 Eina_List *evas_object_grid_children_get(const Evas_Object *o)
1198 1198
1199 1199