borisfaure
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ecore_audio: remove pure virtual functions from classes 

Summary:
A call to a undefined function results in a NOP we can get the same
behaviour with @empty. In Ecore.Audio this pure_virtual function makes
sense, so make the class abstract.

ref T7632

Reviewers: cedric, segfaultxavi, zmike, q66

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7632

Differential Revision: https://phab.enlightenment.org/D7669
This commit is contained in:
Marcel Hollerbach 2019-01-17 17:14:19 +01:00 committed by Daniel Kolesa
parent 0b7b80919d
commit 48b43928bb
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/ecore_audio/ecore_audio.eo
View File

@ -12,7 +12,7 @@ enum Ecore.Audio.Format {
last [[Sentinel value to indicate last enum field during iteration]]
}
class Ecore.Audio (Efl.Object)
abstract Ecore.Audio (Efl.Object)
{
[[Convenience audio class.]]

9
src/lib/ecore_audio/ecore_audio_in.eo
View File

@ -44,7 +44,7 @@ class Ecore.Audio.In (Ecore.Audio)
channels: int; [[The number of channels]]
}
}
@property preloaded @pure_virtual {
@property preloaded {
[[Preloaded state of the input
@since 1.8
@ -82,7 +82,7 @@ class Ecore.Audio.In (Ecore.Audio)
@since 1.8
]]
set @pure_virtual {
set {
}
get {
}
@ -134,7 +134,7 @@ class Ecore.Audio.In (Ecore.Audio)
@in len: size; [[The amount of samples to read]]
}
}
seek @pure_virtual {
seek {
[[Seeks within the input
@since 1.8
@ -153,6 +153,9 @@ class Ecore.Audio.In (Ecore.Audio)
Efl.Object.constructor;
Efl.Object.destructor;
Ecore.Audio.vio_set;
@empty .length {set;}
@empty .preloaded {set; get;}
@empty .seek;
}
events {
in,looped: void; [[Called when an input has looped.]]