forked from enlightenment/efl
elm_atspi_bridge: fix bugs reported by coverity
Make sure we free allocated resources in the error path. Prevent usage of uninitilized value. Signed-off-by: Bartlomiej Grzelewski <b.grzelewski@samsung.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11607
This commit is contained in:
parent
3feacb2b66
commit
692d697cc3
|
@ -1365,11 +1365,12 @@ _text_string_at_offset_get(const Eldbus_Service_Interface *iface, const Eldbus_M
|
||||||
str = str ? str : strdup("");
|
str = str ? str : strdup("");
|
||||||
|
|
||||||
ret = eldbus_message_method_return_new(msg);
|
ret = eldbus_message_method_return_new(msg);
|
||||||
EINA_SAFETY_ON_NULL_RETURN_VAL(ret, NULL);
|
EINA_SAFETY_ON_NULL_GOTO(ret, cleanup);
|
||||||
|
|
||||||
eldbus_message_arguments_append(ret, "sii", str, start, end);
|
eldbus_message_arguments_append(ret, "sii", str, start, end);
|
||||||
free(str);
|
|
||||||
|
|
||||||
|
cleanup:
|
||||||
|
free(str);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1409,11 +1410,12 @@ _text_text_get(const Eldbus_Service_Interface *iface, const Eldbus_Message *msg)
|
||||||
str = str ? str : strdup("");
|
str = str ? str : strdup("");
|
||||||
|
|
||||||
Eldbus_Message *ret = eldbus_message_method_return_new(msg);
|
Eldbus_Message *ret = eldbus_message_method_return_new(msg);
|
||||||
EINA_SAFETY_ON_NULL_RETURN_VAL(ret, NULL);
|
EINA_SAFETY_ON_NULL_GOTO(ret, cleanup);
|
||||||
|
|
||||||
eldbus_message_arguments_append(ret, "s", str);
|
eldbus_message_arguments_append(ret, "s", str);
|
||||||
|
|
||||||
|
cleanup:
|
||||||
free(str);
|
free(str);
|
||||||
|
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1570,9 +1572,10 @@ _text_attribute_value_get(const Eldbus_Service_Interface *iface, const Eldbus_Me
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = eldbus_message_method_return_new(msg);
|
ret = eldbus_message_method_return_new(msg);
|
||||||
EINA_SAFETY_ON_NULL_RETURN_VAL(ret, NULL);
|
EINA_SAFETY_ON_NULL_GOTO(ret, cleanup);
|
||||||
eldbus_message_arguments_append(ret, "siib", value ? value : "", start, end, res);
|
eldbus_message_arguments_append(ret, "siib", value ? value : "", start, end, res);
|
||||||
|
|
||||||
|
cleanup:
|
||||||
free(value);
|
free(value);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue