borisfaure
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ecore_x: No need to free NULL value. 

NB: This reintroduces the Coverity Resouce Leak detected with CID1039276

Summary:
When ecore_x_window_prop_property_get returns 0, data is already NULL hence
no need to free NULL value. This fault was introduced in 45a2296218
while fixing coverity defects.

Reviewers: seoz, cedric, raster, devilhorns

Subscribers: cedric, seoz

Differential Revision: https://phab.enlightenment.org/D1473
This commit is contained in:
Amitesh Singh 2014-09-22 13:42:36 -04:00 committed by Chris Michael
parent c51dbe3a2c
commit 7a02b10573
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/ecore_x/xlib/ecore_x_dnd.c
View File

@ -230,10 +230,7 @@ ecore_x_dnd_type_isset(Ecore_X_Window win,
LOGFN(__FILE__, __LINE__, __FUNCTION__);
if (!ecore_x_window_prop_property_get(win, ECORE_X_ATOM_XDND_TYPE_LIST,
XA_ATOM, 32, &data, &num))
{
if (data) free(data);
return ret;
}
return ret;
atom = ecore_x_atom_get(type);
atoms = (Ecore_X_Atom *)data;