borisfaure
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

evas_outbuf: Fix memory leak. 

Summary: In certain use cases, when image data is created twice, the existing memory pointer is isolated and a memory leak occurs.

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8813

Differential Revision: https://phab.enlightenment.org/D12148
This commit is contained in:
Woochanlee 2020-09-17 17:23:41 +09:00 committed by Hermet Park
parent ca2900be8a
commit 875f05cef5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/modules/evas/engines/buffer/evas_outbuf.c
View File

@ -45,8 +45,9 @@ evas_buffer_outbuf_buf_update_fb(Outbuf *buf, int w, int h, Outbuf_Depth depth,
if ((buf->depth == OUTBUF_DEPTH_ARGB_32BPP_8888_8888) &&
(buf->dest) && (buf->dest_row_bytes == (buf->w * sizeof(DATA32))))
{
memset(buf->dest, 0, h * buf->dest_row_bytes);
buf->priv.back_buf =
memset(buf->dest, 0, h * buf->dest_row_bytes);
if (buf->priv.back_buf) evas_cache_image_drop(&buf->priv.back_buf->cache_entry);
buf->priv.back_buf =
(RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(),
w, h, buf->dest,
1, EVAS_COLORSPACE_ARGB8888);
@ -54,6 +55,7 @@ evas_buffer_outbuf_buf_update_fb(Outbuf *buf, int w, int h, Outbuf_Depth depth,
else if ((buf->depth == OUTBUF_DEPTH_RGB_32BPP_888_8888) &&
(buf->dest) && (buf->dest_row_bytes == (buf->w * sizeof(DATA32))))
{
if (buf->priv.back_buf) evas_cache_image_drop(&buf->priv.back_buf->cache_entry);
buf->priv.back_buf =
(RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(),
w, h, buf->dest,