From ca2e2af52212bd28114b31b5abf049a2faf8f3fc Mon Sep 17 00:00:00 2001 From: Cedric BAIL Date: Wed, 30 Jul 2014 03:47:31 +0200 Subject: [PATCH] ecore_evas_extn: do not double close fd in case of memory starvation. In case eina_stringshare_add was failing it could lead to a double close on lockfd. This was reported by coverity: CID1039885 @fix --- src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c b/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c index 017cf33f72..31f83dce5b 100644 --- a/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c +++ b/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c @@ -158,6 +158,7 @@ _extnbuf_lock_file_set(Extnbuf *b, const char *file) if (b->am_owner) return EINA_FALSE; if (b->lock) eina_stringshare_del(b->lock); if (b->lockfd >= 0) close(b->lockfd); + b->lockfd = -1; if (!file) { b->lock = NULL;