From 37f13a9d10e1b94c5d34ead61d316f434f7688de Mon Sep 17 00:00:00 2001 From: Hosang Kim Date: Fri, 25 May 2018 10:04:49 -0700 Subject: [PATCH] elm_interface_scrollable: change return value for post events. Summary: 1. Scroller in scroller case, callback process should continue. If child scroller does not scroll, parent scroller should be checked whether scroll or not. So returning EINA_TRUE is necessary. 2. down.dragged flag is always EINA_FALSE, so scroll is never unlocked. @fix Test Plan: precondition elementary_config -> scrolling -> Set Scroll Smooth Amount to 0 elementary_test -> pagescroller Reviewers: woohyun, zmike, singh.amitesh, cedric Reviewed By: cedric Subscribers: #committers, cedric, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6187 Reviewed-by: Cedric BAIL --- src/lib/elementary/elm_interface_scrollable.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/lib/elementary/elm_interface_scrollable.c b/src/lib/elementary/elm_interface_scrollable.c index e99db959cf..b7ffad275c 100644 --- a/src/lib/elementary/elm_interface_scrollable.c +++ b/src/lib/elementary/elm_interface_scrollable.c @@ -2209,10 +2209,9 @@ _elm_scroll_post_event_up(void *data, if (sid->obj) { - if (sid->down.dragged) - elm_widget_scroll_lock_set(sid->obj, EFL_UI_SCROLL_BLOCK_NONE); + elm_widget_scroll_lock_set(sid->obj, EFL_UI_SCROLL_BLOCK_NONE); } - return EINA_FALSE; + return EINA_TRUE; } static Eina_Bool @@ -3096,7 +3095,7 @@ _elm_scroll_post_event_move(void *data, } if (start) _elm_scroll_drag_start(sid); - return EINA_FALSE; + return EINA_TRUE; } static void