forked from enlightenment/efl
edje: epp - fix build of edje file in cas of recursive includes.
Amitesh Singh fixed this issue with Commite66e132d9d
, but this commit has been reverted recently, by a commit freeing ressources (6d0b834a76
). It's clear that we are leaking here if we remove the free, but there is also a valgrind error when this memory is freed. After trying to debug and understand the code of epp, i can only propose to remove this free, we will need to include a lot of files before this memory leak could be visible. It is also not a real problem, the memory leak only concern the file name passed in the include directive and epp is started per file anyway. It is unlikely to create any real life problem and we better spend our time on more pressing matter. Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
parent
8802ce2051
commit
71dd24a481
|
@ -3538,7 +3538,11 @@ do_include(cpp_reader * pfile, struct directive *keyword,
|
||||||
if (angle_brackets)
|
if (angle_brackets)
|
||||||
pfile->system_include_depth--;
|
pfile->system_include_depth--;
|
||||||
}
|
}
|
||||||
free(fname);
|
|
||||||
|
// We are leaking fname here. This is intended as it may still be used later
|
||||||
|
// on. It would be better on to track that correctly and fix it, but as it
|
||||||
|
// only affect recursive include this leak is not important and time will be
|
||||||
|
// better spent somewhere else.
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue