From 728d4dba16bd079ded043bc4b61f464bc7ad48b0 Mon Sep 17 00:00:00 2001 From: Wonki Kim Date: Mon, 12 Oct 2020 02:32:10 +0000 Subject: [PATCH] slider: fix a potentional crashing problem null pointer dereferencing could happen once eina_value_setup fails. this patch fixes the problem in adavnace Reviewed-by: Christopher Michael Differential Revision: https://phab.enlightenment.org/D12173 --- src/lib/elementary/elm_slider.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/elementary/elm_slider.c b/src/lib/elementary/elm_slider.c index 439711c392..6604c4c2fb 100644 --- a/src/lib/elementary/elm_slider.c +++ b/src/lib/elementary/elm_slider.c @@ -102,7 +102,7 @@ _units_set(Evas_Object *obj) { Eina_Value val; - eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE); + if (!eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE)) return; eina_strbuf_reset(sd->format_strbuf); if (!sd->intvl_enable) @@ -147,7 +147,7 @@ _indicator_set(Evas_Object *obj) if (!sd->indi_format_cb) return; - eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE); + if (!eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE)) return; eina_strbuf_reset(sd->indi_format_strbuf); eina_value_set(&val, sd->val); @@ -180,7 +180,7 @@ _min_max_set(Evas_Object *obj) Eina_Value val; if (!sd->format_cb) return; - eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE); + if (!eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE)) return; str = eina_strbuf_new();