From 831d17a8e83f8b082a9683e6098dfbc3410436cb Mon Sep 17 00:00:00 2001 From: Sebastian Dransfeld Date: Sat, 7 Dec 2013 15:31:46 +0100 Subject: [PATCH] eldbus: unref msg on error If we return here, the msg isn't sent, so unref it. Fixes CID 1039178 --- src/lib/eldbus/eldbus_service.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lib/eldbus/eldbus_service.c b/src/lib/eldbus/eldbus_service.c index 693cdf3361..bb300c0865 100644 --- a/src/lib/eldbus/eldbus_service.c +++ b/src/lib/eldbus/eldbus_service.c @@ -1380,7 +1380,11 @@ eldbus_service_signal_emit(const Eldbus_Service_Interface *iface, unsigned int s va_start(ap, signal_id); r = eldbus_message_arguments_vappend(sig, signature, ap); va_end(ap); - EINA_SAFETY_ON_FALSE_RETURN_VAL(r, EINA_FALSE); + if (!r) + { + eldbus_message_unref(sig); + return EINA_FALSE; + } eldbus_service_signal_send(iface, sig); return EINA_TRUE;