bu5hm4n
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

efl_ui_win: Fix dereference null return 

Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check before trying
to use 'sd'.

Fixes Coverity CID1399426

@fix

Depends on D8347

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8348
This commit is contained in:
Christopher Michael 2019-03-15 08:57:54 -04:00
parent 0f1f5dabf3
commit 94405eca3b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/elementary/efl_ui_win.c
View File

@ -8886,6 +8886,7 @@ elm_win_keygrab_unset(Elm_Win *obj, const char *key,
Eina_Bool ret = EINA_FALSE;
#ifdef HAVE_ELEMENTARY_X
Efl_Ui_Win_Data *sd = efl_data_scope_safe_get(obj, MY_CLASS);
EINA_SAFETY_ON_NULL_RETURN_VAL(sd, EINA_FALSE);
_internal_elm_win_xwindow_get(sd);
if (sd->x.xwin)
ret = ecore_x_window_keygrab_unset(sd->x.xwin, key, 0, 0);