From b2b81f2cd49b65d9567e4bfe27fb173f8216d7bc Mon Sep 17 00:00:00 2001 From: Seunghun Lee Date: Fri, 21 Nov 2014 09:18:29 -0500 Subject: [PATCH] ecore-drm: fix error check of _device_flags_set function Summary: the function return -1 if it's failed so checking for ! is incorrect. We should check if the return is less than zero. @fix Reviewers: gwanglim, devilhorns Reviewed By: devilhorns Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D1682 --- src/lib/ecore_drm/ecore_drm_inputs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore_drm/ecore_drm_inputs.c b/src/lib/ecore_drm/ecore_drm_inputs.c index 98ca4262f3..9a1dcdf07b 100644 --- a/src/lib/ecore_drm/ecore_drm_inputs.c +++ b/src/lib/ecore_drm/ecore_drm_inputs.c @@ -97,7 +97,7 @@ _cb_device_opened(void *data, const Eldbus_Message *msg, Eldbus_Pending *pending goto cleanup; } - if (!(fd = _device_flags_set(fd))) + if ((fd = _device_flags_set(fd)) < 0) { ERR("\tCould not set fd flags"); goto release;