From c5fae98de5c6fdf5b0689515cfb13e522f33c144 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 25 May 2018 10:09:46 -0700 Subject: [PATCH] elm_notify: remove allow_events_set call in destructor Summary: 4976f1fc5276835940610b72ca4fa48776fc9410 erroneously flipped the bool flag on this call, accidentally creating another object during deletion which is illegal now as the notify object is now unparented at this point which will result in a CRI error this call was never required in the first place as the corresponding layout object would have been deleted automatically due to widget parenting @fix Reviewers: cedric Tags: #efl Differential Revision: https://phab.enlightenment.org/D6147 Reviewed-by: Cedric BAIL --- src/lib/elementary/elm_notify.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/elementary/elm_notify.c b/src/lib/elementary/elm_notify.c index 45c3d89fc1..5441608be2 100644 --- a/src/lib/elementary/elm_notify.c +++ b/src/lib/elementary/elm_notify.c @@ -461,8 +461,6 @@ _elm_notify_efl_canvas_group_group_del(Eo *obj, Elm_Notify_Data *sd) edje_object_signal_callback_del_full (sd->notify, "elm,action,hide,finished", "elm", _hide_finished_cb, obj); elm_notify_parent_set(obj, NULL); - // Allow events set with TRUE will lead to the destruction of sd->block_events. - elm_notify_allow_events_set(obj, EINA_TRUE); ecore_timer_del(sd->timer); ELM_SAFE_FREE(sd->notify, evas_object_del);