From c7d45032dd68048a3c7c3cb74467dd683b86d83b Mon Sep 17 00:00:00 2001 From: Daniel Hirt Date: Sun, 28 Feb 2016 17:33:40 +0200 Subject: [PATCH] Evas textblock: fix cached markup's stringshare refs The last fix 34020ed131c7a5da4d60bb3a452fac0d9ee5fdd1 was missing a stringshare_del for the NOP case of markup_set. It led to a constantly increasing ref count of the cached markup. @fix --- src/lib/evas/canvas/evas_object_textblock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c index 11ff1fe157..158c84b80a 100644 --- a/src/lib/evas/canvas/evas_object_textblock.c +++ b/src/lib/evas/canvas/evas_object_textblock.c @@ -6853,6 +6853,7 @@ _evas_textblock_text_markup_set(Eo *eo_obj EINA_UNUSED, Evas_Textblock_Data *o, text = eina_stringshare_add(text); if (text == o->markup_text) { + eina_stringshare_del(text); /* Text is the same, do nothing. */ return; }