From e6cb461ea69d31e7703fd0ff87ddaee059f994ff Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 29 May 2019 09:30:49 -0400 Subject: [PATCH] elm/genlist: handle cache item deletion without errors Summary: @fix Depends on D8994 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8995 --- src/lib/elementary/elm_genlist.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index 59a77e3b54..9217292132 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -1552,8 +1552,12 @@ _item_cache_free(Item_Cache *itc) if (!itc) return; evas_object_del(itc->spacer); - efl_wref_del(itc->base_view, &itc->base_view); - efl_del(itc->base_view); + /* does not exist if cache item has just been reused */ + if (itc->base_view) + { + efl_wref_del(itc->base_view, &itc->base_view); + efl_del(itc->base_view); + } itc->item_class = NULL; EINA_LIST_FREE(itc->contents, c) {