From f9f9b48c6449945dd55b3a0b8a2b95c0a9c18c74 Mon Sep 17 00:00:00 2001 From: Vincent Torri Date: Sat, 20 Feb 2010 09:35:48 +0000 Subject: [PATCH] On Windows, ecore_exe_auto_limits_set() does nothing SVN revision: 46331 --- legacy/ecore/src/lib/ecore/ecore_exe.c | 3 ++- legacy/ecore/src/lib/ecore/ecore_exe_win32.c | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/legacy/ecore/src/lib/ecore/ecore_exe.c b/legacy/ecore/src/lib/ecore/ecore_exe.c index 556e0319f5..79f62ac6e1 100644 --- a/legacy/ecore/src/lib/ecore/ecore_exe.c +++ b/legacy/ecore/src/lib/ecore/ecore_exe.c @@ -792,7 +792,8 @@ ecore_exe_close_stdin(Ecore_Exe *exe) } /** - * Sets the auto pipe limits for the given process handle + * Sets the auto pipe limits for the given process handle. On Windows + * this function does nothing. * * @param exe The given process handle. * @param start_bytes limit of bytes at start of output to buffer. diff --git a/legacy/ecore/src/lib/ecore/ecore_exe_win32.c b/legacy/ecore/src/lib/ecore/ecore_exe_win32.c index 0b195f7ad7..00a42b8691 100644 --- a/legacy/ecore/src/lib/ecore/ecore_exe_win32.c +++ b/legacy/ecore/src/lib/ecore/ecore_exe_win32.c @@ -6,6 +6,8 @@ * TODO: * - manage I/O pipes (several ones, and stdin) * - manage SetConsoleCtrlHandler ? + * - the child process seems to still run after the DEL event + * - add log messages */ #ifdef HAVE_CONFIG_H @@ -256,10 +258,8 @@ ecore_exe_pipe_run(const char *exe_cmd, Ecore_Exe_Flags flags, const void *data) if (ResumeThread(exe->thread) == ((DWORD)-1)) goto close_process2; - printf (" * 10\n"); exe->h_close = ecore_main_win32_handler_add(exe->process2, _ecore_exe_close_cb, exe); if (!exe->h_close) goto close_process2; - printf (" * 11\n"); exes = (Ecore_Exe *)eina_inlist_append(EINA_INLIST_GET(exes), EINA_INLIST_GET(exe)); @@ -316,8 +316,9 @@ ecore_exe_close_stdin(Ecore_Exe *exe) exe->close_stdin = 1; } +/* Not used on Windows */ EAPI void -ecore_exe_auto_limits_set(Ecore_Exe *exe, int start_bytes, int end_bytes, int start_lines, int end_lines) +ecore_exe_auto_limits_set(Ecore_Exe *exe __UNUSED__, int start_bytes __UNUSED__, int end_bytes __UNUSED__, int start_lines __UNUSED__, int end_lines __UNUSED__) { }