Commit Graph

2500 Commits

Author SHA1 Message Date
Chris Michael 1d9a19f1ee Check for valid 'send' before trying to call
emotion_gstreamer_buffer_free (which will dereference it).

NB: Fixes Coverity CID1039397

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:34:41 +01:00
Chris Michael c58347b0a5 Check for valid 'send' before trying to call
emotion_gstreamer_buffer_free (which will derefence it).

NB: Fixes Coverity CID1039396

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:33:15 +01:00
Chris Michael 6229a871de When printing this debug message, check for valid extension string get
function First.

NB: Fixes Coverity CID1039394

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:30:41 +01:00
Chris Michael 7bf6ba1f67 Add missing free(data) reported by jeyzu. Thanks ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:22:20 +01:00
Chris Michael 1054d49941 Fix missing unlock reported by Coverity
NB: Fixes Coverity CID1039384

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:20:22 +01:00
Chris Michael 3891bdcb15 Fix missing unlock (reported by Coverity).
- Instead of just returning NULL, use the existing goto on_error to
handle the unlock and return NULL.

NB: Fixes Coverity CID1039383

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:18:06 +01:00
Chris Michael a9d0f3a919 Fix missing FTUNLOCK
Since we locked the font_draw mutex earlier, we should unlock it
before we return.

NB: Fixes Coverity CID1039382

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:15:41 +01:00
Chris Michael a231b7ed26 Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:15:24 +01:00
Chris Michael 1140dbceeb Add missing eina_lock_release when we exit
Since we take the lock at the start of the function, we should release
the mutex lock if we are going to return.

NB: Fixes Coverity CID1039381

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:10:44 +01:00
Chris Michael 6198351629 Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:09:50 +01:00
Chris Michael 5e94e640c6 Fix function and protoype for pointer_xy_get (missing const).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:09:02 +01:00
Chris Michael f880ef9045 Remove erroneous copy/paste of data free
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:04:29 +01:00
Chris Michael c04814023b Add missing functions for pointer_warp and pointer_xy_get to engine
structure.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:02:40 +01:00
Chris Michael 0c66ca7c09 Fix missing return value in pointer warp function.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:02:40 +01:00
Daniel Willmann 76c4140c08 ecore_audio: Add missing break in switch-clause in format_set
Thanks coverity for finding that

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-07-08 13:51:33 +01:00
Chris Michael 970a5badd3 Add missing break in switch
NB: Fixes Coverity CID1039372

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:44:39 +01:00
Chris Michael 7fc497ee6e Fix memleak reported by Coverity:
If we have file And fname, then we can call the source_fetch_file
function, HOWEVER we may only have One or the Other in which case we
still need to potentially free the other.

NB: Fixes Coverity CID1039296

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:13:15 +01:00
Chris Michael 61e17aa5c2 Fix memleak reported by Coverity: Don't leak a strdup.
NB: Fixes Coverity CID1039295

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:11:10 +01:00
Chris Michael 93fc18daf2 Fix leak of fd handle reported by Coverity
NB: Fixes Coverity CID1039288

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:07:18 +01:00
Chris Michael 18a9719003 Fix memleak of Ecore_Thread_Data reported by Coverity
NB: Fixes Coverity CID1039280

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:54:42 +01:00
Chris Michael aedff2dc31 Fix memleaks reported by Coverity: Setting 'buf' to NULL (without
freeing first) leaks the storage that buf Did point to (which could
have been from a realloc above).

NB: Fixes Coverity CID1039277, CID1039278

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:50:38 +01:00
Chris Michael ca318c05fd Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:44:15 +01:00
Chris Michael 45a2296218 Fix memleak reported by Coverity and replace an XFree call
NB: Fixes Coverity CID1039276

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:41:00 +01:00
Chris Michael 0701304205 Fix memleak reported by Coverity and replace some XFree calls with
just free.

NB: Fixes Coverity CID1039275

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:39:48 +01:00
Chris Michael d7600cfbee Fix memleak of window_prop_property_get
NB: Fixes Coverity CID1039274

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:34:28 +01:00
Chris Michael a01ce5e409 Fix memleak of window_prop_property_get
NB: Fixes Coverity CID1039273

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:30:34 +01:00
Chris Michael e33391ef56 Replace XFree with just free.
NB: XFree calls 'free' anyway, so this saves us a function call

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:28:15 +01:00
Chris Michael d7193f2830 Fix memleak reported by Coverity
NB: Fixes Coverity CID1039272

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:27:40 +01:00
Chris Michael 0d12ab48be Fix memleak spotted by Coverity: ecore_x_window_prop_property_get can
allocate space for 'data'. If we return before using it, then free
'data'. If we use it later for XGetAtomName, then we can free if After
we have gotten the atom names and sent the event. (NB: XGetAtomName
will allocate it's own space for the returned name, so this is safe).

NB: Fixes Coverity CID1039271

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:24:21 +01:00
Chris Michael 5969c97f7a Fix memleaks reported by Coverity: ecore_x_window_prop_property_get
allocates space for 'data'. We need to free that if we are going to
return before using it.

NB: Fixes Coverity CID1039270

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:17:58 +01:00
Chris Michael aea9e86eb4 Fix several memleaks reported by Coverity
NB: Fixes Coverity CID1039268

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:12:48 +01:00
Chris Michael 4ea1ea5bf4 Fix memleak spotted by Coverity
NB: Fixes Coverity CID1039267

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:58:15 +01:00
Chris Michael 02f545ecc6 Fix memleak. If we error out here, then we should free the data
returned from window_prop_property_get (as that does an allocation).

NB: Fixes Coverity CID1039266

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:47:13 +01:00
Chris Michael e6088e2361 Fix memleak reported by Coverity: If we are going to error out when
getting window netwm types, then free any atoms returned by
prop_atom_list_get.

NB: Fixes Coverity CID1039265

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:44:23 +01:00
Chris Michael e28f298dbd Fix memleak reported by Coverity: If we error out because we have a
hash with no key, then free the previously allocated data_stream.

NB: Fixes Coverity CID1039262

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:34:58 +01:00
Chris Michael b72e694573 Fix memleak reported by Coverity
NB: Fixes Coverity CID1039261

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:31:17 +01:00
Chris Michael 57924e5824 Fix memleak reported by Coverity: Close the descriptor returned by
popen if we are going to error out.

NB: Fixes Coverity CID1039184

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:25:59 +01:00
Chris Michael aeb4b7f7b9 Fix memleak reported by Coverity: If we fail to allocate a new
internal menu, then free the previously allocated memory for xml file.

NB: Fixed Coverity CID 1039183

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:19:37 +01:00
Chris Michael c04cfde0e5 Fix mem leak reported by Coverity: If we fail to create a new internal
menu, then free the previously allocated xml file.

NB: Fixes Coverity CID 1039182

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:17:13 +01:00
Chris Michael 2aa12782b6 If we open a file for copying, then we should also Close that file
when the copy is done.

NB: Fixes Coverity CID1039181

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:13:56 +01:00
Chris Michael a8bb3ec5ce Add common wayland function to get the pointer xy from wayland
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:02:58 +01:00
Chris Michael 4d2de522fa Add pointer_xy_get function to engine functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:00:28 +01:00
Chris Michael f0e47a2219 Add pointer_xy_get function to engine functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:59:20 +01:00
Chris Michael fca4267ae4 Add functions to X engine for ecore_evas_pointer_xy_get and
ecore_evas_pointer_warp

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:57:00 +01:00
Chris Michael 362d89e05c Add ecore_evas_pointer_xy_get and ecore_evas_pointer_warp functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:56:02 +01:00
Chris Michael 5e988cc8cf Add pointer_xy_get and pointer_warp to engine functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:52:34 +01:00
Chris Michael 5c223328d4 Add ecore_evas_pointer_xy_get and ecore_evas_pointer_warp API functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:51:23 +01:00
Chris Michael 6ea61e3e56 Fix formating ... Wow, how did this get sooo screwed ? :(
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:16:09 +01:00
Chris Michael 5f71c0afb1 Begone Vile Formatting !!!
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:01:38 +01:00
Chris Michael 6900d83095 Remove blank line
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:53:04 +01:00
Chris Michael 9103b7e2e3 Check the return of ecore_x_init and error out if that fails.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:21:33 +01:00
Jean-Philippe Andre ee037d3586 evas/cserve2: Add infix to shm filenames
Minor change
So, we can distinguish between image, font and index shm files.
2013-07-08 17:16:04 +09:00
Carsten Haitzler 9e459ef9d6 fix new ecore_x_pixmap typedef clashes in ecore_x 2013-07-08 17:15:11 +09:00
Mike Blumenkrantz b8e16b8f4a +eina_tiler_area_size_get
also fix docs for eina_tiler_area_size_set
2013-07-08 09:08:04 +01:00
Chris Michael 2a1b993162 Fix "Allocation size mismatch" reported by Coverity (short version: we
declared our 'roots' variable as Ecore_X_Window, but were allocating
as 'Window').

buffer_alloc: "malloc(num * 8UL)" allocates memory.
CID 1039601: Allocation size mismatch (SIZECHECK)
5. incorrect_multiplication: Allocating a multiple of 8 bytes to
pointer of type Ecore_X_Window, which needs 4 bytes.

NB: Fixes Coverity CID1039601

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:00:45 +01:00
Chris Michael 9fb63c761f Fix "Allocation too small" errors reported by Coverity. (Basically, if
we are going to allocate space for a variable of a certain type, then
lets make sure we Declare that variable as the proper type).

NB: Fixes Coverity CIDs 1039602, 1039603, 1039604

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:52:50 +01:00
Chris Michael 6011703bf5 Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:50:45 +01:00
Chris Michael 461e406b91 Fix memleak reported by Coverity.
NB: Fixes Coverity CID1039652

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:43:24 +01:00
Chris Michael 1ea718c283 Fix memleak reported by Coverity.
NB: Fixes Coverity CID1039654

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:38:54 +01:00
Chris Michael eabc1482f9 Fix memleak reported by Coverity.
NB: Fixes Coverity CID1039657

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:35:33 +01:00
Chris Michael 4e103fd858 Fix mem leak reported by Coverity (don't just free fdata if size > 0).
NB: Fixes Coverity CID1039665

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:30:26 +01:00
Chris Michael 72347e539b Fix copy/paste error in gl_common_context_push. (I beleive that texm
texture was wanted here, not tex texture).

MB: Fixes Coverity 1039670

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:26:08 +01:00
Chris Michael ff60a233d2 Fix unintended operator precedence... I do believe != 4 is what was
wanted here...Or (!(ob->map->cur.map->count == 4)) ... but not much
difference either way ;)

NB: Fixes Coverity CID1039673

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:22:23 +01:00
Chris Michael 8280ef3730 Remove the grab from any lists Before we free it.
NB: Fixes Coverity CID 1039888

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:08:10 +01:00
Jean-Philippe Andre c6db8ba782 evas/cserve2: Implement fast(er) scaling of images
In its current model, cserve2 will reopen, reload and scale an
image whenever a new scaled version is requested by the client.

Instead, we can load the original image when too many scaled
versions are requested, and place the original in the LRU.
2013-07-08 16:06:08 +09:00
Jean-Philippe Andre cf61319ae1 evas/cserve2: Minor fixes from Coverity check
- CID 1042303
- CID 1039912
- CID 1039285
2013-07-08 16:06:08 +09:00
Jean-Philippe Andre 8b257d0238 evas/cserve2: fix error parameter usage
The error pointer could be NULL but still dereferenced in case of
failure. Also, it wasn't reset in case of success.
2013-07-08 16:06:08 +09:00
Chris Michael bb30cd58ce We cannot use dname in the error message if we have already freed it
above, so fix. On a mkpath failure, print out the message, Then free
dname. Be sure to also free dname if we do not error.

NB: Fixes Coverity CID1039893

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:01:58 +01:00
Chris Michael b0fa8b6563 Remove timer and animator from the list Before freeing the variables.
NB: Fixes Coverity CID1039906 and CID1039906

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:50:35 +01:00
Chris Michael 10897713ea Remove dead code. In the error goto, im2 cannot exist here else we
would not have gotten to this error handler if it did (so no point in
checking for it and calling functions using it).

NB: Fixes Coverity CID1039926

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:39:44 +01:00
Chris Michael 9d60d6ccff Check return value of lseek call for errors.
NB: Fixes Coverity CID 1040029

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:31:50 +01:00
Chris Michael 73a68f2f0d Add code for gl_pixmap_new and pixmap_get functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:21:51 +01:00
Chris Michael 583c81bd96 Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:21:51 +01:00
Chris Michael babc9c64b7 Add gl functions for pixmap_new and pixmap_get variation
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:21:51 +01:00
Carsten Haitzler d15d86e26f eina: add eina_file_map_populate() 2013-07-06 22:01:23 +09:00
Carsten Haitzler 28c2bd1918 evas - gif: refactor a lot of the gif animated loader code to be much cleaner. 2013-07-06 15:12:36 +09:00
José Roberto de Souza 8f69b20a6d eldbus: Remove unnecessary function - _eldbus_connection_unref()
Neither internal function call this function.
2013-07-05 16:08:06 -03:00
José Roberto de Souza 20d9e486a8 eldbus: Handle removal of last reference of connection inside of callback 2013-07-05 16:08:01 -03:00
maxerba a64e0c0573 Fixed sorting in desktop files 2013-07-05 19:00:52 +02:00
Ryuan Choi 8d41667412 edje_cc: Fixed possible leak when description.map.color defines same idx more than one time
Spotted by coverity. CID 1039298.
2013-07-06 01:30:54 +09:00
Carsten Haitzler fab94cb3ea evas - fix gif animatd loader segv just inroduced. 2013-07-05 23:11:51 +09:00
Chris Michael 7431e6a02a Check for valid ee->prop.window before trying to fetch window
attributes from it.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-05 11:09:25 +01:00
Chris Michael 2c322cc7b1 Add code for ecore_evas_<engine>_pixmap_new/get functions.
- Add "pixmap" structure to engine_data.
    - Free the front and back pixmaps when the ecore_evas gets freed.
    - On resize, drop the backing pixmap if size is different.
    - Before we render, check pixmap size vs EE size and create new
backing pixmap if needed.
    - After we have rendered into the backing pixmap, flip it to the
front so that any calls to "pixmap_get" will return the proper one.
    - Add pixmap_new_internal code (the actual guts for all this)

NB: These can be used to create an internally double-buffered
ecore_evas that renders to a pixmap (not a window).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-05 10:44:18 +01:00
Chris Michael 159232b593 Add code for ecore_evas_software_x11_pixmap_new/get functions.
Fix formatting in ecore_evas_window_get.

  NB: This will be used to create an ecore_evas that Renders to a
      Pixmap (not a window). As such, Some ecore_evas functions may
      not operate as expected when using this type of ecore_evas.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-05 10:44:18 +01:00
Chris Michael 1e8f6d3b45 Add interface function pointers for pixmap_get.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-05 10:44:18 +01:00
Chris Michael a2a2a1c8a2 Add typedef for Ecore_X_Pixmap if Ecore_X header is not included.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-05 10:44:18 +01:00
Chris Michael 25241a5138 Add API function declarations for ecore_evas (software and gl) that
can "render to pixmap".

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-05 10:44:18 +01:00
Cedric Bail 913d56da9e evas: make it possible to disable preload for buggy driver. 2013-07-05 15:39:44 +09:00
Cedric Bail 0453cd16b4 eina: revert that simplification as compiler are now to dumb to handle it. 2013-07-05 14:59:43 +09:00
ChunEon Park 64f984bd1a evas/render - draw the map in case that the source clip is invalid. 2013-07-05 12:53:09 +09:00
Cedric Bail 2efcd3bb19 evas: fix gif loader accessing uninitialized value. 2013-07-05 11:35:06 +09:00
ChunEon Park 307e2f823d evas/render - support proxy source clip for the mapped object. 2013-07-05 11:14:47 +09:00
ChunEon Park 04f87ab237 evas/render - refactoring. split off a bunch of internal logic to a seprate function. 2013-07-05 11:09:03 +09:00
Cedric Bail df7b19090a edje: simplify the logic and make code easier to read. 2013-07-05 10:18:49 +09:00
Cedric Bail cb5dbb55c3 eo: reporting error here just make the caller code more complex for nothing valuable. 2013-07-05 10:18:19 +09:00
Eduardo Lima (Etrunko) 27b7ab457e Updated Eldbus connect_address example
See description on the header of the source file

Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>
2013-07-04 17:23:52 -03:00
Tom Hacohen 5d4ff97e20 Evas textblock: Fixed issue with *textblock_cursor_range_formats_get.
In some cases we could return extra formats that are outside of the
range. It's actually not completely fixed yet.

Thanks to clang-analyzer for detecting this.
2013-07-04 10:07:52 +01:00
Jean-Philippe Andre 09a5c28e5b evas/cserve2: no cache for large images or non-smooth
The concept is taken from scalecache. I am not sure of the
performance impact.
2013-07-04 13:02:48 +09:00
Jean-Philippe Andre 7c7c231015 evas/cserve2: simplify more
Remove Image_Load_Opts and use Evas_Image_Load_Opts for cs2 master to
slave communication.
2 things to note:
- The struct size is bigger (but at the same time we removed a memcpy)
- The scale_load field is not passed to the slave
2013-07-04 13:02:48 +09:00
Jean-Philippe Andre 46b7baa379 evas/cserve2: merge SETOPTS into OPEN
When opening an image, OPEN and SETOPTS were always sent
consecutively. Merging these two messages may improve the
performance a bit (not measured), but also simplify the
whole thing.

Note: cserve2 debug tools have not been fixed yet.
2013-07-04 13:02:48 +09:00
Jean-Philippe Andre ca5d174568 evas/cserve2: use Evas_Image_Load_Opts directly
Image_Data contained a similar struct to the standard Evas struct,
let's not duplicate it uselessly.
2013-07-04 13:02:48 +09:00
Cedric Bail f825bebcdb eina: improve Eina_Tiler to be in par with Evas_Tilebuf. 2013-07-04 13:02:48 +09:00
Cedric Bail a865b77c14 eo: another small micro optimization giving a 10% speed increase. 2013-07-04 13:02:28 +09:00
Carsten Haitzler bf482c7742 eldbus - better fix for dbus_conn becoming null in dispatch 2013-07-04 10:56:43 +09:00
Carsten Haitzler bdd57af113 eldbus - only unref client conns that are not null after dispatch 2013-07-04 08:41:45 +09:00
Carsten Haitzler 64f8ea918c ethumbd - set default timeout for ethumbd to 2 seconds 2013-07-04 08:40:35 +09:00
Chris Michael 8fc3c9c8bc Revert "EFL formatting and 80 column wrap"
Revert this because I have better things to do than argue about commit
messages.

This reverts commit ee5483bee1.
2013-07-03 14:30:40 +01:00
Chris Michael ee5483bee1 EFL formatting and 80 column wrap
NB: Nothing functional (yet)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-03 13:54:35 +01:00
Shinwoo Kim daca686168 [ecore_x] add accessibility support - enable, disable 2013-07-03 13:13:32 +09:00
Cedric Bail 0f153be0e5 evas: fix bugin Enlightenment triggering a path where data are loaded, but flags is not set.
This fix T187.
2013-07-03 12:48:38 +09:00
Carsten Haitzler 22ad827274 evas gl: fix origin of swapbufferswithdamage to be BOTTOM-LEFT based... 2013-07-03 12:11:18 +09:00
Jean-Philippe Andre 344eae9cbd evas: fix build when png12 is not around. 2013-07-03 10:09:31 +09:00
Jean-Philippe Andre 9bdf55da57 evas: fix build
Build may fail when using parallel compilation (-j)
Add EET as a dependency of cserve slave
2013-07-02 19:00:55 +09:00
Chris Michael 03448524ab Don't try to print out how many bytes we write to an eet file Unless
we actually write something.

NB: Fixes klockwork issue.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-02 09:54:30 +01:00
Chris Michael 292d23321c Check for valid out_file before trying to write eet data to it.
NB: Fixes klockwork issue.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-02 09:53:08 +01:00
Stefan Schmidt ed08c1832c emotion: Another check for engine being NULL.
Missed this second occurance in 8deb75463b.
Now also fixed this potential null pointer dereference when the engine
list is empty.
2013-07-02 09:45:35 +01:00
Chris Michael e2b2918858 Check for valid output_filename before trying to use it.
NB: Fixes klockwork issue.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-02 09:43:23 +01:00
Carsten Haitzler 1f2c19749f in drm_shutdown set tried to false... 2013-07-02 17:26:18 +09:00
Daniel Juyung Seo 311db0fc58 evas_object_smart.c: removed unnecessary code. 2013-07-02 17:07:05 +09:00
Daniel Juyung Seo e3e35bfcaf edje_text.c: proper formatting.
inspired by Daniel Willmann's commit b6aaef651b
2013-07-02 17:07:05 +09:00
Jean-Philippe Andre 67cccea61b evas/cserve2: fix usage of Evas_Image_Load_Opts
Since the load options are not copied but the pointer is simply
stored by the module, we need to move the struct higher in the
stack.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre f1506d8dd2 evas/loaders: use Eina_Stringshare where needed.
Evas loaders' open() function expect the key to be a stringshare,
so declare it as such and keep using ref() without add().

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 687c4aa475 evas/cserve2: use Eina_Stringshare.
We must close the image after loading the data.
Also, Evas loaders expect stringshares.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre bb4e7fb869 evas: fix compilation warning in evas_font_draw.
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 22e79af097 evas/cserve2: return in case of select timeout.
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 79b102f6fd evas/cserve2: add some more error debug (client side).
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 65fcf390b4 evas/loaders: init/shutdown EET from loader module.
cserve2 slave requires Eet to be initialized before use :)

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre a09efda8d2 evas/loaders: add log domain for ICO loader.
This is to remove the dependency of the ico loader on Evas itself.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 8db3d4d2bf evas/cserve2: remove dead code (old loaders API).
Remove: cserve-specific loaders and deprecated code.
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 90d8647c02 evas/cserve2: fix crash with YUV tests in expedite.
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 48d97f7a90 evas/cserve2: use Evas loaders from slave
Use common loaders with evas, and ignore specific modules.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre c39b714868 evas/modules: Add preprocessor ifs
We'll want to distinguish full builds for evas and partial
builds for cserve2 slaves.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 26e01c0ff6 evas: build evas_module within cserve slave
Objective: use common loaders from cserve2

Ideally evas_module should be a static library but it would
then require static/dynamic linking to too many modules unused
by cserve2 (eg. engines & savers)

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre db6cba1429 evas/cserve2: avoid useless SETOPT messages.
Most of the time, the SETOPT message is sent only
to carry 0 data. Let's add a flag to the OPEN message to
avoid useless socket calls.
Server-side: implement with message faking.
Also, fix image ID logic on client side:
 - alloc data entry asap,
 - assign image_id during call to OPEN

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre f9a7820e02 evas/cserve2: Simplify debug logs (server side).
Remove newlines.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 096a8ece9f evas/cserve2: Set default LRU size to 4Mb or env-based
The LRU should not be limited to 0 byte otherwise all scaled
images will be dropped and reloaded constantly, killing the
performance.
The size is inspired from the scalecache's size of 4Mb.

Variable: EVAS_CSERVE2_SIZE (number in Mb)
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 29bf164c75 evas/cserve2: pass loader data during open.
Note: this path seems never to be used.
Loader options are set by the file loader or after open.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre 6a2a0187ff evas/cserve2: write() can return other errors.
In case of error, return from the function and don't decrement
the send variable.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre f7c6545170 evas/cserve2: minor fixes (error paths).
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:10 +09:00
Jean-Philippe Andre d712a13a7a evas/cserve2: use null-terminated strings everywhere.
Some hashtable lookups failed because the keys were added
either with eina_stringshare_add() or e_s_add_lenth() but
looked for with e_s_add_length() only.

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-07-02 16:58:09 +09:00
ChunEon Park 627beaae71 evas/proxy rendering - optimize proxy rendering.
re-render proxies if sources are changed. this patch increases the proxy rendering up to 2x.
2013-07-02 15:38:42 +09:00
ChunEon Park 5f4ae9abeb evas/render - refactoring about checking smart member changed.
move those code to the evas_object_smart.
2013-07-02 15:28:56 +09:00
Cedric Bail 2fdc05863d eet: force thread to always run during eet_cache_concurrency test. 2013-07-02 13:45:30 +09:00
Daniel Willmann b6aaef651b edje_text: Clarify that the block and else are independent
Sometimes whitespace helps

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-07-01 16:04:27 +01:00
Tom Hacohen 827885d794 Evas textblock: Fixed format parsing to not be confused by single-quotes.
Before this commit, having a single quote anywhere in the format would mess
up all of the format parsing.

Thanks to MinSu Seo for reporting.
2013-07-01 14:18:52 +01:00
Cedric Bail cc012b754c eo: little micro optimization. 2013-07-01 18:35:55 +09:00
Cedric Bail c435968f69 eo: a little more inlining, give me a 10% speed improvement. 2013-07-01 18:18:40 +09:00
Jiyoun Park 958a430f5e * Evas: Fix jpeg loader cannot deal with exif information correctly 2013-06-29 15:00:43 +09:00
Daniel Willmann 7927c0f9fa edje_test: Test geometry of a more complex layout
It seems someone thought it was fun to have rel2.offset behave
differently than rel1.offset...
A rel2.offset of 0 actually means the size is increased by one pixel.

Acocunt for that in the tests.

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-06-28 14:25:30 +01:00
Daniel Willmann db29fbb286 edje_test: Make the variable returned in test_layout_get static
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-06-28 14:25:30 +01:00