From 0c34e1bfe278eb092cbd23a1458b0ff00c841582 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Tue, 2 Dec 2014 20:36:19 +0100 Subject: [PATCH] load_gif: Make sure rows isn't used partly unitialized Prevents: ==22831== Conditional jump or move depends on uninitialised value(s) ==22831== at 0x634F040: load (loader_gif.c:181) ==22831== by 0x1F7D7B3: __imlib_LoadImage (image.c:1041) ==22831== by 0x1F090E4: imlib_load_image_with_error_return (api.c:1299) ==22831== by 0x40F47B: feh_load_image (imlib.c:252) ==22831== by 0x42CA0E: winwidget_loadimage (winwidget.c:753) ==22831== by 0x42C918: winwidget_create_from_file (winwidget.c:126) ==22831== by 0x421869: init_slideshow_mode (slideshow.c:62) ==22831== by 0x418F13: main (main.c:78) ==22831== ==22831== Use of uninitialised value of size 8 ==22831== at 0x634F0F4: load (loader_gif.c:190) ==22831== by 0x1F7D7B3: __imlib_LoadImage (image.c:1041) ==22831== by 0x1F090E4: imlib_load_image_with_error_return (api.c:1299) ==22831== by 0x40F47B: feh_load_image (imlib.c:252) ==22831== by 0x42CA0E: winwidget_loadimage (winwidget.c:753) ==22831== by 0x42C918: winwidget_create_from_file (winwidget.c:126) ==22831== by 0x421869: init_slideshow_mode (slideshow.c:62) ==22831== by 0x418F13: main (main.c:78) ==22831== ==22831== Use of uninitialised value of size 8 ==22831== at 0x634F122: load (loader_gif.c:191) ==22831== by 0x1F7D7B3: __imlib_LoadImage (image.c:1041) ==22831== by 0x1F090E4: imlib_load_image_with_error_return (api.c:1299) ==22831== by 0x40F47B: feh_load_image (imlib.c:252) ==22831== by 0x42CA0E: winwidget_loadimage (winwidget.c:753) ==22831== by 0x42C918: winwidget_create_from_file (winwidget.c:126) ==22831== by 0x421869: init_slideshow_mode (slideshow.c:62) ==22831== by 0x418F13: main (main.c:78) ==22831== ==22831== Use of uninitialised value of size 8 ==22831== at 0x634F151: load (loader_gif.c:192) ==22831== by 0x1F7D7B3: __imlib_LoadImage (image.c:1041) ==22831== by 0x1F090E4: imlib_load_image_with_error_return (api.c:1299) ==22831== by 0x40F47B: feh_load_image (imlib.c:252) ==22831== by 0x42CA0E: winwidget_loadimage (winwidget.c:753) ==22831== by 0x42C918: winwidget_create_from_file (winwidget.c:126) ==22831== by 0x421869: init_slideshow_mode (slideshow.c:62) ==22831== by 0x418F13: main (main.c:78) ==22831== when opening id:000001,orig:smaller-animated.gif with feh. --- src/modules/loaders/loader_gif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/loaders/loader_gif.c b/src/modules/loaders/loader_gif.c index 23dfcca..f114d4d 100644 --- a/src/modules/loaders/loader_gif.c +++ b/src/modules/loaders/loader_gif.c @@ -74,7 +74,7 @@ load(ImlibImage * im, ImlibProgressFunction progress, char progress_granularity, for (i = 0; i < h; i++) { - rows[i] = malloc(w * sizeof(GifPixelType)); + rows[i] = calloc(w, sizeof(GifPixelType)); if (!rows[i]) goto quit; }