summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcel Hollerbach <mail@marcel-hollerbach.de>2020-04-17 15:17:52 +0200
committerMarcel Hollerbach <mail@marcel-hollerbach.de>2020-04-19 15:41:22 +0200
commit21fbe2c0c1441b21f0236b177a8a47410814247a (patch)
treea9383807023d96da93c064454942e359d951e3cf
parent1afb26428899cf24da45b73540f711ee27679fdb (diff)
exactness-inspect: remove abscure xor check
this is a obscure check, if this was ever reached, then it would simply crash, because one pointer will be NULL, but strcmp will be called on it. CID 1419854 Differential Revision: https://phab.enlightenment.org/D11722
-rw-r--r--src/bin/exactness/inspect.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/bin/exactness/inspect.c b/src/bin/exactness/inspect.c
index 33bcd23533..af9495f649 100644
--- a/src/bin/exactness/inspect.c
+++ b/src/bin/exactness/inspect.c
@@ -326,13 +326,8 @@ _grp_text_get(void *data, Evas_Object *gl, const char *part EINA_UNUSED)
326 Eo *gl2 = eina_list_nth(_gls, 1); 326 Eo *gl2 = eina_list_nth(_gls, 1);
327 Exactness_Unit *unit1 = efl_key_data_get(gl1, "unit"); 327 Exactness_Unit *unit1 = efl_key_data_get(gl1, "unit");
328 Exactness_Unit *unit2 = efl_key_data_get(gl2, "unit"); 328 Exactness_Unit *unit2 = efl_key_data_get(gl2, "unit");
329 if (!!unit1->fonts_path || !!unit2->fonts_path)
330 sprintf(buf2, "Fonts directory comparison: XXXXX");
331 else if (!strcmp(unit1->fonts_path, unit2->fonts_path))
332 sprintf(buf2, "Fonts directory comparison: %s", unit1->fonts_path);
333 else
334 sprintf(buf2, "Fonts directory comparison: "LDIFF(%s)"/"RDIFF(%s), 329 sprintf(buf2, "Fonts directory comparison: "LDIFF(%s)"/"RDIFF(%s),
335 unit1->fonts_path, unit2->fonts_path); 330 unit1 ? unit1->fonts_path : "(NULL)", unit2 ? unit2->fonts_path : "(NULL)");
336 } 331 }
337 return strdup(buf2); 332 return strdup(buf2);
338 } 333 }