summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWonki Kim <wonki_.kim@samsung.com>2019-07-22 09:08:55 -0400
committerMike Blumenkrantz <zmike@samsung.com>2019-07-22 09:08:55 -0400
commit98b19244329725c76ba601ea66ad5161841a68b9 (patch)
tree3e87fc1beef36e9b9af0501b66b1372043056618
parent28c232d770bf373e674756ff5c6e2824723515b7 (diff)
efl_ui_layout: set needs_size_calc flag at constructor
Summary: even if there is a min definition on theme for some object, the objects don't have the min size if we do nothing after creating it. elm_layout_sizing_eval will return with doing nothing while executing contructor so that _sizing_eval in _layout_group_calculate will never be invoked without calling hint_set, text_set, content_set, etc. this patch modifies a initial state of needs_size_calc flag so that object will doing _sizing_eval after executing constructor. Test Plan: 1. remove lines that call apis such as content_set, hint_set, text_set in radio test on elementary_test 2. observe that radios don't have min size Reviewers: bu5hm4n, Hermet, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9368
-rw-r--r--src/lib/elementary/efl_ui_layout.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/lib/elementary/efl_ui_layout.c b/src/lib/elementary/efl_ui_layout.c
index 1390fc774f..4b4643c72e 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -2445,7 +2445,7 @@ _efl_ui_layout_base_efl_object_constructor(Eo *obj, Efl_Ui_Layout_Data *sd)
2445} 2445}
2446 2446
2447EOLIAN static Efl_Object* 2447EOLIAN static Efl_Object*
2448_efl_ui_layout_base_efl_object_finalize(Eo *obj, Efl_Ui_Layout_Data *pd EINA_UNUSED) 2448_efl_ui_layout_base_efl_object_finalize(Eo *obj, Efl_Ui_Layout_Data *pd)
2449{ 2449{
2450 Eo *eo, *win; 2450 Eo *eo, *win;
2451 ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd, NULL); 2451 ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd, NULL);
@@ -2459,6 +2459,8 @@ _efl_ui_layout_base_efl_object_finalize(Eo *obj, Efl_Ui_Layout_Data *pd EINA_UNU
2459 if (efl_file_get(wd->resize_obj) || efl_file_mmap_get(wd->resize_obj)) 2459 if (efl_file_get(wd->resize_obj) || efl_file_mmap_get(wd->resize_obj))
2460 efl_file_load(wd->resize_obj); 2460 efl_file_load(wd->resize_obj);
2461 2461
2462 pd->needs_size_calc = EINA_TRUE;
2463
2462 return eo; 2464 return eo;
2463} 2465}
2464 2466