summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmitesh Singh <amitesh.sh@samsung.com>2014-09-22 13:42:36 -0400
committerChris Michael <cp.michael@samsung.com>2014-09-22 13:43:10 -0400
commit7a02b1057324cdc8665e0672369d624a4cf2c49a (patch)
treefe6205401f8ce651482291fa02da1d17fe3a0211
parentc51dbe3a2cb2f8fb8745bb8eb05834ba7e90243f (diff)
ecore_x: No need to free NULL value.
NB: This reintroduces the Coverity Resouce Leak detected with CID1039276 Summary: When ecore_x_window_prop_property_get returns 0, data is already NULL hence no need to free NULL value. This fault was introduced in 45a2296218b0f297 while fixing coverity defects. Reviewers: seoz, cedric, raster, devilhorns Subscribers: cedric, seoz Differential Revision: https://phab.enlightenment.org/D1473
-rw-r--r--src/lib/ecore_x/xlib/ecore_x_dnd.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/lib/ecore_x/xlib/ecore_x_dnd.c b/src/lib/ecore_x/xlib/ecore_x_dnd.c
index 8bbbab4..cd2ec14 100644
--- a/src/lib/ecore_x/xlib/ecore_x_dnd.c
+++ b/src/lib/ecore_x/xlib/ecore_x_dnd.c
@@ -230,10 +230,7 @@ ecore_x_dnd_type_isset(Ecore_X_Window win,
230 LOGFN(__FILE__, __LINE__, __FUNCTION__); 230 LOGFN(__FILE__, __LINE__, __FUNCTION__);
231 if (!ecore_x_window_prop_property_get(win, ECORE_X_ATOM_XDND_TYPE_LIST, 231 if (!ecore_x_window_prop_property_get(win, ECORE_X_ATOM_XDND_TYPE_LIST,
232 XA_ATOM, 32, &data, &num)) 232 XA_ATOM, 32, &data, &num))
233 { 233 return ret;
234 if (data) free(data);
235 return ret;
236 }
237 234
238 atom = ecore_x_atom_get(type); 235 atom = ecore_x_atom_get(type);
239 atoms = (Ecore_X_Atom *)data; 236 atoms = (Ecore_X_Atom *)data;