summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Blumenkrantz <zmike@samsung.com>2019-05-30 13:10:53 -0400
committerMike Blumenkrantz <zmike@samsung.com>2019-05-30 13:10:53 -0400
commitd1bc3ea258d64a698e9868698e0382ad2b182ca7 (patch)
treeb3f44e430342ec1b08ce5470816d1040e21d662b
parentd3ef3d6af109fa028912ae2ec46a74a3ce2bf969 (diff)
elm/fileselector_button: null fileselector model pointer on delete
Summary: the data for this object may be further referenced during deletion after this point without triggering errors, so ensure that pointers which are accessible with api functions do not persist after deletion @fix Depends on D8985 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8986
-rw-r--r--src/lib/elementary/elc_fileselector_button.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/lib/elementary/elc_fileselector_button.c b/src/lib/elementary/elc_fileselector_button.c
index df7259e09c..5e10e83063 100644
--- a/src/lib/elementary/elc_fileselector_button.c
+++ b/src/lib/elementary/elc_fileselector_button.c
@@ -243,8 +243,7 @@ _elm_fileselector_button_efl_canvas_group_group_add(Eo *obj, Elm_Fileselector_Bu
243EOLIAN static void 243EOLIAN static void
244_elm_fileselector_button_efl_canvas_group_group_del(Eo *obj, Elm_Fileselector_Button_Data *sd) 244_elm_fileselector_button_efl_canvas_group_group_del(Eo *obj, Elm_Fileselector_Button_Data *sd)
245{ 245{
246 if (sd->fsd.model) 246 efl_replace(&sd->fsd.model, NULL);
247 efl_unref(sd->fsd.model);
248 eina_stringshare_del(sd->window_title); 247 eina_stringshare_del(sd->window_title);
249 eina_stringshare_del(sd->fsd.path); 248 eina_stringshare_del(sd->fsd.path);
250 if (sd->fsd.selection) 249 if (sd->fsd.selection)