diff options
authorJeonghyun Yun <>2017-10-18 20:15:12 +0900
committerJean-Philippe Andre <>2017-10-18 20:31:05 +0900
commit80a5297ae4bee5d1ed9a44c62cf5486b5220e1d9 (patch)
parent83d063692fafcd54d46f9e487b116481025a482e (diff)
elm_scroller: fix scrolling with key move
Use content_region_show instead of content_pos_set in _key_action_move Summary: When user keep pressing key down or else on scroller content, scroller animation is lagging because of elm_interface_scrollable_content_pos_set by step_x or step_y value. When focus moved to next object by press key down or else, content_pos_set by ecore_animator continuously. In this time, content_pos_set in _key_action_move by step_x or step_y value caused animation lagging problem. I fixed to use content_region_show instead of content_pos_set in _key_action_move for remove exist animator. Test Plan: 1. elementary_test -> Scroller3 2. Press 3 times "Append 10 Items in 3s" button 3. focus to Item1 and keep pressing key_down Reviewers: jpeg, woohyun Subscribers: cedric, jpeg Differential Revision:
1 files changed, 1 insertions, 2 deletions
diff --git a/src/lib/elementary/elm_scroller.c b/src/lib/elementary/elm_scroller.c
index 9ddfce9dcd..1e4f4064b0 100644
--- a/src/lib/elementary/elm_scroller.c
+++ b/src/lib/elementary/elm_scroller.c
@@ -255,8 +255,7 @@ _key_action_move(Evas_Object *obj, const char *params)
255 } 255 }
256 else return EINA_FALSE; 256 else return EINA_FALSE;
257 257
258 elm_interface_scrollable_content_pos_set(obj, x, y, EINA_TRUE); 258 elm_interface_scrollable_content_region_show(obj, x, y, v_w, v_h);
260 259
261 return EINA_TRUE; 260 return EINA_TRUE;
262} 261}