diff options
authorTom Hacohen <>2013-10-03 18:45:07 +0100
committerTom Hacohen <>2013-10-03 18:45:07 +0100
commit82f5f78dac8d3055fe1e1c3431875250456887b9 (patch)
parentfe33aa74084aa383fb880ce9a32fa17663c41346 (diff)
Revert "evas/textblock - null check."
I'm sorry, but those kind of commit messages are unacceptable for code I'm the only maintainer of. It's bad enough that to have them in the project in general, but this I won't accept. I wanted to review this commit, but the lack of explanation about what you are trying to fix and why you think this is the good fix prevents me from doing my job. However, without really looking too much into it, this commit looks wrong. evas_textblock_cursor_format_is_visible_get should verify there's a format node... Please come up with a better commit message and re-commit. This reverts commit fe33aa74084aa383fb880ce9a32fa17663c41346.
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c
index de53f114d2..021f59aaee 100644
--- a/src/lib/evas/canvas/evas_object_textblock.c
+++ b/src/lib/evas/canvas/evas_object_textblock.c
@@ -8887,7 +8887,6 @@ evas_textblock_cursor_content_get(const Evas_Textblock_Cursor *cur)
8887 char *ret; 8887 char *ret;
8888 fnode = _evas_textblock_node_visible_at_pos_get( 8888 fnode = _evas_textblock_node_visible_at_pos_get(
8889 evas_textblock_cursor_format_get(cur)); 8889 evas_textblock_cursor_format_get(cur));
8890 if (!fnode) return NULL;
8891 8890
8892 buf = eina_strbuf_new(); 8891 buf = eina_strbuf_new();
8893 _markup_get_format_append(buf, fnode); 8892 _markup_get_format_append(buf, fnode);