summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunsuChoi <jsuya.choi@samsung.com>2020-02-05 10:47:14 +0900
committerHermet Park <hermetpark@gmail.com>2020-02-05 10:47:15 +0900
commitfcdf523b9864340e5ce8acff2335ff9342373849 (patch)
tree8efdc7c7f4a45aef3c1a6edde994509ada136ad9
parentba99891710a558412f0962f79993a5b9651eae59 (diff)
software_evas_engine: Remove unnecessary member for ector_surface_set
Summary: The clear of the Evas_Thread_Command_Ector_Surface structure is an unmanaged variable. When ector calls _draw_thread_ector_surface_set and it checks the clear value. the clear value is garbage value. This can cause the pixels to fail to initialize. This is why afterimages remain after updating shapes while using ector surfaces. Test Plan: ./build/src/examples/evas/efl-canvas-vg-simple 1 - Basic Shape test Scale up 's' or do something Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11278
-rw-r--r--src/modules/evas/engines/software_generic/evas_engine.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/modules/evas/engines/software_generic/evas_engine.c b/src/modules/evas/engines/software_generic/evas_engine.c
index 44c169c781..13c6e5fec1 100644
--- a/src/modules/evas/engines/software_generic/evas_engine.c
+++ b/src/modules/evas/engines/software_generic/evas_engine.c
@@ -414,7 +414,6 @@ struct _Evas_Thread_Command_Ector_Surface
414 Ector_Surface *ector; 414 Ector_Surface *ector;
415 void *pixels; 415 void *pixels;
416 int x, y; 416 int x, y;
417 Eina_Bool clear;
418}; 417};
419 418
420// declare here as it is re-used 419// declare here as it is re-used
@@ -4455,7 +4454,7 @@ _draw_thread_ector_surface_set(void *data)
4455 x = ector_surface->x; 4454 x = ector_surface->x;
4456 y = ector_surface->y; 4455 y = ector_surface->y;
4457 // clear the surface before giving to ector 4456 // clear the surface before giving to ector
4458 if (ector_surface->clear) memset(pixels, 0, (w * h * 4)); 4457 memset(pixels, 0, (w * h * 4));
4459 } 4458 }
4460 } 4459 }
4461 4460