summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShinwoo Kim <cinoo.kim@samsung.com>2020-02-17 21:29:56 +0900
committerHermet Park <hermetpark@gmail.com>2020-02-17 21:30:09 +0900
commit5b349c1ea1a580c81bec2eb726d8cf7cfc311c82 (patch)
tree33c01e8f797862e234e3ab71f180964382566168
parentcf02feb9babf8a7b6765fb0d975da1f199bdee11 (diff)
elm_transit: remove unnecessary image preload invocation
Summary: If user uses image object with following step, then unnecessary preloading related line is invocated in elm_image_file_set. elm_image_file_set(obj, file, NULL) elm_icon_preload_disabled_set(obj, EINA_TRUE) The following is the preloading related line triggered by elm_image_file_set. (#0) _image_preload_internal (#1) _evas_image_load_async_start (#2) evas_object_image_preload (#3) _efl_ui_image_smart_internal_file_set (#4) _efl_ui_image_efl_file_load (#5) efl_file_load (#6) efl_file_simple_load (#7) elm_image_file_set Moreover there is a flickering issue caused by the unnecessary preloading. A test code is attached. Test Plan: Use following test code. The flickering issue occurs with `ELM_SCALE=10 ELM_ACCEL=gl ./test_transit` {F3847288} Reviewers: Hermet, jsuya Reviewed By: Hermet, jsuya Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11364
-rw-r--r--src/lib/elementary/elm_transit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/elementary/elm_transit.c b/src/lib/elementary/elm_transit.c
index 39dc755604..590c416535 100644
--- a/src/lib/elementary/elm_transit.c
+++ b/src/lib/elementary/elm_transit.c
@@ -2621,8 +2621,8 @@ _transit_effect_image_animation_op(Elm_Transit_Effect *effect, Elm_Transit *tran
2621 const char *file = eina_list_nth(image_animation->images, 2621 const char *file = eina_list_nth(image_animation->images,
2622 idx); 2622 idx);
2623 2623
2624 elm_image_file_set(obj, file, NULL);
2625 elm_image_preload_disabled_set(obj, EINA_TRUE); 2624 elm_image_preload_disabled_set(obj, EINA_TRUE);
2625 elm_image_file_set(obj, file, NULL);
2626 } 2626 }
2627 } 2627 }
2628 2628