summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Blumenkrantz <zmike@samsung.com>2020-03-17 12:02:23 -0400
committerMarcel Hollerbach <mail@marcel-hollerbach.de>2020-03-25 22:12:59 +0100
commite8eb67a557485caaca3733ae66f4da4c36517134 (patch)
tree64d2065c4675f186d517bdd3746602f28acddd1c
parent66e2d71414718c65a2c8905118b4c55b6e4e4044 (diff)
ecore/audio: add ERR messages when trying to overwrite existing vio
this probably causes a crash or a leak at some point Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11526
-rw-r--r--src/lib/ecore_audio/ecore_audio_obj_in.c5
-rw-r--r--src/lib/ecore_audio/ecore_audio_obj_out.c5
2 files changed, 8 insertions, 2 deletions
diff --git a/src/lib/ecore_audio/ecore_audio_obj_in.c b/src/lib/ecore_audio/ecore_audio_obj_in.c
index b2a8f912c3..dcb792c8af 100644
--- a/src/lib/ecore_audio/ecore_audio_obj_in.c
+++ b/src/lib/ecore_audio/ecore_audio_obj_in.c
@@ -155,7 +155,10 @@ _ecore_audio_in_ecore_audio_vio_set(Eo *eo_obj, Ecore_Audio_Input *obj, Ecore_Au
155 Ecore_Audio_Object *ea_obj = efl_data_scope_get(eo_obj, ECORE_AUDIO_CLASS); 155 Ecore_Audio_Object *ea_obj = efl_data_scope_get(eo_obj, ECORE_AUDIO_CLASS);
156 156
157 if (ea_obj->vio) 157 if (ea_obj->vio)
158 _free_vio(ea_obj); 158 {
159 ERR("VIO already set!");
160 _free_vio(ea_obj);
161 }
159 162
160 obj->seekable = obj->seekable_prev; 163 obj->seekable = obj->seekable_prev;
161 164
diff --git a/src/lib/ecore_audio/ecore_audio_obj_out.c b/src/lib/ecore_audio/ecore_audio_obj_out.c
index 7e1d39beca..4c05b218da 100644
--- a/src/lib/ecore_audio/ecore_audio_obj_out.c
+++ b/src/lib/ecore_audio/ecore_audio_obj_out.c
@@ -118,7 +118,10 @@ _ecore_audio_out_ecore_audio_vio_set(Eo *eo_obj, Ecore_Audio_Output *_pd EINA_UN
118 Ecore_Audio_Object *ea_obj = efl_data_scope_get(eo_obj, ECORE_AUDIO_CLASS); 118 Ecore_Audio_Object *ea_obj = efl_data_scope_get(eo_obj, ECORE_AUDIO_CLASS);
119 119
120 if (ea_obj->vio) 120 if (ea_obj->vio)
121 _free_vio(ea_obj); 121 {
122 ERR("VIO already set!");
123 _free_vio(ea_obj);
124 }
122 125
123 if (!vio) 126 if (!vio)
124 return; 127 return;