summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Schmidt <s.schmidt@samsung.com>2020-04-17 15:23:44 +0200
committerStefan Schmidt <s.schmidt@samsung.com>2020-04-20 12:20:54 +0200
commit6b1ed0f5737fa5a531ed016f8f0cacc9fafcca1b (patch)
tree6a0d55c03559c9ee2db0a4e9a24dc021dc6ba3dd
parent25f4cba10dd136bd7fdd4a92263dfdbc5d898604 (diff)
exactness: make sure we handle a negative file descriptor
In an error case the fd could be negative here and we should check before feeding it into fdopen(). This is the same patch we used in recorder.c CID: 1422194 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11728
-rw-r--r--src/bin/exactness/player.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/bin/exactness/player.c b/src/bin/exactness/player.c
index 870cc51d27..2dcf3f5e59 100644
--- a/src/bin/exactness/player.c
+++ b/src/bin/exactness/player.c
@@ -983,6 +983,7 @@ _setup_font_settings(const char *fonts_dir)
983 if (chosen_fonts) 983 if (chosen_fonts)
984 { 984 {
985 int tmp_fd = eina_file_mkstemp("/tmp/fonts_XXXXXX.conf", &fonts_conf_name); 985 int tmp_fd = eina_file_mkstemp("/tmp/fonts_XXXXXX.conf", &fonts_conf_name);
986 if (tmp_fd < 0) return EINA_FALSE;
986 FILE *tmp_f = fdopen(tmp_fd, "wb"); 987 FILE *tmp_f = fdopen(tmp_fd, "wb");
987 fprintf(tmp_f, 988 fprintf(tmp_f,
988 "<?xml version=\"1.0\"?>\n<!DOCTYPE fontconfig SYSTEM \"fonts.dtd\">\n<fontconfig>\n" 989 "<?xml version=\"1.0\"?>\n<!DOCTYPE fontconfig SYSTEM \"fonts.dtd\">\n<fontconfig>\n"