summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunsuChoi <jsuya.choi@samsung.com>2020-05-12 10:01:12 -0400
committerMike Blumenkrantz <zmike@samsung.com>2020-05-12 10:01:12 -0400
commit0febbf71ff54d06174e8f22b48741e897053f9d5 (patch)
treee61b094c130c57dbb339987c44d56a8cd64f7c9c
parent89eabfc5960d3650c01f6faa54fae3b00c2bbc55 (diff)
Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contentsdevs/zmike/buildtest
Summary: When call elm_radio_add, theme_apply of layout is called and _efl_ui_radio_legacy_efl_ui_widget_theme_apply is called. Then it calls the signal emit for the icon. this call is unnecessary. Test Plan: Evas_Object *bt; clock_t start, finish; double sum= 0 ; double avg = 0; double cnt = 1000; for(int i =0 ; i<(int)cnt; i++) { start = clock(); bt = elm_radio_add(win); finish = clock(); sum += (double)(finish-start)/CLOCKS_PER_SEC; } avg = sum / cnt ; printf("radio avg : %f\n",avg); [before] radio avg : 0.000232 [after] radio avg : 0.000197 Reviewers: akanad, Jaehyun_Cho, Hermet, YOhoho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11813
-rw-r--r--src/lib/elementary/efl_ui_radio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/elementary/efl_ui_radio.c b/src/lib/elementary/efl_ui_radio.c
index e631cb81f3..34a82c737c 100644
--- a/src/lib/elementary/efl_ui_radio.c
+++ b/src/lib/elementary/efl_ui_radio.c
@@ -365,7 +365,7 @@ _efl_ui_radio_legacy_efl_ui_widget_theme_apply(Eo *obj, void *_pd EINA_UNUSED)
365 /* FIXME: replicated from elm_layout just because radio's icon 365 /* FIXME: replicated from elm_layout just because radio's icon
366 * spot is elm.swallow.content, not elm.swallow.icon. Fix that 366 * spot is elm.swallow.content, not elm.swallow.icon. Fix that
367 * whenever we can changed the theme API */ 367 * whenever we can changed the theme API */
368 _icon_signal_emit(obj); 368 if (efl_finalized_get(obj)) _icon_signal_emit(obj);
369 369
370 return int_ret; 370 return int_ret;
371} 371}