summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Blumenkrantz <zmike@samsung.com>2014-01-20 22:00:47 -0500
committerMike Blumenkrantz <zmike@samsung.com>2014-01-20 22:16:18 -0500
commit1feed7a1aec147ef8f3a0829437e749dde8c373f (patch)
treeec4a9676f8ceb05f0288ab4f344c269599169292
parent414b447f54638a6c241c3a55c235945e76c6972f (diff)
ecore_x_randr_output_name_get fixme removed
this was a fixme which was likely written sometime before July 2010 when the bug was fixed, just prior to the 1.3.1 release. I think it's probably okay to require that release since it's been 3+ years.
-rw-r--r--configure.ac4
-rw-r--r--src/lib/ecore_x/xlib/ecore_x_randr.c9
2 files changed, 6 insertions, 7 deletions
diff --git a/configure.ac b/configure.ac
index 9d12cc813c..2d2e3773dc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2875,6 +2875,10 @@ if test "x${want_x11_xlib}" = "xyes" ; then
2875 ECORE_CHECK_X_EXTENSION([Xtest], [XTest.h], [Xtst], [XTestFakeKeyEvent]) 2875 ECORE_CHECK_X_EXTENSION([Xtest], [XTest.h], [Xtst], [XTestFakeKeyEvent])
2876 ECORE_CHECK_X_EXTENSION([Xss], [scrnsaver.h], [Xss], [XScreenSaverSelectInput]) 2876 ECORE_CHECK_X_EXTENSION([Xss], [scrnsaver.h], [Xss], [XScreenSaverSelectInput])
2877 2877
2878 if test echo "$ECORE_X_LIBS" | grep -q Xrandr ; then
2879 PKG_CHECK_EXISTS([xrandr > 1.3.1], [], [AC_MSG_ERROR([Xrandr >= 1.3.1 required])])
2880 fi
2881
2878 if test "${want_xpresent}" = "yes"; then 2882 if test "${want_xpresent}" = "yes"; then
2879 ECORE_CHECK_X_EXTENSION([Xpresent], [Xpresent.h], [Xpresent], [XPresentQueryExtension]) 2883 ECORE_CHECK_X_EXTENSION([Xpresent], [Xpresent.h], [Xpresent], [XPresentQueryExtension])
2880 fi 2884 fi
diff --git a/src/lib/ecore_x/xlib/ecore_x_randr.c b/src/lib/ecore_x/xlib/ecore_x_randr.c
index c33760bfe2..a88fcff609 100644
--- a/src/lib/ecore_x/xlib/ecore_x_randr.c
+++ b/src/lib/ecore_x/xlib/ecore_x_randr.c
@@ -2206,13 +2206,8 @@ ecore_x_randr_output_name_get(Ecore_X_Window root, Ecore_X_Randr_Output output,
2206 { 2206 {
2207 if (info->name) 2207 if (info->name)
2208 { 2208 {
2209 /* FIXME: TODO: NB: 2209 ret = malloc(info->nameLen);
2210 * 2210 memcpy(ret, info->name, info->nameLen);
2211 * Old randr code says there is an xrandr bug here with
2212 * nameLen. Test This !!!
2213 *
2214 */
2215 ret = strdup(info->name);
2216 if (len) *len = info->nameLen; 2211 if (len) *len = info->nameLen;
2217 } 2212 }
2218 2213