|author||Cedric BAIL <email@example.com>||2017-02-27 15:01:34 -0800|
|committer||Cedric BAIL <firstname.lastname@example.org>||2017-02-27 15:05:35 -0800|
ecore: forcefully flush pending event when ecore_shutdown is called.
If a component emit Ecore_Event and they aren't processed before the call it call ecore_shutdown, there is no way to prevent this event from being triggered after the component at shutdown itself. Which may well lead to a use after free case. As we don't know which event are pending and we also are not shuting down ecore completely as they are still other component using it, we can only flush all pending event right away.
2 files changed, 7 insertions, 1 deletions
|@@ -354,6 +354,13 @@ ecore_shutdown(void)|
|354||ERR("Init count not greater than 0 in shutdown.");||354||ERR("Init count not greater than 0 in shutdown.");|
|355||return 0;||355||return 0;|
|358||// We need to flush all pending event as this is|
|359||// the only way to properly avoid use after free|
|360||// during shutdown of component that may have|
|361||// emitted and still pending event.|
|357||if (_ecore_init_count-- != _ecore_init_count_threshold)||364||if (_ecore_init_count-- != _ecore_init_count_threshold)|
|358||goto end;||365||goto end;|
|@@ -605,4 +605,3 @@ _ecore_event_signal_realtime_new(void)|
|606||return calloc(1, sizeof(Ecore_Event_Signal_Realtime));||606||return calloc(1, sizeof(Ecore_Event_Signal_Realtime));|