summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2017-07-29 00:46:01 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2017-07-29 09:08:40 +0900
commit302731e1af526cd04bb01ef479d46484fd3df58a (patch)
treecfeca5786362ad13ac834f97ca2d40d4e74b1e49
parentb944fc7c9bb4016ed54d440759ae463aec8404ee (diff)
evas events - remove set of list to null then back to value - confusing
eina_list_free always returns NULL. it's meant as a design pattern to follow like the append/prepend that ensures a freed list is NULL, but it can be confusing to analysers so remove the assing. not a bug actually. found by PVS studio
-rw-r--r--src/lib/evas/canvas/evas_events.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/evas/canvas/evas_events.c b/src/lib/evas/canvas/evas_events.c
index e6e3efffc5..e1184e1066 100644
--- a/src/lib/evas/canvas/evas_events.c
+++ b/src/lib/evas/canvas/evas_events.c
@@ -1516,7 +1516,7 @@ _canvas_event_feed_mouse_down_internal(Evas_Public_Data *e, Efl_Input_Pointer_Da
1516 pdata->seat->x, 1516 pdata->seat->x,
1517 pdata->seat->y); 1517 pdata->seat->y);
1518 /* free our old list of ins */ 1518 /* free our old list of ins */
1519 pdata->seat->object.in = eina_list_free(pdata->seat->object.in); 1519 eina_list_free(pdata->seat->object.in);
1520 /* and set up the new one */ 1520 /* and set up the new one */
1521 pdata->seat->object.in = ins; 1521 pdata->seat->object.in = ins;
1522 /* adjust grabbed count by the nuymber of currently held down 1522 /* adjust grabbed count by the nuymber of currently held down
@@ -2594,7 +2594,7 @@ _canvas_event_feed_mouse_in_internal(Evas *eo_e, Efl_Input_Pointer_Data *ev)
2594 } 2594 }
2595 } 2595 }
2596 /* free our old list of ins */ 2596 /* free our old list of ins */
2597 pdata->seat->object.in = eina_list_free(pdata->seat->object.in); 2597 eina_list_free(pdata->seat->object.in);
2598 /* and set up the new one */ 2598 /* and set up the new one */
2599 pdata->seat->object.in = ins; 2599 pdata->seat->object.in = ins;
2600 _evas_post_event_callback_call(eo_e, e, event_id); 2600 _evas_post_event_callback_call(eo_e, e, event_id);