summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYeshwanth Reddivari <yashu21985@gmail.com>2018-07-31 07:29:03 -0500
committerDerek Foreman <derek.foreman.samsung@gmail.com>2018-07-31 07:29:03 -0500
commit52cf0a49c6da3874367be39f26171449898bf38f (patch)
treec37382903fe26f91589cd0745ead4b0f9529be34
parentdc2ad11281cd0d7a68696df80990612fc6b25b3b (diff)
region_add: Fix copying wrong rect during smart merge
Summary: When testing partial rendering on TV, found this bug. Probably this was caused because of wrong copy/paste. When region1 completely subsumes region2, region2 should be ignored. But currently region2 is copied to region1 which makes region1 rect completly wrong. This was causing lot of visual defects because of wrong rects. This patch will fix those visual defects when partial rendering is enabled. Test Plan: Tested with the patch on TV after enabling partial rendering. Reviewers: raster, cedric, Hermet, ManMower Reviewed By: ManMower Subscribers: bu5hm4n, ajwillia.ms, ManMower, devilhorns, cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6696
-rw-r--r--src/lib/evas/canvas/render2/region.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/lib/evas/canvas/render2/region.c b/src/lib/evas/canvas/render2/region.c
index 92da332abd..b7747faf76 100644
--- a/src/lib/evas/canvas/render2/region.c
+++ b/src/lib/evas/canvas/render2/region.c
@@ -851,10 +851,7 @@ region_add(Region *dest, Region *source)
851 851
852 // Region 1 completely subsumes region 2 852 // Region 1 completely subsumes region 2
853 if (!dest->data && CONTAINS(&dest->bound, &source->bound)) 853 if (!dest->data && CONTAINS(&dest->bound, &source->bound))
854 {
855 if (dest != source) return region_copy(dest, source);
856 return EINA_TRUE; 854 return EINA_TRUE;
857 }
858 855
859 // Region 2 completely subsumes region 1 856 // Region 2 completely subsumes region 1
860 if (!source->data && CONTAINS(&source->bound, &dest->bound)) 857 if (!source->data && CONTAINS(&source->bound, &dest->bound))